From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net
Subject: [PATCH] NFS - Missing unlock_kernel() in lookup path
Date: Mon, 01 Aug 2005 14:00:37 -0400 [thread overview]
Message-ID: <42EE6345.90505@RedHat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
Hey Trond,
I was backport some patches and noticed that nfs_atomic_lookup()
seems to be missing an unlock_kernel()... I would think that
nfs_atomic_lookup() should unlock_kernel() when nfs_revalidate_inode()
fails... true?
steved.
[-- Attachment #2: linux-2.6.12.3-nfs-missing-lock.patch --]
[-- Type: text/x-patch, Size: 488 bytes --]
Added missing unlock_kernel() to NFS lookup patch.
Signed-off-by: Steve Dickson <steved@redhat.com>
-----------------------------------------------
--- linux-2.6.12.3/fs/nfs/dir.c.orig 2005-07-15 17:18:57.000000000 -0400
+++ linux-2.6.12.3/fs/nfs/dir.c 2005-08-01 13:46:19.000000000 -0400
@@ -835,6 +835,7 @@ static struct dentry *nfs_atomic_lookup(
error = nfs_revalidate_inode(NFS_SERVER(dir), dir);
if (error < 0) {
res = ERR_PTR(error);
+ unlock_kernel();
goto out;
}
reply other threads:[~2005-08-01 18:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EE6345.90505@RedHat.com \
--to=steved@redhat.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox