Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] NFS - Missing unlock_kernel() in lookup path
@ 2005-08-01 18:00 Steve Dickson
  0 siblings, 0 replies; only message in thread
From: Steve Dickson @ 2005-08-01 18:00 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: nfs

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

Hey Trond,

I was backport some patches and noticed that nfs_atomic_lookup()
seems to be missing an unlock_kernel()... I would think that
nfs_atomic_lookup() should unlock_kernel() when nfs_revalidate_inode()
fails... true?

steved.


[-- Attachment #2: linux-2.6.12.3-nfs-missing-lock.patch --]
[-- Type: text/x-patch, Size: 488 bytes --]

Added missing unlock_kernel() to NFS lookup patch.

Signed-off-by: Steve Dickson <steved@redhat.com>
-----------------------------------------------
--- linux-2.6.12.3/fs/nfs/dir.c.orig	2005-07-15 17:18:57.000000000 -0400
+++ linux-2.6.12.3/fs/nfs/dir.c	2005-08-01 13:46:19.000000000 -0400
@@ -835,6 +835,7 @@ static struct dentry *nfs_atomic_lookup(
 	error = nfs_revalidate_inode(NFS_SERVER(dir), dir);
 	if (error < 0) {
 		res = ERR_PTR(error);
+		unlock_kernel();
 		goto out;
 	}
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-08-01 18:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-01 18:00 [PATCH] NFS - Missing unlock_kernel() in lookup path Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox