From: Sagi Grimberg <sagi@grimberg.me>
To: Scott Mayhew <smayhew@redhat.com>, cel@kernel.org
Cc: linux-nfs@vger.kernel.org, kernel-tls-handshake@lists.linux.dev
Subject: Re: [PATCH] tlshd: fix keyring cert retrieval
Date: Sun, 3 May 2026 10:30:57 +0300 [thread overview]
Message-ID: <44f3b3fb-8d08-4171-9f5c-ff1a643a412f@grimberg.me> (raw)
In-Reply-To: <20260501195856.1126025-1-smayhew@redhat.com>
On 01/05/2026 22:58, Scott Mayhew wrote:
> The code that gets certs from keyrings currently only gets RSA certs, so
> we need to zero out the PQ certs length fields when a keyring is used.
> Otherwise the retrieval callback will look in the wrong offset in the
> tlshd_certs list.
>
> Reported-by: Sagi Grimberg <sagi@grimberg.me>
> Fixes: facd084 ("tlshd: Client-side dual certificate support")
> Fixes: 14f5349 ("tlshd: Server-side dual certificate support")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
next prev parent reply other threads:[~2026-05-03 7:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 13:32 Breakage in ktls-utils with nfs keyring? Sagi Grimberg
2026-04-30 13:38 ` Chuck Lever
2026-05-01 19:58 ` [PATCH] tlshd: fix keyring cert retrieval Scott Mayhew
2026-05-03 7:30 ` Sagi Grimberg [this message]
2026-05-01 20:19 ` Breakage in ktls-utils with nfs keyring? Scott Mayhew
2026-05-02 3:08 ` Chuck Lever
2026-05-03 7:48 ` Sagi Grimberg
2026-05-03 19:11 ` Chuck Lever
2026-05-03 20:37 ` Sagi Grimberg
2026-05-04 6:44 ` Chuck Lever
2026-05-04 8:02 ` Sagi Grimberg
2026-05-04 8:21 ` Hannes Reinecke
2026-05-05 8:15 ` Chuck Lever
2026-05-05 8:32 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f3b3fb-8d08-4171-9f5c-ff1a643a412f@grimberg.me \
--to=sagi@grimberg.me \
--cc=cel@kernel.org \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox