Linux NFS development
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Breakage in ktls-utils with nfs keyring?
Date: Thu, 30 Apr 2026 16:32:16 +0300	[thread overview]
Message-ID: <fd4aaf4e-b1b7-4ca2-bc93-955c31fab317@grimberg.me> (raw)

Hey Chuck,

Upstream ktls-utils fails passing client certificate and private key 
using the .nfs keyring.
Bisecting leads commit facd084e43fc ("tlshd: Client-side dual 
certificate support").

I manually apply this (probably wrong) change and keyring works:
--
diff --git a/src/tlshd/client.c b/src/tlshd/client.c
index 2664ffb..a946797 100644
--- a/src/tlshd/client.c
+++ b/src/tlshd/client.c
@@ -327,7 +327,7 @@ tlshd_x509_retrieve_key_cb(gnutls_session_t session,
         } else {
                 tlshd_log_debug("%s: Selecting x509.certificate from 
conf file", __func__);
                 *pcert_length = tlshd_certs_len;
-               *pcert = tlshd_certs + tlshd_pq_certs_len;
+               *pcert = tlshd_certs;
                 *privkey = tlshd_privkey;
         }
         return 0;
--

But, I have a feeling its not the correct change...

             reply	other threads:[~2026-04-30 13:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 13:32 Sagi Grimberg [this message]
2026-04-30 13:38 ` Breakage in ktls-utils with nfs keyring? Chuck Lever
2026-05-01 19:58   ` [PATCH] tlshd: fix keyring cert retrieval Scott Mayhew
2026-05-03  7:30     ` Sagi Grimberg
2026-05-01 20:19   ` Breakage in ktls-utils with nfs keyring? Scott Mayhew
2026-05-02  3:08     ` Chuck Lever
2026-05-03  7:48       ` Sagi Grimberg
2026-05-03 19:11         ` Chuck Lever
2026-05-03 20:37           ` Sagi Grimberg
2026-05-04  6:44             ` Chuck Lever
2026-05-04  8:02               ` Sagi Grimberg
2026-05-04  8:21                 ` Hannes Reinecke
2026-05-05  8:15               ` Chuck Lever
2026-05-05  8:32                 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd4aaf4e-b1b7-4ca2-bc93-955c31fab317@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox