Re: [PATCH] NFS: have string-based mount options default to "intr" mounts

From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: nfsv4@linux-nfs.org, nfs@lists.sourceforge.net
Subject: Re: [PATCH] NFS: have string-based mount options default to "intr" mounts
Date: Wed, 25 Jul 2007 15:36:18 -0400	[thread overview]
Message-ID: <46A7A632.2050900@oracle.com> (raw)
In-Reply-To: <20070725145614.e17ca721.jlayton@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

I thought "nointr" was the default because it is safest.

Jeff Layton wrote:
> The current string-based mount options default to "nointr" mounts. This
> is consistent with the current behavior of the struct-based mount
> options for NFSv2/3, but inconsistent with v4.
> 
> I've just sent a nfs-utils patch to make the default be "intr" for all
> NFS flavors. This patch makes the default the same when using
> string-based mount options.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index b2a851c..55f9b8b 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -1122,7 +1122,9 @@ static int nfs_validate_mount_data(struct nfs_mount_data **options,
>  		char *c;
>  		int status;
>  		struct nfs_parsed_mount_data args = {
> -			.flags		= (NFS_MOUNT_VER3 | NFS_MOUNT_TCP),
> +			.flags		= (NFS_MOUNT_INTR |
> +					   NFS_MOUNT_VER3 |
> +					   NFS_MOUNT_TCP),
>  			.rsize		= NFS_MAX_FILE_IO_SIZE,
>  			.wsize		= NFS_MAX_FILE_IO_SIZE,
>  			.timeo		= 600,
> @@ -1608,6 +1610,7 @@ static int nfs4_validate_mount_data(struct nfs4_mount_data **options,
>  	default: {
>  		unsigned int len;
>  		struct nfs_parsed_mount_data args = {
> +			.flags		= NFS4_MOUNT_INTR,
>  			.rsize		= NFS_MAX_FILE_IO_SIZE,
>  			.wsize		= NFS_MAX_FILE_IO_SIZE,
>  			.timeo		= 600,
> _______________________________________________
> NFSv4 mailing list
> NFSv4@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs