Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] nfs-utils: FQDNs in the rmtab causes exportfs to seg fault
@ 2008-06-25  1:04 Steve Dickson
  0 siblings, 0 replies; only message in thread
From: Steve Dickson @ 2008-06-25  1:04 UTC (permalink / raw)
  To: linux-nfs

When a FQDN exists in /var/lib/nfs/rmtab it causes 
the exportfs command to seg fault due to the nfs_export pointer 
not being allocated. Reworking the parentheses in rmtab_read() 
so the htype variable is evaluated correctly fix the problem.

Signed-off-by: Steve Dickson <steved@redhat.com>

diff --git a/support/export/rmtab.c b/support/export/rmtab.c
index 0ce3682..e11a22a 100644
--- a/support/export/rmtab.c
+++ b/support/export/rmtab.c
@@ -31,10 +31,10 @@ rmtab_read(void)
 		int			htype;
 		
 		htype = client_gettype(rep->r_client);
-		if (htype == MCL_FQDN || (htype == MCL_SUBNETWORK
+		if ((htype == MCL_FQDN || htype == MCL_SUBNETWORK)
 		    && (hp = gethostbyname (rep->r_client))
 		    && (hp = hostent_dup (hp),
-			(exp = export_allowed (hp, rep->r_path))))) {
+			exp = export_allowed (hp, rep->r_path))) {
 			/* see if the entry already exists, otherwise this was an instantiated
 			 * wild card, and we must add it
 			 */

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-06-25  1:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-25  1:04 [PATCH] nfs-utils: FQDNs in the rmtab causes exportfs to seg fault Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox