Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] mountd: change "unknown host" error message to "unmatched host"
@ 2008-09-29 12:11 Jeff Layton
  2008-09-29 14:21 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2008-09-29 12:11 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs, nfsv4

I've had a few users mention that they find this message confusing:

     mount request from unknown host 10.11.14.99 for /export

The hosts are listed in DNS with proper reverse records, so the reason
why the host is "unknown" isn't clear. This patch just changes the
wording of this error to hopefully make it more clear why the mount
request was rejected. This also makes this error message use a format
more similar to the other error messages in auth_authenticate().

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 utils/mountd/auth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/utils/mountd/auth.c b/utils/mountd/auth.c
index 2bb708f..dfe61ea 100644
--- a/utils/mountd/auth.c
+++ b/utils/mountd/auth.c
@@ -223,7 +223,7 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path)
 		break;
 
 	case unknown_host:
-		xlog(L_WARNING, "%s request from unknown host %s for %s (%s)",
+		xlog(L_WARNING, "refused %s request from %s for %s (%s): unmatched host",
 		     what, inet_ntoa(addr), path, epath);
 		break;
 
-- 
1.5.5.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mountd: change "unknown host" error message to "unmatched host"
  2008-09-29 12:11 [PATCH] mountd: change "unknown host" error message to "unmatched host" Jeff Layton
@ 2008-09-29 14:21 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2008-09-29 14:21 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-nfs, nfsv4



Jeff Layton wrote:
> I've had a few users mention that they find this message confusing:
> 
>      mount request from unknown host 10.11.14.99 for /export
> 
> The hosts are listed in DNS with proper reverse records, so the reason
> why the host is "unknown" isn't clear. This patch just changes the
> wording of this error to hopefully make it more clear why the mount
> request was rejected. This also makes this error message use a format
> more similar to the other error messages in auth_authenticate().
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Committed.

steved.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-29 14:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-29 12:11 [PATCH] mountd: change "unknown host" error message to "unmatched host" Jeff Layton
2008-09-29 14:21 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox