From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Olaf Kirch <okir@suse.de>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] nfs-utils: Enabling TCP wrappers
Date: Thu, 18 Dec 2008 15:49:18 -0500 [thread overview]
Message-ID: <494AB74E.3040403@RedHat.com> (raw)
In-Reply-To: <04AA0955-045D-432B-B96D-4A21F4889F6D@oracle.com>
Chuck Lever wrote:
>> @@ -72,12 +74,29 @@ mount_dispatch(struct svc_req *rqstp, SVCXPRT
>> *transp)
>> union mountd_results result;
>>
>> #ifdef HAVE_TCP_WRAPPER
>> +#ifdef IPV6_SUPPORTED
>> + static int once = 0;
>> +
>> + if (svc_getcaller(transp)->sin_family != AF_INET) {
>
> It's not clear to me that svc_getcaller() will ever return a non-AF_INET
> address.
>
> Should we use svc_getcaller_netbuf() here instead?
I would if I could but there is no svc_getcaller_netbuf() in the
glibc version of RPC...
steved.
next prev parent reply other threads:[~2008-12-18 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 16:54 [PATCH 0/3] nfs-utils: Enabling TCP wrappers Steve Dickson
[not found] ` <49468BC7.2000907-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-15 16:58 ` [PATCH 1/3] " Steve Dickson
2008-12-15 17:10 ` [PATCH 2/3] " Steve Dickson
2008-12-15 17:11 ` [PATCH 3/3] " Steve Dickson
2008-12-15 17:26 ` [PATCH 0/3] " Chuck Lever
2008-12-15 17:56 ` Steve Dickson
2008-12-18 19:59 ` Steve Dickson
[not found] ` <494AABA1.4070006-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-18 20:23 ` Chuck Lever
2008-12-18 20:49 ` Steve Dickson [this message]
[not found] ` <494AB74E.3040403-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-18 20:56 ` Chuck Lever
2008-12-18 21:21 ` Steve Dickson
2008-12-19 17:00 ` Steve Dickson
2008-12-20 12:35 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494AB74E.3040403@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=okir@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox