From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs-utils: Removed a number of warn_unused_result warnings
Date: Tue, 24 Mar 2009 12:56:35 -0400 [thread overview]
Message-ID: <49C910C3.2090700@RedHat.com> (raw)
In-Reply-To: <654687AD-E743-45A4-99B1-BBBEAA5D915D@oracle.com>
Chuck Lever wrote:
> I've actually already addressed all the cases you found under
> utils/statd/... my re-writes replace both nsm_log() and note() with
> calls to xlog(), and add return code checking to the write(2) calls.
Sorry about that... but I already did the commit... since I wanted to
get some testing asap.. so go head and send me the parts I broke
and I will do the forward port...
>
> Also, note that you can use the "%m" format specifier to generate the
> same string you get from strerror(errno).
Yeah.. I knew that... but I thought there some memory corruption
or service denial issue with using "%m" so I've always stuck
with '%d (%s)'.
steved.
next prev parent reply other threads:[~2009-03-24 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 14:08 [PATCH] nfs-utils: Removed a number of warn_unused_result warnings Steve Dickson
[not found] ` <49C797C6.8030102-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-03-24 16:19 ` Chuck Lever
2009-03-24 16:56 ` Steve Dickson [this message]
[not found] ` <49C910C3.2090700-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-03-24 17:08 ` Chuck Lever
2009-03-24 17:36 ` Steve Dickson
[not found] ` <49C91A2F.90501-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-03-24 17:44 ` Chuck Lever
2009-03-24 17:51 ` Steve Dickson
[not found] ` <49C91DB7.1050006-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-03-24 19:35 ` Chuck Lever
2009-03-25 14:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C910C3.2090700@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox