Re: [PATCH] nfs-utils: Removed a number of warn_unused_result warnings

[Steve Dickson <SteveD@redhat.com>]

Chuck Lever wrote:
>>>>> Also, note that you can use the "%m" format specifier to generate the
>>>>> same string you get from strerror(errno).
>>>> Yeah.. I knew that... but I thought there some memory corruption
>>>> or service denial issue with using "%m" so I've always stuck
>>>> with '%d (%s)'.
>>>
>>> I use %m routinely.  What exactly are these issues?
>> It was a while ago... but I seem to remember there as an issue
>> with one of the daemons using '%m'.. I want to say a buffer overflow
>> but I just don't remember... It was probably some funky way '%m'
>> was being used...since I sure the normal every day use of '%m"
>> is fine...
> 
> I'm not a security expert, but I can't see how that could be a problem
> for generating log messages (especially any message that precedes a
> daemon's exit).  I'd like to continue using "%m" with xlog() in my own
> patches for the time being.  Is that OK with you?
Sure.. I have no problem with that... 

steved.