[PATCH 0/29] NFSv4.1 Server DRC rewrite Version 2

[PATCH 0/29] NFSv4.1 Server DRC rewrite Version 2

[andros]

Version 2 of the NFSv4.1 DRC rewrite.

V1 -> V2 Differences:

1) Separate structure for the single slot clientid cache because it does not
need several of the fields that the sessions multiple slot cache needs, and
has a different static cache buffer size.

2) Move from a dynamic to a static buffer allocation for the sessions DRC
because we can't promise the client to be able to cache a response and then
run out of memory and not be able to cache a response.
Switch from a 1024 byte to a 512 byte buffer.

3) Removed struct nfsd4_cache_entry, replaced by new nfsd4_slot fields.

4) Global DRC memory limit tracking.


This is a rewrite of the NFSv4.1 DRC, switching from a page based cache to
a buffer based cache. The logic for the single slot clientid cache has been
separated from the session slot logic to handle the CREATE_SESSION call
preceeded by a SEQUENCE and all the replay combinations therein.

The session DRC now caches encoded operations with the exception of the
SEQUENCE operation which for a replay is encoded with the current slot and
session values.  A review of message sizes indicates that a 512 byte buffer
for the operations is adequate.

Not addressed is the necessary pre-operation processing estimate of the encoded
per operation result to check against the negotiated fore channel maximum
response size cached.

I've tested NFSv4.1 mounts using Connectathon and the new pynfs 4.1 tests,
where I added two new Clientid cache replay tests [to be submitted]to
st_create_session.py.

I've tested NFSv4.0 mounts using Connectathon and the pynfs v4.0 tests.

As always, comments and suggestions welcome.

-->Andy

Bug fix
0001-nfsd41-slots-are-freed-with-session.patch

Clientid single slot cache
0002-nfsd41-change-check_slot_seqid-parameters.patch
0003-nfsd41-turn-off-create-session-caching.patch
0004-nfsd41-separate-clientid-slot-from-session-slot.patch
0005-nfsd41-encode-create_session-result-into-cache.patch
0006-nfsd41-create_session-check-replay-first.patch
0007-nfsd41-replay-solo-and-embedded-create-session.patch

Session slot cache
0008-nfsd41-sanity-check-client-drc-maxreqs.patch
0009-nfsd41-change-from-page-to-memory-based-drc-limits.patch
0010-nfsd41-use-globals-for-DRC-memory-use-management.patch
0011-nfsd41-set-the-session-maximum-response-size-cached.patch
0012-nfsd41-use-static-buffers-for-sessions-DRC.patch
0013-nfsd41-replace-ce_cachethis-with-nfsd4_slot-field.patch
0014-nfsd41-replace-ce_opcnt-with-nfsd4_slot-field.patch
0015-nfsd41-nfsd41-replace-ce_status-with-nfsd4_slot-fi.patch
0016-nfsd41-obliterate-nfsd4_copy_pages.patch
0017-nfsd41-obliterate-nfsd41_copy_replay_data.patch
0018-nfsd41-obliterate-nfsd4_release_respages.patch
0019-nfsd41-remove-iovlen-field-from-nfsd4_compound_stat.patch
0020-nfsd41-remove-struct-nfsd4_cache_entry.patch
0021-nfsd41-obliterate-nfsd4_set_statp.patch
0022-nfsd41-rename-nfsd4_enc_uncached_replay.patch
0023-nfsd41-encode-replay-sequence-from-the-slot-values.patch
0024-nfsd41-fix-nfsd4_replay_cache_entry-comments.patch
0025-nfsd41-fix-nfsd4_store_cache_entry-comments.patch
0026-nfsd41-support-16-slots-per-session.patch
0027-nfsd41-use-the-maximum-operations-per-compound-in-n.patch
0028-nfsd41-fix-nfsd4_store_cache_entry-dprintk.patch
0029-nfsd41-add-test-for-failed-sequence-operation.patch
0030-nfsd41-remove-redundant-failed-sequence-check.patch
0031-nfsd41-only-reference-the-session-on-non-replay-seq.patch

[PATCH 1/1] pynfs: set cache_this to false for readdir

[andros]

From: Andy Adamson <andros@netapp.com>

testserver.py was failing initialization against the new Linux server DRC
which has a lower max resonse size cached value than the initializaion
readdir response.

Set cache_this to False

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 nfs4.1/server41tests/environment.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nfs4.1/server41tests/environment.py b/nfs4.1/server41tests/environment.py
index fb0e7ed..8623158 100644
--- a/nfs4.1/server41tests/environment.py
+++ b/nfs4.1/server41tests/environment.py
@@ -415,7 +415,7 @@ def do_readdir(sess, file, cookie=0, cookieverf='', attrs=0L,
     baseops = use_obj(file)
     while True:
         readdir_op = op.readdir(cookie, cookieverf, dircount, maxcount, attrs)
-        res = sess.compound(baseops + [readdir_op])
+        res = sess.compound(baseops + [readdir_op], cache_this=False)
         check(res, msg="READDIR with cookie=%i, maxcount=%i" % (cookie, maxcount))
         reply = res.resarray[-1].reply
         if not reply.entries and not reply.eof:
-- 
1.5.4.3

Re: [PATCH 0/29] NFSv4.1 Server DRC rewrite Version 2

[J. Bruce Fields]

Are these patches against Benny's tree?

I need patches against my tree (ideally, against my for-2.6.31 branch).

If that means sending me patches from Benny's tree first, that's fine.
Just as long as I know what order to go through all these in....

--b.

On Tue, Apr 28, 2009 at 12:56:14PM -0400, andros@netapp.com wrote:
> Version 2 of the NFSv4.1 DRC rewrite.
> 
> V1 -> V2 Differences:
> 
> 1) Separate structure for the single slot clientid cache because it does not
> need several of the fields that the sessions multiple slot cache needs, and
> has a different static cache buffer size.
> 
> 2) Move from a dynamic to a static buffer allocation for the sessions DRC
> because we can't promise the client to be able to cache a response and then
> run out of memory and not be able to cache a response.
> Switch from a 1024 byte to a 512 byte buffer.
> 
> 3) Removed struct nfsd4_cache_entry, replaced by new nfsd4_slot fields.
> 
> 4) Global DRC memory limit tracking.
> 
> 
> This is a rewrite of the NFSv4.1 DRC, switching from a page based cache to
> a buffer based cache. The logic for the single slot clientid cache has been
> separated from the session slot logic to handle the CREATE_SESSION call
> preceeded by a SEQUENCE and all the replay combinations therein.
> 
> The session DRC now caches encoded operations with the exception of the
> SEQUENCE operation which for a replay is encoded with the current slot and
> session values.  A review of message sizes indicates that a 512 byte buffer
> for the operations is adequate.
> 
> Not addressed is the necessary pre-operation processing estimate of the encoded
> per operation result to check against the negotiated fore channel maximum
> response size cached.
> 
> I've tested NFSv4.1 mounts using Connectathon and the new pynfs 4.1 tests,
> where I added two new Clientid cache replay tests [to be submitted]to
> st_create_session.py.
> 
> I've tested NFSv4.0 mounts using Connectathon and the pynfs v4.0 tests.
> 
> As always, comments and suggestions welcome.
> 
> -->Andy
> 
> Bug fix
> 0001-nfsd41-slots-are-freed-with-session.patch
> 
> Clientid single slot cache
> 0002-nfsd41-change-check_slot_seqid-parameters.patch
> 0003-nfsd41-turn-off-create-session-caching.patch
> 0004-nfsd41-separate-clientid-slot-from-session-slot.patch
> 0005-nfsd41-encode-create_session-result-into-cache.patch
> 0006-nfsd41-create_session-check-replay-first.patch
> 0007-nfsd41-replay-solo-and-embedded-create-session.patch
> 
> Session slot cache
> 0008-nfsd41-sanity-check-client-drc-maxreqs.patch
> 0009-nfsd41-change-from-page-to-memory-based-drc-limits.patch
> 0010-nfsd41-use-globals-for-DRC-memory-use-management.patch
> 0011-nfsd41-set-the-session-maximum-response-size-cached.patch
> 0012-nfsd41-use-static-buffers-for-sessions-DRC.patch
> 0013-nfsd41-replace-ce_cachethis-with-nfsd4_slot-field.patch
> 0014-nfsd41-replace-ce_opcnt-with-nfsd4_slot-field.patch
> 0015-nfsd41-nfsd41-replace-ce_status-with-nfsd4_slot-fi.patch
> 0016-nfsd41-obliterate-nfsd4_copy_pages.patch
> 0017-nfsd41-obliterate-nfsd41_copy_replay_data.patch
> 0018-nfsd41-obliterate-nfsd4_release_respages.patch
> 0019-nfsd41-remove-iovlen-field-from-nfsd4_compound_stat.patch
> 0020-nfsd41-remove-struct-nfsd4_cache_entry.patch
> 0021-nfsd41-obliterate-nfsd4_set_statp.patch
> 0022-nfsd41-rename-nfsd4_enc_uncached_replay.patch
> 0023-nfsd41-encode-replay-sequence-from-the-slot-values.patch
> 0024-nfsd41-fix-nfsd4_replay_cache_entry-comments.patch
> 0025-nfsd41-fix-nfsd4_store_cache_entry-comments.patch
> 0026-nfsd41-support-16-slots-per-session.patch
> 0027-nfsd41-use-the-maximum-operations-per-compound-in-n.patch
> 0028-nfsd41-fix-nfsd4_store_cache_entry-dprintk.patch
> 0029-nfsd41-add-test-for-failed-sequence-operation.patch
> 0030-nfsd41-remove-redundant-failed-sequence-check.patch
> 0031-nfsd41-only-reference-the-session-on-non-replay-seq.patch
> 

Re: [PATCH 0/29] NFSv4.1 Server DRC rewrite Version 2

[Benny Halevy]

On May. 16, 2009, 1:46 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> Are these patches against Benny's tree?
> 
> I need patches against my tree (ideally, against my for-2.6.31 branch).

Doesn't make much of a difference...
They apply cleanly on either master or your for-2.6.31 branch.

You can get them from git://linux-nfs.org/~bhalevy/linux-pnfs.git nfsd41-for-2.6.31
which is based on top of your for-2.6.31 branch.

Benny

> 
> If that means sending me patches from Benny's tree first, that's fine.
> Just as long as I know what order to go through all these in....
> 
> --b.
> 
> On Tue, Apr 28, 2009 at 12:56:14PM -0400, andros@netapp.com wrote:
>> Version 2 of the NFSv4.1 DRC rewrite.
>>
>> V1 -> V2 Differences:
>>
>> 1) Separate structure for the single slot clientid cache because it does not
>> need several of the fields that the sessions multiple slot cache needs, and
>> has a different static cache buffer size.
>>
>> 2) Move from a dynamic to a static buffer allocation for the sessions DRC
>> because we can't promise the client to be able to cache a response and then
>> run out of memory and not be able to cache a response.
>> Switch from a 1024 byte to a 512 byte buffer.
>>
>> 3) Removed struct nfsd4_cache_entry, replaced by new nfsd4_slot fields.
>>
>> 4) Global DRC memory limit tracking.
>>
>>
>> This is a rewrite of the NFSv4.1 DRC, switching from a page based cache to
>> a buffer based cache. The logic for the single slot clientid cache has been
>> separated from the session slot logic to handle the CREATE_SESSION call
>> preceeded by a SEQUENCE and all the replay combinations therein.
>>
>> The session DRC now caches encoded operations with the exception of the
>> SEQUENCE operation which for a replay is encoded with the current slot and
>> session values.  A review of message sizes indicates that a 512 byte buffer
>> for the operations is adequate.
>>
>> Not addressed is the necessary pre-operation processing estimate of the encoded
>> per operation result to check against the negotiated fore channel maximum
>> response size cached.
>>
>> I've tested NFSv4.1 mounts using Connectathon and the new pynfs 4.1 tests,
>> where I added two new Clientid cache replay tests [to be submitted]to
>> st_create_session.py.
>>
>> I've tested NFSv4.0 mounts using Connectathon and the pynfs v4.0 tests.
>>
>> As always, comments and suggestions welcome.
>>
>> -->Andy
>>
>> Bug fix
>> 0001-nfsd41-slots-are-freed-with-session.patch
>>
>> Clientid single slot cache
>> 0002-nfsd41-change-check_slot_seqid-parameters.patch
>> 0003-nfsd41-turn-off-create-session-caching.patch
>> 0004-nfsd41-separate-clientid-slot-from-session-slot.patch
>> 0005-nfsd41-encode-create_session-result-into-cache.patch
>> 0006-nfsd41-create_session-check-replay-first.patch
>> 0007-nfsd41-replay-solo-and-embedded-create-session.patch
>>
>> Session slot cache
>> 0008-nfsd41-sanity-check-client-drc-maxreqs.patch
>> 0009-nfsd41-change-from-page-to-memory-based-drc-limits.patch
>> 0010-nfsd41-use-globals-for-DRC-memory-use-management.patch
>> 0011-nfsd41-set-the-session-maximum-response-size-cached.patch
>> 0012-nfsd41-use-static-buffers-for-sessions-DRC.patch
>> 0013-nfsd41-replace-ce_cachethis-with-nfsd4_slot-field.patch
>> 0014-nfsd41-replace-ce_opcnt-with-nfsd4_slot-field.patch
>> 0015-nfsd41-nfsd41-replace-ce_status-with-nfsd4_slot-fi.patch
>> 0016-nfsd41-obliterate-nfsd4_copy_pages.patch
>> 0017-nfsd41-obliterate-nfsd41_copy_replay_data.patch
>> 0018-nfsd41-obliterate-nfsd4_release_respages.patch
>> 0019-nfsd41-remove-iovlen-field-from-nfsd4_compound_stat.patch
>> 0020-nfsd41-remove-struct-nfsd4_cache_entry.patch
>> 0021-nfsd41-obliterate-nfsd4_set_statp.patch
>> 0022-nfsd41-rename-nfsd4_enc_uncached_replay.patch
>> 0023-nfsd41-encode-replay-sequence-from-the-slot-values.patch
>> 0024-nfsd41-fix-nfsd4_replay_cache_entry-comments.patch
>> 0025-nfsd41-fix-nfsd4_store_cache_entry-comments.patch
>> 0026-nfsd41-support-16-slots-per-session.patch
>> 0027-nfsd41-use-the-maximum-operations-per-compound-in-n.patch
>> 0028-nfsd41-fix-nfsd4_store_cache_entry-dprintk.patch
>> 0029-nfsd41-add-test-for-failed-sequence-operation.patch
>> 0030-nfsd41-remove-redundant-failed-sequence-check.patch
>> 0031-nfsd41-only-reference-the-session-on-non-replay-seq.patch
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html