* [PATCH] nfs: Keep index within mnt_errtbl[]
@ 2009-07-12 23:25 Roel Kluin
2009-07-13 12:59 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-07-12 23:25 UTC (permalink / raw)
To: Trond.Myklebust, linux-nfs, Andrew Morton
Ensure that index i remains within array mnt_errtbl[] and mnt3_errtbl[].
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c
index 38ef9ea..8b9affc 100644
--- a/fs/nfs/mount_clnt.c
+++ b/fs/nfs/mount_clnt.c
@@ -258,7 +258,7 @@ static int decode_status(struct xdr_stream *xdr, struct mountres *res)
return -EIO;
status = ntohl(*p);
- for (i = 0; i <= ARRAY_SIZE(mnt_errtbl); i++) {
+ for (i = 0; i < ARRAY_SIZE(mnt_errtbl); i++) {
if (mnt_errtbl[i].status == status) {
res->errno = mnt_errtbl[i].errno;
return 0;
@@ -309,7 +309,7 @@ static int decode_fhs_status(struct xdr_stream *xdr, struct mountres *res)
return -EIO;
status = ntohl(*p);
- for (i = 0; i <= ARRAY_SIZE(mnt3_errtbl); i++) {
+ for (i = 0; i < ARRAY_SIZE(mnt3_errtbl); i++) {
if (mnt3_errtbl[i].status == status) {
res->errno = mnt3_errtbl[i].errno;
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nfs: Keep index within mnt_errtbl[]
2009-07-12 23:25 [PATCH] nfs: Keep index within mnt_errtbl[] Roel Kluin
@ 2009-07-13 12:59 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2009-07-13 12:59 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-nfs, Andrew Morton
On Mon, 2009-07-13 at 01:25 +0200, Roel Kluin wrote:
> Ensure that index i remains within array mnt_errtbl[] and mnt3_errtbl[].
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c
> index 38ef9ea..8b9affc 100644
> --- a/fs/nfs/mount_clnt.c
> +++ b/fs/nfs/mount_clnt.c
> @@ -258,7 +258,7 @@ static int decode_status(struct xdr_stream *xdr, struct mountres *res)
> return -EIO;
> status = ntohl(*p);
>
> - for (i = 0; i <= ARRAY_SIZE(mnt_errtbl); i++) {
> + for (i = 0; i < ARRAY_SIZE(mnt_errtbl); i++) {
> if (mnt_errtbl[i].status == status) {
> res->errno = mnt_errtbl[i].errno;
> return 0;
> @@ -309,7 +309,7 @@ static int decode_fhs_status(struct xdr_stream *xdr, struct mountres *res)
> return -EIO;
> status = ntohl(*p);
>
> - for (i = 0; i <= ARRAY_SIZE(mnt3_errtbl); i++) {
> + for (i = 0; i < ARRAY_SIZE(mnt3_errtbl); i++) {
> if (mnt3_errtbl[i].status == status) {
> res->errno = mnt3_errtbl[i].errno;
> return 0;
Yup. Good catch!
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-13 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-12 23:25 [PATCH] nfs: Keep index within mnt_errtbl[] Roel Kluin
2009-07-13 12:59 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox