Re: [pnfs] [PATCH 2/5] nfsd: Fix independence of a few nfsd related headers

[Boaz Harrosh <bharrosh@panasas.com>]

On 10/21/2009 10:14 AM, Boaz Harrosh wrote:
> An header should be compilation independent, .i.e pull in
> any header who's declarations are directly used by this header.
> And not let users re-include all it's dependencies all over
> again.
> 
> [At the end of the day what's the use of a header if it does
>  not have more then one user?]
> 
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>

Trond do I have an ACK on this patch.
If not, then what should be changed to get it accepted?

> ---
>  include/linux/nfs_xdr.h   |    1 +

This header is used exclusively by fs/nfs/... files and could just be moved
there. The include must be fixed as below though.

>  include/linux/nfsacl.h    |    1 +

This file is used mixed between fs/nfs && fs/nfsd

>  include/linux/posix_acl.h |    1 +

Used by nfsd and filesystems

>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
> index 2848a26..c316ca8 100644
> --- a/include/linux/nfs_xdr.h
> +++ b/include/linux/nfs_xdr.h
> @@ -2,6 +2,7 @@
>  #define _LINUX_NFS_XDR_H
>  
>  #include <linux/nfsacl.h>
> +#include <linux/nfs3.h>
>  
>  /*
>   * To change the maximum rsize and wsize supported by the NFS client, adjust
> diff --git a/include/linux/nfsacl.h b/include/linux/nfsacl.h
> index 43011b6..f321b57 100644
> --- a/include/linux/nfsacl.h
> +++ b/include/linux/nfsacl.h
> @@ -29,6 +29,7 @@
>  #ifdef __KERNEL__
>  
>  #include <linux/posix_acl.h>
> +#include <linux/sunrpc/xdr.h>
>  
>  /* Maximum number of ACL entries over NFS */
>  #define NFS_ACL_MAX_ENTRIES	1024
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 065a365..0dcf674 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -9,6 +9,7 @@
>  #define __LINUX_POSIX_ACL_H
>  
>  #include <linux/slab.h>
> +#include <linux/fs.h>
>  
>  #define ACL_UNDEFINED_ID	(-1)
>