Re: [PATCH v2 03/35] pnfsd, pnfs: protocol level pnfs constants

[Benny Halevy <bhalevy@panasas.com>]

On Dec. 07, 2009, 21:25 +0200, " J. Bruce Fields" <bfields@citi.umich.edu> wrote:
> On Mon, Dec 07, 2009 at 11:30:24AM +0200, Benny Halevy wrote:

<snip>

>> +
>> +/* FIXME: should recall and return types be combined? */
> 
> Is there any reason not to?

Not really.  In fact on the client side we use almost exclusively
the RECALL_* constants, whether they come from the layoutrecall path
or from a voluntary return path.

Benny

> 
> --b.
> 
>> +enum pnfs_layoutrecall_type {
>> +	RECALL_FILE = 1,
>> +	RECALL_FSID = 2,
>> +	RECALL_ALL  = 3
>> +};
>> +
>> +enum pnfs_layoutreturn_type {
>> +	RETURN_FILE = 1,
>> +	RETURN_FSID = 2,
>> +	RETURN_ALL  = 3
>> +};
>> +