Re: [pnfs] [PATCH 9/9] SQUASHME: pnfs: filelayout: mask out server's MDS capability flag for DSs

[Benny Halevy <bhalevy@panasas.com>]

On Dec. 09, 2009, 12:28 +0200, Benny Halevy <bhalevy@panasas.com> wrote:
> When establishing a session with a DS mask out its MDS
> exchange_id flag so we know we use it as DS-only.
> 
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> ---
>  fs/nfs/nfs4filelayoutdev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/nfs4filelayoutdev.c b/fs/nfs/nfs4filelayoutdev.c
> index 128715a..cb8ae88 100644
> --- a/fs/nfs/nfs4filelayoutdev.c
> +++ b/fs/nfs/nfs4filelayoutdev.c
> @@ -272,6 +272,9 @@ nfs4_pnfs_ds_create(struct nfs_server *mds_srv, struct nfs4_pnfs_ds *ds)
>  	if (err)
>  		goto out_put;
>  
> +	/* mask out the server's MDS capability flag */
> +	clp->cl_exchange_flags |= EXCHGID4_FLAG_USE_PNFS_DS;
> +

Duh, that should be
	clp->cl_exchange_flags &= ~EXCHGID4_FLAG_USE_PNFS_MDS;

Or I'm just utterly tired ;-)

Benny

>  	if (!(clp->cl_exchange_flags & EXCHGID4_FLAG_USE_PNFS_DS)) {
>  		printk(KERN_INFO "ip:port %s is not a pNFS Data Server\n",
>  			ds->r_addr);