Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, bfields@fieldses.org, chuck.lever@oracle.com
Subject: Re: [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet
Date: Tue, 31 Aug 2010 08:24:57 -0400	[thread overview]
Message-ID: <4C7CF499.5090003@RedHat.com> (raw)
In-Reply-To: <20100830134801.1696dffa@tlielax.poochiereds.net>



On 08/30/2010 01:48 PM, Jeff Layton wrote:
> On Mon, 30 Aug 2010 12:53:16 -0400
> Steve Dickson <SteveD@redhat.com> wrote:
>>>
>>> Hmmm...if I had known that it was ok to stop supporting old kernels,
>>> the IPv6 support for rpc.nfsd would have been a heck of a lot easier to
>>> implement.
>> I thought you said the legacy interface would not work with IPV6 or
>> did I misunderstand you? 
>>
> 
> Sorry, forgot to answer this part. IPv6 indeed will not work when using
> the legacy interface. In order to get the IPv6 code in though, I ended
> up rewriting a large swath of rpc.nfsd. That task would have been
> easier had I not needed to deal with the legacy nfsctl() interface.
> 
So I'm thinking this the final nail in the coffin of the legacy interface
at least in rpc.nfsd. So if /proc/fs/nfsd filesystem is not or can not
be mounted then rpc.nfsd should fail... IMHO...

Maybe something like:

if (stat("/proc/fs/nfsd") < 0) {
    if (system("mount /proc/fs/nfsd") < 0) {
        xlog(L_ERROR, "Unable to mount /proc/fs/nfsd");
        exit 0;
    }
}

steved.

  reply	other threads:[~2010-08-31 12:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 11:35 [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet Jeff Layton
2010-08-28 22:29 ` Neil Brown
2010-08-28 22:38 ` Neil Brown
2010-08-29  2:24   ` Jeff Layton
2010-08-29 19:31     ` J. Bruce Fields
2010-08-29 19:37     ` J. Bruce Fields
2010-08-29 22:12       ` Neil Brown
2010-08-30 15:51 ` Steve Dickson
2010-08-30 16:16   ` Jeff Layton
2010-08-30 16:53     ` Steve Dickson
2010-08-30 17:04       ` J. Bruce Fields
2010-08-30 17:22         ` Jeff Layton
2010-08-31 12:14         ` Steve Dickson
2010-08-30 17:48       ` Jeff Layton
2010-08-31 12:24         ` Steve Dickson [this message]
2010-08-31 12:43           ` Jeff Layton
2010-08-31 14:49             ` Steve Dickson
2010-08-31 15:10               ` Jeff Layton
2010-08-31 15:13                 ` J. Bruce Fields
2010-08-31 15:18                   ` Steve Dickson
2010-08-31 15:51                     ` J. Bruce Fields
2010-08-31 16:13                       ` Steve Dickson
2010-08-31 16:15                         ` J. Bruce Fields
2010-08-31 17:18                           ` Steve Dickson
2010-08-31 18:07                             ` J. Bruce Fields
2010-08-31 18:59                               ` Steve Dickson
2010-08-31 19:02                                 ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7CF499.5090003@RedHat.com \
    --to=steved@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox