* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing [not found] ` <201012081830.oB8IUZ4t027387@demeter2.kernel.org> @ 2010-12-08 19:03 ` Trond Myklebust 2010-12-08 20:35 ` Chuck Lever 0 siblings, 1 reply; 7+ messages in thread From: Trond Myklebust @ 2010-12-08 19:03 UTC (permalink / raw) To: bugzilla-daemon Cc: Mr. Charles Edward Lever, linux-nfs, Andrew Morton, stefan.bader On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=24302 > > > Andrew Morton <akpm@linux-foundation.org> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Component|Other |NFS > AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no > |rg | > > > > > --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> 2010-12-08 18:30:32 --- > OK, I reassigned it to NFS. If that was wrong then at least the NFS guys > should be able to help point things in the right direction. <Switching to email interface. Please do not edit the bugzilla entry directly, since that will lose the above Cc information> Chuck, Stefan appears to be hitting a panic in the nfs_umount() call from nfs_walk_authlist(). Can you take a look, please? Cheers Trond ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-08 19:03 ` [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing Trond Myklebust @ 2010-12-08 20:35 ` Chuck Lever 2010-12-09 0:20 ` Chuck Lever 0 siblings, 1 reply; 7+ messages in thread From: Chuck Lever @ 2010-12-08 20:35 UTC (permalink / raw) To: Trond Myklebust; +Cc: bugzilla-daemon, linux-nfs, Andrew Morton, stefan.bader On Dec 8, 2010, at 2:03 PM, Trond Myklebust wrote: > On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org > wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=24302 >> >> >> Andrew Morton <akpm@linux-foundation.org> changed: >> >> What |Removed |Added >> ---------------------------------------------------------------------------- >> Component|Other |NFS >> AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no >> |rg | >> >> >> >> >> --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> 2010-12-08 18:30:32 --- >> OK, I reassigned it to NFS. If that was wrong then at least the NFS guys >> should be able to help point things in the right direction. > > <Switching to email interface. Please do not edit the bugzilla entry > directly, since that will lose the above Cc information> > > > Chuck, > > Stefan appears to be hitting a panic in the nfs_umount() call from > nfs_walk_authlist(). Can you take a look, please? Recv'd. I'll have a look. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-08 20:35 ` Chuck Lever @ 2010-12-09 0:20 ` Chuck Lever 2010-12-09 10:12 ` Stefan Bader 0 siblings, 1 reply; 7+ messages in thread From: Chuck Lever @ 2010-12-09 0:20 UTC (permalink / raw) To: stefan.bader@canonical.com Cc: bugzilla-daemon@bugzilla.kernel.org, Trond Myklebust, Linux NFS Mailing List, Andrew Morton, Chuck Lever [-- Attachment #1: Type: text/html, Size: 3081 bytes --] [-- Attachment #2: diff --] [-- Type: application/octet-stream, Size: 1703 bytes --] commit 0716d40205448c37307c2e497e4e4316fb9917ea Author: Chuck Lever <chuck.lever@oracle.com> Date: Wed Dec 8 19:07:12 2010 -0500 NFS: Fix panic after nfs_umount() After a few unsuccessful NFS mount attempts in which the client and server cannot agree on an authentication flavor both support, the client panics. nfs_umount() is invoked in the kernel in this case. Turns out this particular UMNT RPC invocation causes the RPC client to write off the end of the rpc_clnt's iostat array. This is because the mount client's nrprocs field is initialized with the count of defined procedures (two: MNT and UMNT), rather than the size of the client's proc array (four). The fix is to use the same initialization technique used by most other upper layer clients in the kernel. Introduced by commit 0b524123, which failed to update nrprocs when it added support for UMNT. See also: https://bugzilla.kernel.org/show_bug.cgi?id=24302 Reported-by: Stefan Bader <stefan.bader@canonical.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c index e8d390c..16da457 100644 --- a/fs/nfs/mount_clnt.c +++ b/fs/nfs/mount_clnt.c @@ -492,13 +492,13 @@ static struct rpc_procinfo mnt3_procedures[] = { static struct rpc_version mnt_version1 = { .number = 1, - .nrprocs = 2, + .nrprocs = ARRAY_SIZE(mnt_procedures), .procs = mnt_procedures, }; static struct rpc_version mnt_version3 = { .number = 3, - .nrprocs = 2, + .nrprocs = ARRAY_SIZE(mnt_procedures), .procs = mnt3_procedures, }; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-09 0:20 ` Chuck Lever @ 2010-12-09 10:12 ` Stefan Bader 2010-12-09 15:23 ` Chuck Lever 0 siblings, 1 reply; 7+ messages in thread From: Stefan Bader @ 2010-12-09 10:12 UTC (permalink / raw) To: Chuck Lever; +Cc: Trond Myklebust, Linux NFS Mailing List, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 2029 bytes --] On 12/09/2010 01:19 AM, Chuck Lever wrote: > Hi Stefan- > > On Dec 8, 2010, at 3:35 PM, Chuck Lever wrote: > >> >> On Dec 8, 2010, at 2:03 PM, Trond Myklebust wrote: >> >>> On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org >>> wrote: >>>> https://bugzilla.kernel.org/show_bug.cgi?id=24302 >>>> >>>> >>>> Andrew Morton <akpm@linux-foundation.org> changed: >>>> >>>> What |Removed |Added >>>> ---------------------------------------------------------------------------- >>>> >>>> Component|Other |NFS >>>> AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no |rg >>>> | >>>> >>>> >>>> >>>> >>>> --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> >>>> 2010-12-08 18:30:32 --- OK, I reassigned it to NFS. If that was wrong >>>> then at least the NFS guys should be able to help point things in the >>>> right direction. >>> >>> <Switching to email interface. Please do not edit the bugzilla entry >>> directly, since that will lose the above Cc information> Missed to read the above, so I have to duplicate things a bit, sorry. Removed the bugzilla cc, so the report does not get spammed. >>> >>> >>> Chuck, >>> >>> Stefan appears to be hitting a panic in the nfs_umount() call from >>> nfs_walk_authlist(). Can you take a look, please? >> >> Recv'd. I'll have a look. > > Apologies in advance for the attachment. There are a few other clean ups > that can be done, but this seems to be the minimal fix. Please try this and > let us know if it addresses your panic. > > > > > > > The faulty commit went in a while back, so this patch is probably appropriate > for stable kernels (back to 2.6.31, where this was likely introduced). > I can confirm that this was the root cause of the crash. The sha referenced as the causing commit, got in with a 2.6.32-rc so I added the stable info accordingly. I also added my tested-by and slightly modified the bug reference format (Chuck, I hope this is ok). -Stefan [-- Attachment #2: 0001-NFS-Fix-panic-after-nfs_umount.patch --] [-- Type: text/x-diff, Size: 1825 bytes --] >From dcc0a9d5d9490680ea9faa7b90de3224c3aba7e3 Mon Sep 17 00:00:00 2001 From: Chuck Lever <chuck.lever@oracle.com> Date: Wed, 8 Dec 2010 19:07:12 -0500 Subject: [PATCH] NFS: Fix panic after nfs_umount() After a few unsuccessful NFS mount attempts in which the client and server cannot agree on an authentication flavor both support, the client panics. nfs_umount() is invoked in the kernel in this case. Turns out this particular UMNT RPC invocation causes the RPC client to write off the end of the rpc_clnt's iostat array. This is because the mount client's nrprocs field is initialized with the count of defined procedures (two: MNT and UMNT), rather than the size of the client's proc array (four). The fix is to use the same initialization technique used by most other upper layer clients in the kernel. Introduced by commit 0b524123, which failed to update nrprocs when it added support for UMNT. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=24302 BugLink: http://bugs.launchpad.net/bugs/683938 Reported-by: Stefan Bader <stefan.bader@canonical.com> Tested-by: Stefan Bader <stefan.bader@canonical.com> CC: stable@kernel.org # >= 2.6.32 Signed-off-by: Chuck Lever <chuck.lever@oracle.com> --- fs/nfs/mount_clnt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c index 59047f8..50552c5 100644 --- a/fs/nfs/mount_clnt.c +++ b/fs/nfs/mount_clnt.c @@ -503,13 +503,13 @@ static struct rpc_procinfo mnt3_procedures[] = { static struct rpc_version mnt_version1 = { .number = 1, - .nrprocs = 2, + .nrprocs = ARRAY_SIZE(mnt_procedures), .procs = mnt_procedures, }; static struct rpc_version mnt_version3 = { .number = 3, - .nrprocs = 2, + .nrprocs = ARRAY_SIZE(mnt_procedures), .procs = mnt3_procedures, }; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-09 10:12 ` Stefan Bader @ 2010-12-09 15:23 ` Chuck Lever 2010-12-09 17:25 ` Stefan Bader 0 siblings, 1 reply; 7+ messages in thread From: Chuck Lever @ 2010-12-09 15:23 UTC (permalink / raw) To: Stefan Bader; +Cc: Trond Myklebust, Linux NFS Mailing List, Andrew Morton On Dec 9, 2010, at 5:12 AM, Stefan Bader wrote: > On 12/09/2010 01:19 AM, Chuck Lever wrote: >> Hi Stefan- >> >> On Dec 8, 2010, at 3:35 PM, Chuck Lever wrote: >> >>> >>> On Dec 8, 2010, at 2:03 PM, Trond Myklebust wrote: >>> >>>> On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org >>>> wrote: >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=24302 >>>>> >>>>> >>>>> Andrew Morton <akpm@linux-foundation.org> changed: >>>>> >>>>> What |Removed |Added >>>>> ---------------------------------------------------------------------------- >>>>> >>>>> > Component|Other |NFS >>>>> AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no |rg >>>>> | >>>>> >>>>> >>>>> >>>>> >>>>> --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> >>>>> 2010-12-08 18:30:32 --- OK, I reassigned it to NFS. If that was wrong >>>>> then at least the NFS guys should be able to help point things in the >>>>> right direction. >>>> >>>> <Switching to email interface. Please do not edit the bugzilla entry >>>> directly, since that will lose the above Cc information> > > Missed to read the above, so I have to duplicate things a bit, sorry. Removed > the bugzilla cc, so the report does not get spammed. > >>>> >>>> >>>> Chuck, >>>> >>>> Stefan appears to be hitting a panic in the nfs_umount() call from >>>> nfs_walk_authlist(). Can you take a look, please? >>> >>> Recv'd. I'll have a look. >> >> Apologies in advance for the attachment. There are a few other clean ups >> that can be done, but this seems to be the minimal fix. Please try this and >> let us know if it addresses your panic. >> >> >> >> >> >> >> The faulty commit went in a while back, so this patch is probably appropriate >> for stable kernels (back to 2.6.31, where this was likely introduced). >> > > I can confirm that this was the root cause of the crash. The sha referenced as > the causing commit, got in with a 2.6.32-rc so I added the stable info > accordingly. I also added my tested-by and slightly modified the bug reference > format (Chuck, I hope this is ok). Looks good to me. I assume, since Trond still owns the kernel.org bugzilla, that he will close this loop? Let me know if I need to do anything else. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-09 15:23 ` Chuck Lever @ 2010-12-09 17:25 ` Stefan Bader 2010-12-09 17:27 ` Chuck Lever 0 siblings, 1 reply; 7+ messages in thread From: Stefan Bader @ 2010-12-09 17:25 UTC (permalink / raw) To: Chuck Lever; +Cc: Trond Myklebust, Linux NFS Mailing List, Andrew Morton On 12/09/2010 04:23 PM, Chuck Lever wrote: > > On Dec 9, 2010, at 5:12 AM, Stefan Bader wrote: > >> On 12/09/2010 01:19 AM, Chuck Lever wrote: >>> Hi Stefan- >>> >>> On Dec 8, 2010, at 3:35 PM, Chuck Lever wrote: >>> >>>> >>>> On Dec 8, 2010, at 2:03 PM, Trond Myklebust wrote: >>>> >>>>> On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org >>>>> wrote: >>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=24302 >>>>>> >>>>>> >>>>>> Andrew Morton <akpm@linux-foundation.org> changed: >>>>>> >>>>>> What |Removed |Added >>>>>> ---------------------------------------------------------------------------- >>>>>> >>>>>> >> Component|Other |NFS >>>>>> AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no |rg >>>>>> | >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> >>>>>> 2010-12-08 18:30:32 --- OK, I reassigned it to NFS. If that was wrong >>>>>> then at least the NFS guys should be able to help point things in the >>>>>> right direction. >>>>> >>>>> <Switching to email interface. Please do not edit the bugzilla entry >>>>> directly, since that will lose the above Cc information> >> >> Missed to read the above, so I have to duplicate things a bit, sorry. Removed >> the bugzilla cc, so the report does not get spammed. >> >>>>> >>>>> >>>>> Chuck, >>>>> >>>>> Stefan appears to be hitting a panic in the nfs_umount() call from >>>>> nfs_walk_authlist(). Can you take a look, please? >>>> >>>> Recv'd. I'll have a look. >>> >>> Apologies in advance for the attachment. There are a few other clean ups >>> that can be done, but this seems to be the minimal fix. Please try this and >>> let us know if it addresses your panic. >>> >>> >>> >>> >>> >>> >>> The faulty commit went in a while back, so this patch is probably appropriate >>> for stable kernels (back to 2.6.31, where this was likely introduced). >>> >> >> I can confirm that this was the root cause of the crash. The sha referenced as >> the causing commit, got in with a 2.6.32-rc so I added the stable info >> accordingly. I also added my tested-by and slightly modified the bug reference >> format (Chuck, I hope this is ok). > > Looks good to me. I assume, since Trond still owns the kernel.org bugzilla, that he will close this loop? Let me know if I need to do anything else. > Actually someone spotted that the second array_size should probably use mnt_procedures3 instead of mnt_procedures. They happen to be the same size, so testing is ok. -Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing 2010-12-09 17:25 ` Stefan Bader @ 2010-12-09 17:27 ` Chuck Lever 0 siblings, 0 replies; 7+ messages in thread From: Chuck Lever @ 2010-12-09 17:27 UTC (permalink / raw) To: Stefan Bader; +Cc: Trond Myklebust, Linux NFS Mailing List, Andrew Morton On Dec 9, 2010, at 12:25 PM, Stefan Bader wrote: > On 12/09/2010 04:23 PM, Chuck Lever wrote: >> >> On Dec 9, 2010, at 5:12 AM, Stefan Bader wrote: >> >>> On 12/09/2010 01:19 AM, Chuck Lever wrote: >>>> Hi Stefan- >>>> >>>> On Dec 8, 2010, at 3:35 PM, Chuck Lever wrote: >>>> >>>>> >>>>> On Dec 8, 2010, at 2:03 PM, Trond Myklebust wrote: >>>>> >>>>>> On Wed, 2010-12-08 at 18:30 +0000, bugzilla-daemon@bugzilla.kernel.org >>>>>> wrote: >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=24302 >>>>>>> >>>>>>> >>>>>>> Andrew Morton <akpm@linux-foundation.org> changed: >>>>>>> >>>>>>> What |Removed |Added >>>>>>> ---------------------------------------------------------------------------- >>>>>>> >>>>>>> >>> Component|Other |NFS >>>>>>> AssignedTo|fs_other@kernel-bugs.osdl.o |trond.myklebust@fys.uio.no |rg >>>>>>> | >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> --- Comment #8 from Andrew Morton <akpm@linux-foundation.org> >>>>>>> 2010-12-08 18:30:32 --- OK, I reassigned it to NFS. If that was wrong >>>>>>> then at least the NFS guys should be able to help point things in the >>>>>>> right direction. >>>>>> >>>>>> <Switching to email interface. Please do not edit the bugzilla entry >>>>>> directly, since that will lose the above Cc information> >>> >>> Missed to read the above, so I have to duplicate things a bit, sorry. Removed >>> the bugzilla cc, so the report does not get spammed. >>> >>>>>> >>>>>> >>>>>> Chuck, >>>>>> >>>>>> Stefan appears to be hitting a panic in the nfs_umount() call from >>>>>> nfs_walk_authlist(). Can you take a look, please? >>>>> >>>>> Recv'd. I'll have a look. >>>> >>>> Apologies in advance for the attachment. There are a few other clean ups >>>> that can be done, but this seems to be the minimal fix. Please try this and >>>> let us know if it addresses your panic. >>>> >>>> >>>> >>>> >>>> >>>> >>>> The faulty commit went in a while back, so this patch is probably appropriate >>>> for stable kernels (back to 2.6.31, where this was likely introduced). >>>> >>> >>> I can confirm that this was the root cause of the crash. The sha referenced as >>> the causing commit, got in with a 2.6.32-rc so I added the stable info >>> accordingly. I also added my tested-by and slightly modified the bug reference >>> format (Chuck, I hope this is ok). >> >> Looks good to me. I assume, since Trond still owns the kernel.org bugzilla, that he will close this loop? Let me know if I need to do anything else. >> > Actually someone spotted that the second array_size should probably use > mnt_procedures3 instead of mnt_procedures. They happen to be the same size, > so testing is ok. Oops. Copy-n-paste error, I thought I had fixed that. Good catch. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-12-09 17:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-24302-104@https.bugzilla.kernel.org/>
[not found] ` <201012081830.oB8IUZ4t027387@demeter2.kernel.org>
2010-12-08 19:03 ` [Bug 24302] Kernel crashes when repeatedly trying to mount nfs share that is failing Trond Myklebust
2010-12-08 20:35 ` Chuck Lever
2010-12-09 0:20 ` Chuck Lever
2010-12-09 10:12 ` Stefan Bader
2010-12-09 15:23 ` Chuck Lever
2010-12-09 17:25 ` Stefan Bader
2010-12-09 17:27 ` Chuck Lever
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox