* [PATCH] SQUASHME: Compile warning in pnfs-all-3.1-2011-10-31-1
@ 2011-11-07 18:29 Boaz Harrosh
2011-11-10 6:30 ` Benny Halevy
0 siblings, 1 reply; 2+ messages in thread
From: Boaz Harrosh @ 2011-11-07 18:29 UTC (permalink / raw)
To: Benny Halevy, NFS list
Fix this:
fs/nfsd/nfs4pnfsd.c: In function 'cl_has_file_layout':
fs/nfsd/nfs4pnfsd.c:1093:20: warning: unused variable 'stid' [-Wunused-variable]
Was something forgotten? or It's really not needed any longer?
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/nfsd/nfs4pnfsd.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c
index d2860c9..ca5c18a 100644
--- a/fs/nfsd/nfs4pnfsd.c
+++ b/fs/nfsd/nfs4pnfsd.c
@@ -1090,7 +1090,6 @@ int nfs4_pnfs_return_layout(struct super_block *sb, struct svc_fh *current_fh,
static bool
cl_has_file_layout(struct nfs4_client *clp, struct nfs4_file *fp, stateid_t *lsid)
{
- struct nfs4_stid *stid;
struct nfs4_layout_state *ls;
spin_lock(&layout_lock);
--
1.7.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] SQUASHME: Compile warning in pnfs-all-3.1-2011-10-31-1
2011-11-07 18:29 [PATCH] SQUASHME: Compile warning in pnfs-all-3.1-2011-10-31-1 Boaz Harrosh
@ 2011-11-10 6:30 ` Benny Halevy
0 siblings, 0 replies; 2+ messages in thread
From: Benny Halevy @ 2011-11-10 6:30 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: NFS list
On 2011-11-07 20:29, Boaz Harrosh wrote:
>
> Fix this:
> fs/nfsd/nfs4pnfsd.c: In function 'cl_has_file_layout':
> fs/nfsd/nfs4pnfsd.c:1093:20: warning: unused variable 'stid' [-Wunused-variable]
>
> Was something forgotten? or It's really not needed any longer?
It isn't needed anymore post f2ed73ef28b85cb2abc9da6ca98a03daf4b36d0d
which searches for clientid on the nfs4_file's fi_layout_states list.
Thanks!
Benny
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
> fs/nfsd/nfs4pnfsd.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c
> index d2860c9..ca5c18a 100644
> --- a/fs/nfsd/nfs4pnfsd.c
> +++ b/fs/nfsd/nfs4pnfsd.c
> @@ -1090,7 +1090,6 @@ int nfs4_pnfs_return_layout(struct super_block *sb, struct svc_fh *current_fh,
> static bool
> cl_has_file_layout(struct nfs4_client *clp, struct nfs4_file *fp, stateid_t *lsid)
> {
> - struct nfs4_stid *stid;
> struct nfs4_layout_state *ls;
>
> spin_lock(&layout_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-10 6:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-07 18:29 [PATCH] SQUASHME: Compile warning in pnfs-all-3.1-2011-10-31-1 Boaz Harrosh
2011-11-10 6:30 ` Benny Halevy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox