NFS related randconfig failure on powerpc ('nfs_debug' undeclared)

NFS related randconfig failure on powerpc ('nfs_debug' undeclared)

[Paul Gortmaker]

Just a heads up that linux-next builds found this;

fs/nfs/nfs4xdr.c:3443:27: error: 'nfs_debug' undeclared (first use in
this function)
make[3]: *** [fs/nfs/nfs4xdr.o] Error 1
make[2]: *** [fs/nfs] Error 2
make[1]: *** [fs] Error 2
make: *** [sub-make] Error 2

Full build log at:

http://kisskb.ellerman.id.au/kisskb/buildresult/5871973/

Paul.

Re: NFS related randconfig failure on powerpc ('nfs_debug' undeclared)

[Myklebust, Trond]

T24gV2VkLCAyMDEyLTAzLTE0IGF0IDE5OjI1IC0wNDAwLCBQYXVsIEdvcnRtYWtlciB3cm90ZToN
Cj4gSnVzdCBhIGhlYWRzIHVwIHRoYXQgbGludXgtbmV4dCBidWlsZHMgZm91bmQgdGhpczsNCj4g
DQo+IGZzL25mcy9uZnM0eGRyLmM6MzQ0MzoyNzogZXJyb3I6ICduZnNfZGVidWcnIHVuZGVjbGFy
ZWQgKGZpcnN0IHVzZSBpbg0KPiB0aGlzIGZ1bmN0aW9uKQ0KPiBtYWtlWzNdOiAqKiogW2ZzL25m
cy9uZnM0eGRyLm9dIEVycm9yIDENCj4gbWFrZVsyXTogKioqIFtmcy9uZnNdIEVycm9yIDINCj4g
bWFrZVsxXTogKioqIFtmc10gRXJyb3IgMg0KPiBtYWtlOiAqKiogW3N1Yi1tYWtlXSBFcnJvciAy
DQo+IA0KPiBGdWxsIGJ1aWxkIGxvZyBhdDoNCj4gDQo+IGh0dHA6Ly9raXNza2IuZWxsZXJtYW4u
aWQuYXUva2lzc2tiL2J1aWxkcmVzdWx0LzU4NzE5NzMvDQo+IA0KPiBQYXVsLg0KDQpIaSBQYXVs
LA0KDQpEb2VzIHRoZSBmb2xsb3dpbmcgZml4IHdvcmsgZm9yIHlvdT8NCg0KVGhhbmtzIQ0KICBU
cm9uZA0KODwtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0NCkZyb20gOTVhMTNmN2IzM2JlODdkODVkOGU2NjUyMTI2YTNmNGQ2NGQxNjRkYiBNb24g
U2VwIDE3IDAwOjAwOjAwIDIwMDENCkZyb206IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVi
dXN0QG5ldGFwcC5jb20+DQpEYXRlOiBXZWQsIDE0IE1hciAyMDEyIDIxOjU1OjAxIC0wNDAwDQpT
dWJqZWN0OiBbUEFUQ0hdIE5GUzogRml4IGEgY29tcGlsZSBlcnJvciB3aGVuICFkZWZpbmVkIE5G
U19ERUJVRw0KDQpXZSBzaG91bGQgdXNlIHRoZSAnaWZkZWJ1Zycgd3JhcHBlciByYXRoZXIgdGhh
biB0cnlpbmcgdG8gaW5saW5lDQp0ZXN0cyBvZiBuZnNfZGVidWcsIHNvIHRoYXQgdGhlIGNvZGUg
Y29tcGlsZXMgY29ycmVjdGx5IHdoZW4gd2UNCmRvbid0IGRlZmluZSBORlNfREVCVUcuDQoNClJl
cG9ydGVkLWJ5OiBQYXVsIEdvcnRtYWtlciA8cGF1bC5nb3J0bWFrZXJAd2luZHJpdmVyLmNvbT4N
ClNpZ25lZC1vZmYtYnk6IFRyb25kIE15a2xlYnVzdCA8VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5j
b20+DQotLS0NCiBmcy9uZnMvbmZzNHhkci5jIHwgICAgMiArLQ0KIDEgZmlsZXMgY2hhbmdlZCwg
MSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZnMvbmZzL25m
czR4ZHIuYyBiL2ZzL25mcy9uZnM0eGRyLmMNCmluZGV4IGY3ZTA2NGQuLmM3NGZkYjEgMTAwNjQ0
DQotLS0gYS9mcy9uZnMvbmZzNHhkci5jDQorKysgYi9mcy9uZnMvbmZzNHhkci5jDQpAQCAtMzQ0
MCw3ICszNDQwLDcgQEAgc3RhdGljIGludCBkZWNvZGVfcGF0aG5hbWUoc3RydWN0IHhkcl9zdHJl
YW0gKnhkciwgc3RydWN0IG5mczRfcGF0aG5hbWUgKnBhdGgpDQogCQlzdGF0dXMgPSBkZWNvZGVf
b3BhcXVlX2lubGluZSh4ZHIsICZjb21wb25lbnQtPmxlbiwgJmNvbXBvbmVudC0+ZGF0YSk7DQog
CQlpZiAodW5saWtlbHkoc3RhdHVzICE9IDApKQ0KIAkJCWdvdG8gb3V0X2VpbzsNCi0JCWlmICh1
bmxpa2VseShuZnNfZGVidWcgJiBORlNEQkdfWERSKSkNCisJCWlmZGVidWcgKFhEUikNCiAJCQlw
cl9jb250KCIlcyUuKnMgIiwNCiAJCQkJKHBhdGgtPm5jb21wb25lbnRzICE9IG4gPyAiLyAiIDog
IiIpLA0KIAkJCQljb21wb25lbnQtPmxlbiwgY29tcG9uZW50LT5kYXRhKTsNCi0tIA0KMS43Ljcu
Ng0KDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIN
Cg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K

Re: NFS related randconfig failure on powerpc ('nfs_debug' undeclared)

[Paul Gortmaker]

On 12-03-14 10:24 PM, Myklebust, Trond wrote:
> On Wed, 2012-03-14 at 19:25 -0400, Paul Gortmaker wrote:
>> Just a heads up that linux-next builds found this;
>>
>> fs/nfs/nfs4xdr.c:3443:27: error: 'nfs_debug' undeclared (first use in
>> this function)
>> make[3]: *** [fs/nfs/nfs4xdr.o] Error 1
>> make[2]: *** [fs/nfs] Error 2
>> make[1]: *** [fs] Error 2
>> make: *** [sub-make] Error 2
>>
>> Full build log at:
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/5871973/
>>
>> Paul.
> 
> Hi Paul,
> 
> Does the following fix work for you?

Yes. (compile tested, that is).

Thanks,
Paul.

> 
> Thanks!
>   Trond
> 8<------------------------------------------------------
> From 95a13f7b33be87d85d8e6652126a3f4d64d164db Mon Sep 17 00:00:00 2001
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Wed, 14 Mar 2012 21:55:01 -0400
> Subject: [PATCH] NFS: Fix a compile error when !defined NFS_DEBUG
> 
> We should use the 'ifdebug' wrapper rather than trying to inline
> tests of nfs_debug, so that the code compiles correctly when we
> don't define NFS_DEBUG.
> 
> Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
>  fs/nfs/nfs4xdr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index f7e064d..c74fdb1 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -3440,7 +3440,7 @@ static int decode_pathname(struct xdr_stream *xdr, struct nfs4_pathname *path)
>  		status = decode_opaque_inline(xdr, &component->len, &component->data);
>  		if (unlikely(status != 0))
>  			goto out_eio;
> -		if (unlikely(nfs_debug & NFSDBG_XDR))
> +		ifdebug (XDR)
>  			pr_cont("%s%.*s ",
>  				(path->ncomponents != n ? "/ " : ""),
>  				component->len, component->data);