public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
	Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed
Date: Tue, 07 Jan 2014 12:41:08 +0800	[thread overview]
Message-ID: <52CB8564.6040002@gmail.com> (raw)

If try_module_get failed, xpt_bc_xprt should be set to NULL,
because xprt will be free.

Don't needed using xprt_put to free xprt, because it is always new.

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
 net/sunrpc/xprtsock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 4fcdf74..5ed124f 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2986,10 +2986,10 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args)
 	 */
 	xprt_set_connected(xprt);
 
-
 	if (try_module_get(THIS_MODULE))
 		return xprt;
-	xprt_put(xprt);
+
+	args->bc_xprt->xpt_bc_xprt = NULL;
 	ret = ERR_PTR(-EINVAL);
 out_err:
 	xs_xprt_free(xprt);
-- 
1.8.4.2

             reply	other threads:[~2014-01-07  4:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  4:41 Kinglong Mee [this message]
2014-01-07  5:01 ` [PATCH] SUNRPC: Clear xpt_bc_xprt if xs_setup_bc_tcp failed Trond Myklebust
2014-01-07  5:21   ` Kinglong Mee
2014-01-07  7:26   ` Kinglong Mee
2014-01-09 16:34     ` Dr Fields James Bruce
2014-01-10  2:43       ` Kinglong Mee
2014-01-10  3:22         ` Kinglong Mee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CB8564.6040002@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox