[PATCH] gssd: Make TCP the default protocol for GSSD connections.

[PATCH] gssd: Make TCP the default protocol for GSSD connections.

[Chuck Lever]

No failure case if gssd doesn't recognize the kernel's requested
protocol. Caught with "protocol=rdma" upcall.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Just spit-balling.

 utils/gssd/gssd_proc.c |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
index 1d8e6a7..7569295 100644
--- a/utils/gssd/gssd_proc.c
+++ b/utils/gssd/gssd_proc.c
@@ -890,16 +890,9 @@ create_auth_rpc_client(struct clnt_info *clp,
 	printerr(2, "creating %s client for server %s\n", clp->protocol,
 			clp->servername);
 
-	if ((strcmp(clp->protocol, "tcp")) == 0) {
-		protocol = IPPROTO_TCP;
-	} else if ((strcmp(clp->protocol, "udp")) == 0) {
+	protocol = IPPROTO_TCP;
+	if ((strcmp(clp->protocol, "udp")) == 0)
 		protocol = IPPROTO_UDP;
-	} else {
-		printerr(0, "WARNING: unrecognized protocol, '%s', requested "
-			 "for connection to server %s for user with uid %d\n",
-			 clp->protocol, clp->servername, uid);
-		goto out_fail;
-	}
 
 	switch (addr->sa_family) {
 	case AF_INET:

Re: [PATCH] gssd: Make TCP the default protocol for GSSD connections.

[Steve Dickson]

On 10/28/2015 04:07 PM, Chuck Lever wrote:
> No failure case if gssd doesn't recognize the kernel's requested
> protocol. Caught with "protocol=rdma" upcall.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Committed... 

steved.
> ---
> Just spit-balling.
> 
>  utils/gssd/gssd_proc.c |   11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index 1d8e6a7..7569295 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -890,16 +890,9 @@ create_auth_rpc_client(struct clnt_info *clp,
>  	printerr(2, "creating %s client for server %s\n", clp->protocol,
>  			clp->servername);
>  
> -	if ((strcmp(clp->protocol, "tcp")) == 0) {
> -		protocol = IPPROTO_TCP;
> -	} else if ((strcmp(clp->protocol, "udp")) == 0) {
> +	protocol = IPPROTO_TCP;
> +	if ((strcmp(clp->protocol, "udp")) == 0)
>  		protocol = IPPROTO_UDP;
> -	} else {
> -		printerr(0, "WARNING: unrecognized protocol, '%s', requested "
> -			 "for connection to server %s for user with uid %d\n",
> -			 clp->protocol, clp->servername, uid);
> -		goto out_fail;
> -	}
>  
>  	switch (addr->sa_family) {
>  	case AF_INET:
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>