From: Casey Schaufler <casey@schaufler-ca.com>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
labeled-nfs@linux-nfs.org
Cc: Casey Schaufler <casey@schaufler-ca.com>
Subject: Use of i_security in fs/nfs/inode.c
Date: Tue, 24 Nov 2015 10:00:34 -0800 [thread overview]
Message-ID: <5654A5C2.4050008@schaufler-ca.com> (raw)
There is a check for inode->i_security == NULL in nfs_setsecurity
in fs/nfs/inode.c. What is the intent of this check? Are you looking
for an uninitialized security blob, are you looking to see if there
is an active security module or something else?
Is there any reason that you can see that a call to
security_inode_getsecid()
followed by a check to see if the secid == 0 would not be equivalent?
I understand that the NULL check is faster, but it may not always be
correct.
reply other threads:[~2015-11-24 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5654A5C2.4050008@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=Trond.Myklebust@netapp.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=labeled-nfs@linux-nfs.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox