Linux NFS development
 help / color / mirror / Atom feed
* Use of i_security in fs/nfs/inode.c
@ 2015-11-24 18:00 Casey Schaufler
  0 siblings, 0 replies; only message in thread
From: Casey Schaufler @ 2015-11-24 18:00 UTC (permalink / raw)
  To: David P. Quigley, Trond Myklebust, linux-nfs@vger.kernel.org,
	labeled-nfs
  Cc: Casey Schaufler


There is a check for inode->i_security == NULL in nfs_setsecurity
in fs/nfs/inode.c. What is the intent of this check? Are you looking
for an uninitialized security blob, are you looking to see if there
is an active security module or something else?

Is there any reason that you can see that a call to 
security_inode_getsecid()
followed by a check to see if the secid == 0 would not be equivalent?
I understand that the NULL check is faster, but it may not always be 
correct.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-24 18:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 18:00 Use of i_security in fs/nfs/inode.c Casey Schaufler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox