* [PATCH net-next 05/10] net: fill in MODULE_DESCRIPTION()s for Sun RPC [not found] <20240108181610.2697017-1-leitao@debian.org> @ 2024-01-08 18:16 ` Breno Leitao 2024-01-08 21:49 ` Jeff Layton 0 siblings, 1 reply; 2+ messages in thread From: Breno Leitao @ 2024-01-08 18:16 UTC (permalink / raw) To: davem, edumazet, kuba, pabeni, Trond Myklebust, Anna Schumaker, Chuck Lever, Jeff Layton, Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey Cc: netdev, Simo Sorce, open list:KERNEL NFSD, SUNRPC, AND LOCKD SERVERS, open list W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to Sun RPC modules. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/sunrpc/auth_gss/auth_gss.c | 1 + net/sunrpc/auth_gss/gss_krb5_mech.c | 1 + net/sunrpc/sunrpc_syms.c | 1 + 3 files changed, 3 insertions(+) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 1af71fbb0d80..c7af0220f82f 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -2280,6 +2280,7 @@ static void __exit exit_rpcsec_gss(void) } MODULE_ALIAS("rpc-auth-6"); +MODULE_DESCRIPTION("Sun RPC Kerberos RPCSEC_GSS client authentication"); MODULE_LICENSE("GPL"); module_param_named(expired_cred_retry_delay, gss_expired_cred_retry_delay, diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c index e31cfdf7eadc..64cff717c3d9 100644 --- a/net/sunrpc/auth_gss/gss_krb5_mech.c +++ b/net/sunrpc/auth_gss/gss_krb5_mech.c @@ -650,6 +650,7 @@ static void __exit cleanup_kerberos_module(void) gss_mech_unregister(&gss_kerberos_mech); } +MODULE_DESCRIPTION("Sun RPC Kerberos 5 module"); MODULE_LICENSE("GPL"); module_init(init_kerberos_module); module_exit(cleanup_kerberos_module); diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c index 691c0000e9ea..bab6cab29405 100644 --- a/net/sunrpc/sunrpc_syms.c +++ b/net/sunrpc/sunrpc_syms.c @@ -148,6 +148,7 @@ cleanup_sunrpc(void) #endif rcu_barrier(); /* Wait for completion of call_rcu()'s */ } +MODULE_DESCRIPTION("Sun RPC core"); MODULE_LICENSE("GPL"); fs_initcall(init_sunrpc); /* Ensure we're initialised before nfs */ module_exit(cleanup_sunrpc); -- 2.39.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 05/10] net: fill in MODULE_DESCRIPTION()s for Sun RPC 2024-01-08 18:16 ` [PATCH net-next 05/10] net: fill in MODULE_DESCRIPTION()s for Sun RPC Breno Leitao @ 2024-01-08 21:49 ` Jeff Layton 0 siblings, 0 replies; 2+ messages in thread From: Jeff Layton @ 2024-01-08 21:49 UTC (permalink / raw) To: Breno Leitao, davem, edumazet, kuba, pabeni, Trond Myklebust, Anna Schumaker, Chuck Lever, Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey Cc: netdev, Simo Sorce, open list:KERNEL NFSD, SUNRPC, AND LOCKD SERVERS, open list On Mon, 2024-01-08 at 10:16 -0800, Breno Leitao wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to Sun RPC modules. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > net/sunrpc/auth_gss/auth_gss.c | 1 + > net/sunrpc/auth_gss/gss_krb5_mech.c | 1 + > net/sunrpc/sunrpc_syms.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index 1af71fbb0d80..c7af0220f82f 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -2280,6 +2280,7 @@ static void __exit exit_rpcsec_gss(void) > } > > MODULE_ALIAS("rpc-auth-6"); > +MODULE_DESCRIPTION("Sun RPC Kerberos RPCSEC_GSS client authentication"); > MODULE_LICENSE("GPL"); > module_param_named(expired_cred_retry_delay, > gss_expired_cred_retry_delay, > diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c > index e31cfdf7eadc..64cff717c3d9 100644 > --- a/net/sunrpc/auth_gss/gss_krb5_mech.c > +++ b/net/sunrpc/auth_gss/gss_krb5_mech.c > @@ -650,6 +650,7 @@ static void __exit cleanup_kerberos_module(void) > gss_mech_unregister(&gss_kerberos_mech); > } > > +MODULE_DESCRIPTION("Sun RPC Kerberos 5 module"); > MODULE_LICENSE("GPL"); > module_init(init_kerberos_module); > module_exit(cleanup_kerberos_module); > diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c > index 691c0000e9ea..bab6cab29405 100644 > --- a/net/sunrpc/sunrpc_syms.c > +++ b/net/sunrpc/sunrpc_syms.c > @@ -148,6 +148,7 @@ cleanup_sunrpc(void) > #endif > rcu_barrier(); /* Wait for completion of call_rcu()'s */ > } > +MODULE_DESCRIPTION("Sun RPC core"); > MODULE_LICENSE("GPL"); > fs_initcall(init_sunrpc); /* Ensure we're initialised before nfs */ > module_exit(cleanup_sunrpc); Looks reasonable to me. Reviewed-by: Jeff Layton <jlayton@kernel.org> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-08 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240108181610.2697017-1-leitao@debian.org>
2024-01-08 18:16 ` [PATCH net-next 05/10] net: fill in MODULE_DESCRIPTION()s for Sun RPC Breno Leitao
2024-01-08 21:49 ` Jeff Layton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox