Re: [PATCH nfs-utils v6 0/3] nfsdctl: add a new nfsdctl tool to nfs-utils

[Jeff Layton <jlayton@kernel.org>]

On Thu, 2024-10-17 at 07:40 -0400, Steve Dickson wrote:
> 
> On 7/22/24 1:01 PM, Jeff Layton wrote:
> > Hi Steve,
> > 
> > Here's an squashed version of the nfsdctl patches, that represents
> > the latest changes. Let me know if you run into any other problems,
> > and thanks for helping to test this!
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > Changes in v6:
> > - make the default number of threads 16 in autostart
> > - doc updates
> > 
> > Changes in v5:
> > - add support for pool-mode setting
> > - fix up the handling of nfsd_netlink.h in autoconf
> > - Link to v4: https://lore.kernel.org/r/20240604-nfsdctl-v4-0-a2941f782e4c@kernel.org
> > 
> > Changes in v4:
> > - add ability to specify an array of pool thread counts in nfs.conf
> > - Link to v3: https://lore.kernel.org/r/20240423-nfsdctl-v3-0-9e68181c846d@kernel.org
> > 
> > Changes in v3:
> > - split nfsdctl.h so we can include the UAPI header as-is
> > - squash the patches together that added Lorenzo's version and convert
> >    it to the new interface
> > - adapt to latest version of netlink interface changes
> >    + have THREADS_SET/GET report an array of thread counts (one per pool)
> >    + pass scope in as a string to THREADS_SET instead of using unshare() trick
> > 
> > Changes in v2:
> > - Adapt to latest kernel netlink interface changes (in particular, send
> >    the leastime and gracetime when they are set in the config).
> > - More help text for different subcommands
> > - New nfsdctl(8) manpage
> > - Patch to make systemd preferentially use nfsdctl instead of rpc.nfsd
> > - Link to v1: https://lore.kernel.org/r/20240412-nfsdctl-v1-0-efd6dcebcc04@kernel.org
> > 
> > ---
> > Jeff Layton (3):
> >        nfsdctl: add the nfsdctl utility to nfs-utils
> >        nfsdctl: asciidoc source for the manpage
> >        systemd: use nfsdctl to start and stop the nfs server
> > 
> >   configure.ac                 |   19 +
> >   systemd/nfs-server.service   |    4 +-
> >   utils/Makefile.am            |    4 +
> >   utils/nfsdctl/Makefile.am    |   13 +
> >   utils/nfsdctl/nfsd_netlink.h |   96 +++
> >   utils/nfsdctl/nfsdctl.8      |  304 ++++++++
> >   utils/nfsdctl/nfsdctl.adoc   |  158 +++++
> >   utils/nfsdctl/nfsdctl.c      | 1570 ++++++++++++++++++++++++++++++++++++++++++
> >   utils/nfsdctl/nfsdctl.h      |   93 +++
> >   9 files changed, 2259 insertions(+), 2 deletions(-)
> > ---
> > base-commit: b76dbaa48f7c239accb0c2d1e1d51ddd73f4d6be
> > change-id: 20240412-nfsdctl-fa8bd8430cfd
> > 
> > Best regards,
> Committed... (tag: nfs-utils-2-7-2-rc2)
> 
> Note: These changes need a v6.11 kernel for V3 to
> come up properly
> 

Thanks! To be clear:

The "v3 problem" you're referring to was fixed in mainline by:

    91da337e5d50 nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets

That patch also went into v6.10.5 (as 04c2c4d836ff) as well. Earlier
kernels don't need it since they lack the relevant netlink interfaces
altogether.
-- 
Jeff Layton <jlayton@kernel.org>