public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: "Jianhong.Yin" <yin-jianhong@163.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY
Date: Thu, 29 Nov 2018 14:49:36 -0500	[thread overview]
Message-ID: <77fe8d1f-412e-e3d6-1f93-c0c63cfbec00@RedHat.com> (raw)
In-Reply-To: <20181025045400.24997-1-yin-jianhong@163.com>



On 10/25/18 12:54 AM, Jianhong.Yin wrote:
> EBUSY can happen when mounting a filesystem that
> is already mounted or when the context= are
> different when using the -o sharecache
> 
> so update the error message from to:
> - %mountpoint% is busy or already mounted
> + %mountpoint% is busy or already mounted or sharecache fail
> 
> Signed-off-by: Jianhong Yin <yin-jianhong@163.com>
Committed.... 

steved.

> ---
>  utils/mount/error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/mount/error.c b/utils/mount/error.c
> index c9797fc..dfe5c7d 100644
> --- a/utils/mount/error.c
> +++ b/utils/mount/error.c
> @@ -223,7 +223,7 @@ void mount_error(const char *spec, const char *mount_point, int error)
>  				  progname, mount_point);
>  		break;
>  	case EBUSY:
> -		nfs_error(_("%s: %s is busy or already mounted"),
> +		nfs_error(_("%s: %s is busy or already mounted or sharecache fail"),
>  			progname, mount_point);
>  		break;
>  	case ENOENT:
> -- 2.17.2
> 

      reply	other threads:[~2018-11-29 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  4:54 [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY Jianhong.Yin
2018-11-29 19:49 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77fe8d1f-412e-e3d6-1f93-c0c63cfbec00@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=yin-jianhong@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox