public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY
@ 2018-10-25  4:54 Jianhong.Yin
  2018-11-29 19:49 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Jianhong.Yin @ 2018-10-25  4:54 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs, Jianhong.Yin

EBUSY can happen when mounting a filesystem that
is already mounted or when the context= are
different when using the -o sharecache

so update the error message from to:
- %mountpoint% is busy or already mounted
+ %mountpoint% is busy or already mounted or sharecache fail

Signed-off-by: Jianhong Yin <yin-jianhong@163.com>
---
 utils/mount/error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/mount/error.c b/utils/mount/error.c
index c9797fc..dfe5c7d 100644
--- a/utils/mount/error.c
+++ b/utils/mount/error.c
@@ -223,7 +223,7 @@ void mount_error(const char *spec, const char *mount_point, int error)
 				  progname, mount_point);
 		break;
 	case EBUSY:
-		nfs_error(_("%s: %s is busy or already mounted"),
+		nfs_error(_("%s: %s is busy or already mounted or sharecache fail"),
 			progname, mount_point);
 		break;
 	case ENOENT:
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY
  2018-10-25  4:54 [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY Jianhong.Yin
@ 2018-11-29 19:49 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2018-11-29 19:49 UTC (permalink / raw)
  To: Jianhong.Yin; +Cc: linux-nfs



On 10/25/18 12:54 AM, Jianhong.Yin wrote:
> EBUSY can happen when mounting a filesystem that
> is already mounted or when the context= are
> different when using the -o sharecache
> 
> so update the error message from to:
> - %mountpoint% is busy or already mounted
> + %mountpoint% is busy or already mounted or sharecache fail
> 
> Signed-off-by: Jianhong Yin <yin-jianhong@163.com>
Committed.... 

steved.

> ---
>  utils/mount/error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/mount/error.c b/utils/mount/error.c
> index c9797fc..dfe5c7d 100644
> --- a/utils/mount/error.c
> +++ b/utils/mount/error.c
> @@ -223,7 +223,7 @@ void mount_error(const char *spec, const char *mount_point, int error)
>  				  progname, mount_point);
>  		break;
>  	case EBUSY:
> -		nfs_error(_("%s: %s is busy or already mounted"),
> +		nfs_error(_("%s: %s is busy or already mounted or sharecache fail"),
>  			progname, mount_point);
>  		break;
>  	case ENOENT:
> -- 2.17.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-29 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-25  4:54 [PATCH] [nfs-utils] mount: improve error msg when mount fail wirh EBUSY Jianhong.Yin
2018-11-29 19:49 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox