Re: [PATCH 2/4] NFS: move the delegation_watermark module parameter

[Jeff Layton <jlayton@kernel.org>]

On Mon, 2025-07-14 at 13:16 +0200, Christoph Hellwig wrote:
> Keep the module_param_named next to the variable declaration instead of
> somewhere unrelated, following the best practice in the rest of the
> kernel.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/nfs/delegation.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
> index 56bb2a7e1793..d036796dbe69 100644
> --- a/fs/nfs/delegation.c
> +++ b/fs/nfs/delegation.c
> @@ -29,6 +29,7 @@
>  
>  static atomic_long_t nfs_active_delegations;
>  static unsigned nfs_delegation_watermark = NFS_DEFAULT_DELEGATION_WATERMARK;
> +module_param_named(delegation_watermark, nfs_delegation_watermark, uint, 0644);
>  
>  static void __nfs_free_delegation(struct nfs_delegation *delegation)
>  {
> @@ -1575,5 +1576,3 @@ bool nfs4_delegation_flush_on_close(const struct inode *inode)
>  	rcu_read_unlock();
>  	return ret;
>  }
> -
> -module_param_named(delegation_watermark, nfs_delegation_watermark, uint, 0644);

Sure, but I'd just squash this into patch #3:

Reviewed-by: Jeff Layton <jlayton@kernel.org>