From: NeilBrown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: releasing result pages in svc_xprt_release()
Date: Mon, 08 Feb 2021 10:42:08 +1100 [thread overview]
Message-ID: <874kine97z.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <9FC8FB98-2DD7-4B78-BD72-918F91FA11D9@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Fri, Feb 05 2021, Chuck Lever wrote:
>
> Baby steps.
>
> Because I'm perverse I started with bulk page freeing. In the course
> of trying to invent a new API, I discovered there already is a batch
> free_page() function called release_pages().
>
> It seems to work as advertised for pages that are truly no longer
> in use (ie RPC/RDMA pages) but not for pages that are still in flight
> but released (ie TCP pages).
>
> release_pages() chains the pages in the passed-in array onto a list
> by their page->lru fields. This seems to be a problem if a page
> is still in use.
But if a page is still in use, it is not put on the list.
if (!put_page_testzero(page))
continue;
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
prev parent reply other threads:[~2021-02-07 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:19 releasing result pages in svc_xprt_release() Chuck Lever
2021-01-29 22:43 ` NeilBrown
2021-01-29 23:06 ` Chuck Lever
2021-01-31 23:45 ` NeilBrown
2021-02-01 0:19 ` Chuck Lever
2021-02-01 23:27 ` NeilBrown
2021-02-05 20:20 ` Chuck Lever
2021-02-05 21:13 ` J. Bruce Fields
2021-02-06 17:59 ` Chuck Lever
2021-02-07 23:59 ` NeilBrown
2021-02-07 23:42 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kine97z.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox