Re: [PATCH] SUNRPC: Fixup gss_status tracepoint error output

[Benjamin Coddington <bcodding@redhat.com>]

On 11 Jul 2024, at 11:28, Chuck Lever wrote:

> On Thu, Jul 11, 2024 at 11:24:01AM -0400, Benjamin Coddington wrote:
>> The GSS routine errors are values, not flags.
>
> My reading of kernel and user space GSS code is that these are
> indeed flags and can be combined. The definitions are found in
> include/linux/sunrpc/gss_err.h:
>
> To wit:
>
> 116 /*
> 117  * Routine errors:
> 118  */
> 119 #define GSS_S_BAD_MECH (((OM_uint32) 1ul) << GSS_C_ROUTINE_ERROR_OFFSET)
> 120 #define GSS_S_BAD_NAME (((OM_uint32) 2ul) << GSS_C_ROUTINE_ERROR_OFFSET)

I read this as just values shifted left by a constant.

No where in-kernel are they bitwise combined.  I noticed this problem in practice
while reading the tracepoint output from corrupted GSS hash routines.

Ben