From: Jeff Layton <jlayton@kernel.org>
To: Benjamin Coddington <bcodding@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Fixup gss_status tracepoint error output
Date: Fri, 12 Jul 2024 07:35:32 -0400 [thread overview]
Message-ID: <dc5740f34194e769809d19d8467ac2c10e131fe7.camel@kernel.org> (raw)
In-Reply-To: <27526e921037d6217bdfc6a078c53d37ae9effab.1720711381.git.bcodding@redhat.com>
On Thu, 2024-07-11 at 11:24 -0400, Benjamin Coddington wrote:
> The GSS routine errors are values, not flags.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> include/trace/events/rpcgss.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/rpcgss.h b/include/trace/events/rpcgss.h
> index 7f0c1ceae726..b0b6300a0cab 100644
> --- a/include/trace/events/rpcgss.h
> +++ b/include/trace/events/rpcgss.h
> @@ -54,7 +54,7 @@ TRACE_DEFINE_ENUM(GSS_S_UNSEQ_TOKEN);
> TRACE_DEFINE_ENUM(GSS_S_GAP_TOKEN);
>
> #define show_gss_status(x) \
> - __print_flags(x, "|", \
> + __print_symbolic(x, \
> { GSS_S_BAD_MECH, "GSS_S_BAD_MECH" }, \
> { GSS_S_BAD_NAME, "GSS_S_BAD_NAME" }, \
> { GSS_S_BAD_NAMETYPE, "GSS_S_BAD_NAMETYPE" }, \
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2024-07-12 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 15:24 [PATCH] SUNRPC: Fixup gss_status tracepoint error output Benjamin Coddington
2024-07-11 15:28 ` Chuck Lever
2024-07-11 15:43 ` Chuck Lever III
2024-07-11 15:48 ` Benjamin Coddington
2024-07-11 15:52 ` Chuck Lever III
2024-07-11 16:00 ` Benjamin Coddington
2024-07-11 17:14 ` Chuck Lever III
2024-07-12 11:35 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc5740f34194e769809d19d8467ac2c10e131fe7.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox