From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] pnfs/blocklayout: Don't add zero-length pnfs_block_dev
Date: Tue, 5 Dec 2023 21:44:27 -0800 [thread overview]
Message-ID: <ZXAKOw9Q5EoOqsr4@infradead.org> (raw)
In-Reply-To: <53e2ab90d83d4cdc15f1b48b2eb671ad26f54a6a.1701788600.git.bcodding@redhat.com>
On Tue, Dec 05, 2023 at 10:05:02AM -0500, Benjamin Coddington wrote:
> We noticed a SCSI device that refused to allow READ CAPACITY when the
> device had a PR with exclusive access, registrants only. The result of
> this situation is that the blocklayout driver adds a pnfs_block_dev of zero
> length which always fails the offset_in_map tests. Instead of continuously
> trying to do pNFS for this case, just mark the device as unavailable which
> will allow the client to fallback to the MDS for the duration of
> PNFS_DEVICE_RETRY_TIMEOUT.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2023-12-06 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:05 [PATCH 1/2] blocklayoutdriver: Fix reference leak of pnfs_device_node Benjamin Coddington
2023-12-05 15:05 ` [PATCH 2/2] pnfs/blocklayout: Don't add zero-length pnfs_block_dev Benjamin Coddington
2023-12-06 5:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXAKOw9Q5EoOqsr4@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox