From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [RESEND PATCH] NFSv4: Always ask for type with READDIR
Date: Tue, 5 Dec 2023 21:46:14 -0800 [thread overview]
Message-ID: <ZXAKppunWJ7FTrAS@infradead.org> (raw)
In-Reply-To: <badc4f7fbd63c19a9f50a7c5c17968db16bebf5f.1701788866.git.bcodding@redhat.com>
> - FATTR4_WORD0_RDATTR_ERROR,
> + FATTR4_WORD0_TYPE|FATTR4_WORD0_RDATTR_ERROR,
Missing spaces before and after the |.
> FATTR4_WORD1_MOUNTED_ON_FILEID,
> };
> uint32_t dircount = readdir->count;
> @@ -1612,7 +1612,7 @@ static void encode_readdir(struct xdr_stream *xdr, const struct nfs4_readdir_arg
> unsigned int i;
>
> if (readdir->plus) {
> - attrs[0] |= FATTR4_WORD0_TYPE|FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE|
> + attrs[0] |= FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE|
> FATTR4_WORD0_FSID|FATTR4_WORD0_FILEHANDLE|FATTR4_WORD0_FILEID;
> attrs[1] |= FATTR4_WORD1_MODE|FATTR4_WORD1_NUMLINKS|FATTR4_WORD1_OWNER|
> FATTR4_WORD1_OWNER_GROUP|FATTR4_WORD1_RAWDEV|
Here as well, incuding in the existing code. Please add them and stick
to the 80 character limit to make it somewhat readable (maybe even split
to one flag per line?).
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2023-12-06 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:08 [RESEND PATCH] NFSv4: Always ask for type with READDIR Benjamin Coddington
2023-12-06 5:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXAKppunWJ7FTrAS@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox