* [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation
@ 2024-11-05 5:43 Seiichi Ikarashi (Fujitsu)
2024-11-05 12:30 ` Scott Mayhew
2024-11-11 17:25 ` Steve Dickson
0 siblings, 2 replies; 3+ messages in thread
From: Seiichi Ikarashi (Fujitsu) @ 2024-11-05 5:43 UTC (permalink / raw)
To: 'steved@redhat.com', 'Scott Mayhew'
Cc: 'sorenson@redhat.com',
'linux-nfs@vger.kernel.org'
The problem happens when a v3 mount fails with ETIMEDOUT after
the v4 mount failed with EPROTONOSUPPORT, in mount auto negotiation.
It immediately breaks from the "for" loop in nfsmount_fg()
or nfsmount_child() due to EPROTONOSUPPORT, never doing the expected
retries until timeout.
[auto negotiation case]:
It breaks immediately.
# time mount.nfs -v 192.168.200.59:/exp /mnt
mount.nfs: timeout set for Wed Oct 23 14:21:58 2024
mount.nfs: trying text-based options 'vers=4.2,addr=192.168.200.59,clientaddr=192.168.200.187'
mount.nfs: mount(2): Protocol not supported
mount.nfs: trying text-based options 'vers=4,minorversion=1,addr=192.168.200.59,clientaddr=192.168.200.187'
mount.nfs: mount(2): Protocol not supported
mount.nfs: trying text-based options 'vers=4,addr=192.168.200.59,clientaddr=192.168.200.187'
mount.nfs: mount(2): Protocol not supported
mount.nfs: trying text-based options 'addr=192.168.200.59'
mount.nfs: prog 100003, trying vers=3, prot=6
mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
mount.nfs: prog 100005, trying vers=3, prot=17
mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
mount.nfs: portmap query retrying: RPC: Timed out
mount.nfs: prog 100005, trying vers=3, prot=6
mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
mount.nfs: portmap query failed: RPC: Timed out
mount.nfs: Protocol not supported for 192.168.200.59:/exp on /mnt
real 0m13.027s
user 0m0.002s
sys 0m0.005s
#
[nfsvers=3 case]:
It retries until exceeding timeout as expected.
# time mount.nfs -v -o nfsvers=3 192.168.200.59:/exp /mnt
mount.nfs: timeout set for Wed Oct 23 14:22:23 2024
mount.nfs: trying text-based options 'nfsvers=3,addr=192.168.200.59'
mount.nfs: prog 100003, trying vers=3, prot=6
mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
mount.nfs: prog 100005, trying vers=3, prot=17
mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
mount.nfs: portmap query retrying: RPC: Timed out
mount.nfs: prog 100005, trying vers=3, prot=6
mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
mount.nfs: portmap query failed: RPC: Timed out
(snip)
mount.nfs: prog 100005, trying vers=3, prot=6
mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
mount.nfs: portmap query failed: RPC: Timed out
mount.nfs: Connection timed out for 192.168.200.59:/exp on /mnt
real 2m10.152s
user 0m0.007s
sys 0m0.015s
#
Let's retry in auto negotiation case, too.
Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
---
utils/mount/stropts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index a92c420..103c41f 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -981,7 +981,7 @@ fall_back:
if ((result = nfs_try_mount_v3v2(mi, FALSE)))
return result;
- if (errno != EBUSY && errno != EACCES)
+ if (errno != EBUSY && errno != EACCES && errno != ETIMEDOUT)
errno = olderrno;
return result;
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation
2024-11-05 5:43 [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation Seiichi Ikarashi (Fujitsu)
@ 2024-11-05 12:30 ` Scott Mayhew
2024-11-11 17:25 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Scott Mayhew @ 2024-11-05 12:30 UTC (permalink / raw)
To: Seiichi Ikarashi (Fujitsu)
Cc: 'steved@redhat.com', 'sorenson@redhat.com',
'linux-nfs@vger.kernel.org'
On Tue, 05 Nov 2024, Seiichi Ikarashi (Fujitsu) wrote:
> The problem happens when a v3 mount fails with ETIMEDOUT after
> the v4 mount failed with EPROTONOSUPPORT, in mount auto negotiation.
> It immediately breaks from the "for" loop in nfsmount_fg()
> or nfsmount_child() due to EPROTONOSUPPORT, never doing the expected
> retries until timeout.
>
> [auto negotiation case]:
>
> It breaks immediately.
>
> # time mount.nfs -v 192.168.200.59:/exp /mnt
> mount.nfs: timeout set for Wed Oct 23 14:21:58 2024
> mount.nfs: trying text-based options 'vers=4.2,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'vers=4,minorversion=1,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'vers=4,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'addr=192.168.200.59'
> mount.nfs: prog 100003, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
> mount.nfs: prog 100005, trying vers=3, prot=17
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
> mount.nfs: portmap query retrying: RPC: Timed out
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> mount.nfs: Protocol not supported for 192.168.200.59:/exp on /mnt
>
> real 0m13.027s
> user 0m0.002s
> sys 0m0.005s
> #
>
> [nfsvers=3 case]:
>
> It retries until exceeding timeout as expected.
>
> # time mount.nfs -v -o nfsvers=3 192.168.200.59:/exp /mnt
> mount.nfs: timeout set for Wed Oct 23 14:22:23 2024
> mount.nfs: trying text-based options 'nfsvers=3,addr=192.168.200.59'
> mount.nfs: prog 100003, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
> mount.nfs: prog 100005, trying vers=3, prot=17
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
> mount.nfs: portmap query retrying: RPC: Timed out
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> (snip)
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> mount.nfs: Connection timed out for 192.168.200.59:/exp on /mnt
>
> real 2m10.152s
> user 0m0.007s
> sys 0m0.015s
> #
>
>
> Let's retry in auto negotiation case, too.
>
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
Should probably also have Fixes: a709f25c ("mount: Report correct error in the fall_back cases.")
Reviewed-by: Scott Mayhew <smayhew@redhat.com>
> ---
> utils/mount/stropts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index a92c420..103c41f 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -981,7 +981,7 @@ fall_back:
> if ((result = nfs_try_mount_v3v2(mi, FALSE)))
> return result;
>
> - if (errno != EBUSY && errno != EACCES)
> + if (errno != EBUSY && errno != EACCES && errno != ETIMEDOUT)
> errno = olderrno;
>
> return result;
> --
> 2.43.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation
2024-11-05 5:43 [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation Seiichi Ikarashi (Fujitsu)
2024-11-05 12:30 ` Scott Mayhew
@ 2024-11-11 17:25 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2024-11-11 17:25 UTC (permalink / raw)
To: Seiichi Ikarashi (Fujitsu), 'Scott Mayhew'
Cc: 'sorenson@redhat.com',
'linux-nfs@vger.kernel.org'
On 11/4/24 11:43 PM, Seiichi Ikarashi (Fujitsu) wrote:
> The problem happens when a v3 mount fails with ETIMEDOUT after
> the v4 mount failed with EPROTONOSUPPORT, in mount auto negotiation.
> It immediately breaks from the "for" loop in nfsmount_fg()
> or nfsmount_child() due to EPROTONOSUPPORT, never doing the expected
> retries until timeout.
>
> [auto negotiation case]:
>
> It breaks immediately.
>
> # time mount.nfs -v 192.168.200.59:/exp /mnt
> mount.nfs: timeout set for Wed Oct 23 14:21:58 2024
> mount.nfs: trying text-based options 'vers=4.2,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'vers=4,minorversion=1,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'vers=4,addr=192.168.200.59,clientaddr=192.168.200.187'
> mount.nfs: mount(2): Protocol not supported
> mount.nfs: trying text-based options 'addr=192.168.200.59'
> mount.nfs: prog 100003, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
> mount.nfs: prog 100005, trying vers=3, prot=17
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
> mount.nfs: portmap query retrying: RPC: Timed out
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> mount.nfs: Protocol not supported for 192.168.200.59:/exp on /mnt
>
> real 0m13.027s
> user 0m0.002s
> sys 0m0.005s
> #
>
> [nfsvers=3 case]:
>
> It retries until exceeding timeout as expected.
>
> # time mount.nfs -v -o nfsvers=3 192.168.200.59:/exp /mnt
> mount.nfs: timeout set for Wed Oct 23 14:22:23 2024
> mount.nfs: trying text-based options 'nfsvers=3,addr=192.168.200.59'
> mount.nfs: prog 100003, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100003 vers 3 prot TCP port 2049
> mount.nfs: prog 100005, trying vers=3, prot=17
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot UDP port 20048
> mount.nfs: portmap query retrying: RPC: Timed out
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> (snip)
> mount.nfs: prog 100005, trying vers=3, prot=6
> mount.nfs: trying 192.168.200.59 prog 100005 vers 3 prot TCP port 20048
> mount.nfs: portmap query failed: RPC: Timed out
> mount.nfs: Connection timed out for 192.168.200.59:/exp on /mnt
>
> real 2m10.152s
> user 0m0.007s
> sys 0m0.015s
> #
>
>
> Let's retry in auto negotiation case, too.
>
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
Committed... (tag: nfs-utils-2-8-2-rc1)
steved.
> ---
> utils/mount/stropts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index a92c420..103c41f 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -981,7 +981,7 @@ fall_back:
> if ((result = nfs_try_mount_v3v2(mi, FALSE)))
> return result;
>
> - if (errno != EBUSY && errno != EACCES)
> + if (errno != EBUSY && errno != EACCES && errno != ETIMEDOUT)
> errno = olderrno;
>
> return result;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-11 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 5:43 [PATCH RESEND] mount.nfs: retry NFSv3 mount after NFSv4 failure in auto negotiation Seiichi Ikarashi (Fujitsu)
2024-11-05 12:30 ` Scott Mayhew
2024-11-11 17:25 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox