[nfs-utils][PATCH] support/nfs/xcommon.c: fix a formatting error with clang

[nfs-utils][PATCH] support/nfs/xcommon.c: fix a formatting error with clang

[Alexander Kanavin]

Specifically, this happens:

| xcommon.c:101:24: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
|   101 |      vfprintf (stderr, fmt2, args);
|       |                        ^~~~

A similar approach (print \n seprately) is already used elsewhere in
the same file.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 support/nfs/xcommon.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/support/nfs/xcommon.c b/support/nfs/xcommon.c
index 3989f0bc..1d04dd11 100644
--- a/support/nfs/xcommon.c
+++ b/support/nfs/xcommon.c
@@ -94,13 +94,11 @@ xstrconcat4 (const char *s, const char *t, const char *u, const char *v) {
 void
 nfs_error (const char *fmt, ...) {
      va_list args;
-     char *fmt2;
 
-     fmt2 = xstrconcat2 (fmt, "\n");
      va_start (args, fmt);
-     vfprintf (stderr, fmt2, args);
+     vfprintf (stderr, fmt, args);
+     fprintf (stderr, "\n");
      va_end (args);
-     free (fmt2);
 }
 
 /* Make a canonical pathname from PATH.  Returns a freshly malloced string.
-- 
2.39.5

Re: [nfs-utils][PATCH] support/nfs/xcommon.c: fix a formatting error with clang

[Steve Dickson]

On 3/21/25 7:31 AM, Alexander Kanavin wrote:
> Specifically, this happens:
> 
> | xcommon.c:101:24: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
> |   101 |      vfprintf (stderr, fmt2, args);
> |       |                        ^~~~
> 
> A similar approach (print \n seprately) is already used elsewhere in
> the same file.
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Committed... (tag: nfs-utils-2-8-3-rc8)

steved.
> ---
>   support/nfs/xcommon.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/support/nfs/xcommon.c b/support/nfs/xcommon.c
> index 3989f0bc..1d04dd11 100644
> --- a/support/nfs/xcommon.c
> +++ b/support/nfs/xcommon.c
> @@ -94,13 +94,11 @@ xstrconcat4 (const char *s, const char *t, const char *u, const char *v) {
>   void
>   nfs_error (const char *fmt, ...) {
>        va_list args;
> -     char *fmt2;
>   
> -     fmt2 = xstrconcat2 (fmt, "\n");
>        va_start (args, fmt);
> -     vfprintf (stderr, fmt2, args);
> +     vfprintf (stderr, fmt, args);
> +     fprintf (stderr, "\n");
>        va_end (args);
> -     free (fmt2);
>   }
>   
>   /* Make a canonical pathname from PATH.  Returns a freshly malloced string.