* [PATCH v1 1/7] nfs: make nfs_page pin-aware
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 16:39 ` Anna Schumaker
2026-06-03 5:30 ` [PATCH v1 2/7] nfs: Track number of pinned pages in nfs_page Pranjal Shrivastava
` (6 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Modernizing the NFS Direct I/O path to use iov_iter_extract_pages()
introduces page pinning (GUP) instead of standard page referencing.
To handle this correctly, nfs_page must track whether it holds a
pin or a standard reference.
Introduce a new flag, PG_PINNED, to struct nfs_page. Update the creation
path (nfs_page_create_from_page and nfs_page_create_from_folio) to
accept a pinned bool and set the flag accordingly. If the page is pinned,
we skip the existing reference increment (get_page/folio_get) as the pin
itself acts as a reference.
Update nfs_clear_request() & nfs_direct_release_pages() to use
unpin_user_page() or unpin_user_folio() instead of only refcount
decrement (put_page) when PG_PINNED flag is set. Finally, ensure
subrequests inherit the pinning status from their parent request.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/direct.c | 22 +++++++++++++++-------
fs/nfs/pagelist.c | 36 ++++++++++++++++++++++++++----------
fs/nfs/read.c | 2 +-
fs/nfs/write.c | 2 +-
include/linux/nfs_page.h | 3 +++
5 files changed, 46 insertions(+), 19 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 48d89716193a..80319c5eeed4 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -165,11 +165,17 @@ int nfs_swap_rw(struct kiocb *iocb, struct iov_iter *iter)
return 0;
}
-static void nfs_direct_release_pages(struct page **pages, unsigned int npages)
+static void nfs_direct_release_pages(struct page **pages, unsigned int npages,
+ bool pinned)
{
unsigned int i;
- for (i = 0; i < npages; i++)
- put_page(pages[i]);
+
+ if (pinned) {
+ unpin_user_pages(pages, npages);
+ } else {
+ for (i = 0; i < npages; i++)
+ put_page(pages[i]);
+ }
}
void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
@@ -371,7 +377,8 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
/* XXX do we need to do the eof zeroing found in async_filler? */
req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- pgbase, pos, req_len);
+ false, pgbase, pos,
+ req_len);
if (IS_ERR(req)) {
result = PTR_ERR(req);
break;
@@ -386,7 +393,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
requested_bytes += req_len;
pos += req_len;
}
- nfs_direct_release_pages(pagevec, npages);
+ nfs_direct_release_pages(pagevec, npages, false);
kvfree(pagevec);
if (result < 0)
break;
@@ -899,7 +906,8 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- pgbase, pos, req_len);
+ false, pgbase, pos,
+ req_len);
if (IS_ERR(req)) {
result = PTR_ERR(req);
break;
@@ -942,7 +950,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
desc.pg_error = 0;
defer = true;
}
- nfs_direct_release_pages(pagevec, npages);
+ nfs_direct_release_pages(pagevec, npages, false);
kvfree(pagevec);
if (result < 0)
break;
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 4a87b2fdb2e6..5c5601a27663 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -404,20 +404,26 @@ static struct nfs_page *nfs_page_create(struct nfs_lock_context *l_ctx,
return req;
}
-static void nfs_page_assign_folio(struct nfs_page *req, struct folio *folio)
+static void nfs_page_assign_folio(struct nfs_page *req, struct folio *folio, bool pinned)
{
if (folio != NULL) {
req->wb_folio = folio;
- folio_get(folio);
+ if (pinned)
+ set_bit(PG_PINNED, &req->wb_flags);
+ else
+ folio_get(folio);
set_bit(PG_FOLIO, &req->wb_flags);
}
}
-static void nfs_page_assign_page(struct nfs_page *req, struct page *page)
+static void nfs_page_assign_page(struct nfs_page *req, struct page *page, bool pinned)
{
if (page != NULL) {
req->wb_page = page;
- get_page(page);
+ if (pinned)
+ set_bit(PG_PINNED, &req->wb_flags);
+ else
+ get_page(page);
}
}
@@ -435,6 +441,7 @@ static void nfs_page_assign_page(struct nfs_page *req, struct page *page)
*/
struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
struct page *page,
+ bool pinned,
unsigned int pgbase, loff_t offset,
unsigned int count)
{
@@ -446,7 +453,7 @@ struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
ret = nfs_page_create(l_ctx, pgbase, offset >> PAGE_SHIFT,
offset_in_page(offset), count);
if (!IS_ERR(ret)) {
- nfs_page_assign_page(ret, page);
+ nfs_page_assign_page(ret, page, pinned);
nfs_page_group_init(ret, NULL);
}
nfs_put_lock_context(l_ctx);
@@ -466,6 +473,7 @@ struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
*/
struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
struct folio *folio,
+ bool pinned,
unsigned int offset,
unsigned int count)
{
@@ -476,7 +484,7 @@ struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
return ERR_CAST(l_ctx);
ret = nfs_page_create(l_ctx, offset, folio->index, offset, count);
if (!IS_ERR(ret)) {
- nfs_page_assign_folio(ret, folio);
+ nfs_page_assign_folio(ret, folio, pinned);
nfs_page_group_init(ret, NULL);
}
nfs_put_lock_context(l_ctx);
@@ -498,9 +506,11 @@ nfs_create_subreq(struct nfs_page *req,
offset, count);
if (!IS_ERR(ret)) {
if (folio)
- nfs_page_assign_folio(ret, folio);
+ nfs_page_assign_folio(ret, folio,
+ test_bit(PG_PINNED, &req->wb_flags));
else
- nfs_page_assign_page(ret, page);
+ nfs_page_assign_page(ret, page,
+ test_bit(PG_PINNED, &req->wb_flags));
/* find the last request */
for (last = req->wb_head;
last->wb_this_page != req->wb_head;
@@ -552,11 +562,17 @@ static void nfs_clear_request(struct nfs_page *req)
struct nfs_open_context *ctx;
if (folio != NULL) {
- folio_put(folio);
+ if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
+ unpin_user_folio(folio, 1);
+ else
+ folio_put(folio);
req->wb_folio = NULL;
clear_bit(PG_FOLIO, &req->wb_flags);
} else if (page != NULL) {
- put_page(page);
+ if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
+ unpin_user_page(page);
+ else
+ put_page(page);
req->wb_page = NULL;
}
if (l_ctx != NULL) {
diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index e1fe78d7b8d0..ebfebc47966d 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -301,7 +301,7 @@ int nfs_read_add_folio(struct nfs_pageio_descriptor *pgio,
aligned_len = min_t(unsigned int, ALIGN(len, rsize), fsize);
- new = nfs_page_create_from_folio(ctx, folio, 0, aligned_len);
+ new = nfs_page_create_from_folio(ctx, folio, false, 0, aligned_len);
if (IS_ERR(new)) {
error = PTR_ERR(new);
if (nfs_netfs_folio_unlock(folio))
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 3134bb17f3e3..cf56c07ae2ee 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1086,7 +1086,7 @@ static struct nfs_page *nfs_setup_write_request(struct nfs_open_context *ctx,
req = nfs_try_to_update_request(folio, offset, bytes);
if (req != NULL)
goto out;
- req = nfs_page_create_from_folio(ctx, folio, offset, bytes);
+ req = nfs_page_create_from_folio(ctx, folio, false, offset, bytes);
if (IS_ERR(req))
goto out;
nfs_inode_add_request(req);
diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
index afe1d8f09d89..9ece78f1b788 100644
--- a/include/linux/nfs_page.h
+++ b/include/linux/nfs_page.h
@@ -37,6 +37,7 @@ enum {
PG_REMOVE, /* page group sync bit in write path */
PG_CONTENDED1, /* Is someone waiting for a lock? */
PG_CONTENDED2, /* Is someone waiting for a lock? */
+ PG_PINNED, /* page is pinned by GUP */
};
struct nfs_inode;
@@ -124,11 +125,13 @@ struct nfs_pageio_descriptor {
extern struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
struct page *page,
+ bool pinned,
unsigned int pgbase,
loff_t offset,
unsigned int count);
extern struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
struct folio *folio,
+ bool pinned,
unsigned int offset,
unsigned int count);
extern void nfs_release_request(struct nfs_page *);
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/7] nfs: make nfs_page pin-aware
2026-06-03 5:30 ` [PATCH v1 1/7] nfs: make nfs_page pin-aware Pranjal Shrivastava
@ 2026-06-03 16:39 ` Anna Schumaker
2026-06-04 7:51 ` Pranjal Shrivastava
0 siblings, 1 reply; 13+ messages in thread
From: Anna Schumaker @ 2026-06-03 16:39 UTC (permalink / raw)
To: Pranjal Shrivastava, linux-nfs, linux-kernel
Cc: Trond Myklebust, Christoph Hellwig, Christoph Hellwig,
Shivaji Kant
Hi Pranjal,
On Wed, Jun 3, 2026, at 1:30 AM, Pranjal Shrivastava wrote:
> Modernizing the NFS Direct I/O path to use iov_iter_extract_pages()
> introduces page pinning (GUP) instead of standard page referencing.
> To handle this correctly, nfs_page must track whether it holds a
> pin or a standard reference.
>
> Introduce a new flag, PG_PINNED, to struct nfs_page. Update the creation
> path (nfs_page_create_from_page and nfs_page_create_from_folio) to
> accept a pinned bool and set the flag accordingly. If the page is pinned,
> we skip the existing reference increment (get_page/folio_get) as the pin
> itself acts as a reference.
>
> Update nfs_clear_request() & nfs_direct_release_pages() to use
> unpin_user_page() or unpin_user_folio() instead of only refcount
> decrement (put_page) when PG_PINNED flag is set. Finally, ensure
> subrequests inherit the pinning status from their parent request.
>
> Signed-off-by: Pranjal Shrivastava <praan@google.com>
> ---
> fs/nfs/direct.c | 22 +++++++++++++++-------
> fs/nfs/pagelist.c | 36 ++++++++++++++++++++++++++----------
> fs/nfs/read.c | 2 +-
> fs/nfs/write.c | 2 +-
> include/linux/nfs_page.h | 3 +++
> 5 files changed, 46 insertions(+), 19 deletions(-)
>
> diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> index 48d89716193a..80319c5eeed4 100644
> --- a/fs/nfs/direct.c
> +++ b/fs/nfs/direct.c
> @@ -165,11 +165,17 @@ int nfs_swap_rw(struct kiocb *iocb, struct iov_iter *iter)
> return 0;
> }
>
> -static void nfs_direct_release_pages(struct page **pages, unsigned int npages)
> +static void nfs_direct_release_pages(struct page **pages, unsigned int npages,
> + bool pinned)
> {
> unsigned int i;
> - for (i = 0; i < npages; i++)
> - put_page(pages[i]);
> +
> + if (pinned) {
> + unpin_user_pages(pages, npages);
> + } else {
> + for (i = 0; i < npages; i++)
> + put_page(pages[i]);
> + }
> }
>
> void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
> @@ -371,7 +377,8 @@ static ssize_t
> nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
> unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
> /* XXX do we need to do the eof zeroing found in async_filler? */
> req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
> - pgbase, pos, req_len);
> + false, pgbase, pos,
> + req_len);
> if (IS_ERR(req)) {
> result = PTR_ERR(req);
> break;
> @@ -386,7 +393,7 @@ static ssize_t
> nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
> requested_bytes += req_len;
> pos += req_len;
> }
> - nfs_direct_release_pages(pagevec, npages);
> + nfs_direct_release_pages(pagevec, npages, false);
> kvfree(pagevec);
> if (result < 0)
> break;
> @@ -899,7 +906,8 @@ static ssize_t
> nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
> unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
>
> req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
> - pgbase, pos, req_len);
> + false, pgbase, pos,
> + req_len);
> if (IS_ERR(req)) {
> result = PTR_ERR(req);
> break;
> @@ -942,7 +950,7 @@ static ssize_t
> nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
> desc.pg_error = 0;
> defer = true;
> }
> - nfs_direct_release_pages(pagevec, npages);
> + nfs_direct_release_pages(pagevec, npages, false);
> kvfree(pagevec);
> if (result < 0)
> break;
> diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
> index 4a87b2fdb2e6..5c5601a27663 100644
> --- a/fs/nfs/pagelist.c
> +++ b/fs/nfs/pagelist.c
> @@ -404,20 +404,26 @@ static struct nfs_page *nfs_page_create(struct
> nfs_lock_context *l_ctx,
> return req;
> }
>
> -static void nfs_page_assign_folio(struct nfs_page *req, struct folio
> *folio)
> +static void nfs_page_assign_folio(struct nfs_page *req, struct folio
> *folio, bool pinned)
> {
> if (folio != NULL) {
> req->wb_folio = folio;
> - folio_get(folio);
> + if (pinned)
> + set_bit(PG_PINNED, &req->wb_flags);
> + else
> + folio_get(folio);
> set_bit(PG_FOLIO, &req->wb_flags);
> }
> }
>
> -static void nfs_page_assign_page(struct nfs_page *req, struct page
> *page)
> +static void nfs_page_assign_page(struct nfs_page *req, struct page
> *page, bool pinned)
> {
> if (page != NULL) {
> req->wb_page = page;
> - get_page(page);
> + if (pinned)
> + set_bit(PG_PINNED, &req->wb_flags);
> + else
> + get_page(page);
> }
> }
>
> @@ -435,6 +441,7 @@ static void nfs_page_assign_page(struct nfs_page
> *req, struct page *page)
> */
> struct nfs_page *nfs_page_create_from_page(struct nfs_open_context
> *ctx,
> struct page *page,
> + bool pinned,
Can you add a description for "pinned" to the kernel doc comment right
above this function? I'm seeing:
Warning: fs/nfs/pagelist.c:446 function parameter 'pinned' not described in 'nfs_page_create_from_page'
> unsigned int pgbase, loff_t offset,
> unsigned int count)
> {
> @@ -446,7 +453,7 @@ struct nfs_page *nfs_page_create_from_page(struct
> nfs_open_context *ctx,
> ret = nfs_page_create(l_ctx, pgbase, offset >> PAGE_SHIFT,
> offset_in_page(offset), count);
> if (!IS_ERR(ret)) {
> - nfs_page_assign_page(ret, page);
> + nfs_page_assign_page(ret, page, pinned);
> nfs_page_group_init(ret, NULL);
> }
> nfs_put_lock_context(l_ctx);
> @@ -466,6 +473,7 @@ struct nfs_page *nfs_page_create_from_page(struct
> nfs_open_context *ctx,
> */
> struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context
> *ctx,
> struct folio *folio,
> + bool pinned,
Same here:
Warning: fs/nfs/pagelist.c:478 function parameter 'pinned' not described in 'nfs_page_create_from_folio'
Thanks,
Anna
> unsigned int offset,
> unsigned int count)
> {
> @@ -476,7 +484,7 @@ struct nfs_page *nfs_page_create_from_folio(struct
> nfs_open_context *ctx,
> return ERR_CAST(l_ctx);
> ret = nfs_page_create(l_ctx, offset, folio->index, offset, count);
> if (!IS_ERR(ret)) {
> - nfs_page_assign_folio(ret, folio);
> + nfs_page_assign_folio(ret, folio, pinned);
> nfs_page_group_init(ret, NULL);
> }
> nfs_put_lock_context(l_ctx);
> @@ -498,9 +506,11 @@ nfs_create_subreq(struct nfs_page *req,
> offset, count);
> if (!IS_ERR(ret)) {
> if (folio)
> - nfs_page_assign_folio(ret, folio);
> + nfs_page_assign_folio(ret, folio,
> + test_bit(PG_PINNED, &req->wb_flags));
> else
> - nfs_page_assign_page(ret, page);
> + nfs_page_assign_page(ret, page,
> + test_bit(PG_PINNED, &req->wb_flags));
> /* find the last request */
> for (last = req->wb_head;
> last->wb_this_page != req->wb_head;
> @@ -552,11 +562,17 @@ static void nfs_clear_request(struct nfs_page
> *req)
> struct nfs_open_context *ctx;
>
> if (folio != NULL) {
> - folio_put(folio);
> + if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
> + unpin_user_folio(folio, 1);
> + else
> + folio_put(folio);
> req->wb_folio = NULL;
> clear_bit(PG_FOLIO, &req->wb_flags);
> } else if (page != NULL) {
> - put_page(page);
> + if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
> + unpin_user_page(page);
> + else
> + put_page(page);
> req->wb_page = NULL;
> }
> if (l_ctx != NULL) {
> diff --git a/fs/nfs/read.c b/fs/nfs/read.c
> index e1fe78d7b8d0..ebfebc47966d 100644
> --- a/fs/nfs/read.c
> +++ b/fs/nfs/read.c
> @@ -301,7 +301,7 @@ int nfs_read_add_folio(struct nfs_pageio_descriptor *pgio,
>
> aligned_len = min_t(unsigned int, ALIGN(len, rsize), fsize);
>
> - new = nfs_page_create_from_folio(ctx, folio, 0, aligned_len);
> + new = nfs_page_create_from_folio(ctx, folio, false, 0, aligned_len);
> if (IS_ERR(new)) {
> error = PTR_ERR(new);
> if (nfs_netfs_folio_unlock(folio))
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 3134bb17f3e3..cf56c07ae2ee 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -1086,7 +1086,7 @@ static struct nfs_page
> *nfs_setup_write_request(struct nfs_open_context *ctx,
> req = nfs_try_to_update_request(folio, offset, bytes);
> if (req != NULL)
> goto out;
> - req = nfs_page_create_from_folio(ctx, folio, offset, bytes);
> + req = nfs_page_create_from_folio(ctx, folio, false, offset, bytes);
> if (IS_ERR(req))
> goto out;
> nfs_inode_add_request(req);
> diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
> index afe1d8f09d89..9ece78f1b788 100644
> --- a/include/linux/nfs_page.h
> +++ b/include/linux/nfs_page.h
> @@ -37,6 +37,7 @@ enum {
> PG_REMOVE, /* page group sync bit in write path */
> PG_CONTENDED1, /* Is someone waiting for a lock? */
> PG_CONTENDED2, /* Is someone waiting for a lock? */
> + PG_PINNED, /* page is pinned by GUP */
> };
>
> struct nfs_inode;
> @@ -124,11 +125,13 @@ struct nfs_pageio_descriptor {
>
> extern struct nfs_page *nfs_page_create_from_page(struct
> nfs_open_context *ctx,
> struct page *page,
> + bool pinned,
> unsigned int pgbase,
> loff_t offset,
> unsigned int count);
> extern struct nfs_page *nfs_page_create_from_folio(struct
> nfs_open_context *ctx,
> struct folio *folio,
> + bool pinned,
> unsigned int offset,
> unsigned int count);
> extern void nfs_release_request(struct nfs_page *);
> --
> 2.54.0.1013.g208068f2d8-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/7] nfs: make nfs_page pin-aware
2026-06-03 16:39 ` Anna Schumaker
@ 2026-06-04 7:51 ` Pranjal Shrivastava
0 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-04 7:51 UTC (permalink / raw)
To: Anna Schumaker
Cc: linux-nfs, linux-kernel, Trond Myklebust, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant
On Wed, Jun 03, 2026 at 12:39:47PM -0400, Anna Schumaker wrote:
> Hi Pranjal,
>
> On Wed, Jun 3, 2026, at 1:30 AM, Pranjal Shrivastava wrote:
> > Modernizing the NFS Direct I/O path to use iov_iter_extract_pages()
> > introduces page pinning (GUP) instead of standard page referencing.
> > To handle this correctly, nfs_page must track whether it holds a
> > pin or a standard reference.
> >
> > Introduce a new flag, PG_PINNED, to struct nfs_page. Update the creation
> > path (nfs_page_create_from_page and nfs_page_create_from_folio) to
> > accept a pinned bool and set the flag accordingly. If the page is pinned,
> > we skip the existing reference increment (get_page/folio_get) as the pin
> > itself acts as a reference.
> >
> > Update nfs_clear_request() & nfs_direct_release_pages() to use
> > unpin_user_page() or unpin_user_folio() instead of only refcount
> > decrement (put_page) when PG_PINNED flag is set. Finally, ensure
> > subrequests inherit the pinning status from their parent request.
> >
> > Signed-off-by: Pranjal Shrivastava <praan@google.com>
> > ---
> > fs/nfs/direct.c | 22 +++++++++++++++-------
> > fs/nfs/pagelist.c | 36 ++++++++++++++++++++++++++----------
> > fs/nfs/read.c | 2 +-
> > fs/nfs/write.c | 2 +-
> > include/linux/nfs_page.h | 3 +++
> > 5 files changed, 46 insertions(+), 19 deletions(-)
> >
> > diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> > index 48d89716193a..80319c5eeed4 100644
> > --- a/fs/nfs/direct.c
> > +++ b/fs/nfs/direct.c
Hi Anna,
[...]
> >
> > @@ -435,6 +441,7 @@ static void nfs_page_assign_page(struct nfs_page
> > *req, struct page *page)
> > */
> > struct nfs_page *nfs_page_create_from_page(struct nfs_open_context
> > *ctx,
> > struct page *page,
> > + bool pinned,
>
> Can you add a description for "pinned" to the kernel doc comment right
> above this function? I'm seeing:
>
> Warning: fs/nfs/pagelist.c:446 function parameter 'pinned' not described in 'nfs_page_create_from_page'
Ack. I'll add a description in v2.
>
>
> > unsigned int pgbase, loff_t offset,
> > unsigned int count)
> > {
> > @@ -446,7 +453,7 @@ struct nfs_page *nfs_page_create_from_page(struct
> > nfs_open_context *ctx,
> > ret = nfs_page_create(l_ctx, pgbase, offset >> PAGE_SHIFT,
> > offset_in_page(offset), count);
> > if (!IS_ERR(ret)) {
> > - nfs_page_assign_page(ret, page);
> > + nfs_page_assign_page(ret, page, pinned);
> > nfs_page_group_init(ret, NULL);
> > }
> > nfs_put_lock_context(l_ctx);
> > @@ -466,6 +473,7 @@ struct nfs_page *nfs_page_create_from_page(struct
> > nfs_open_context *ctx,
> > */
> > struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context
> > *ctx,
> > struct folio *folio,
> > + bool pinned,
>
> Same here:
>
> Warning: fs/nfs/pagelist.c:478 function parameter 'pinned' not described in 'nfs_page_create_from_folio'
Ack. I'll add a description in v2.
[...]
Thanks,
Praan
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 2/7] nfs: Track number of pinned pages in nfs_page
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 1/7] nfs: make nfs_page pin-aware Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 3/7] nfs: Introduce nfs_release_request_list helper Pranjal Shrivastava
` (5 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Track the number of pinned pages in nfs_page to handle unpinning
correctly, ensuring that only primary requests perform the final
unpinning operation, preventing subrequests from incorrectly
performing unpinning on behalf of their parent requests.
Add wb_nr_pinned to struct nfs_page to store the count of pinned pages
owned by the request. Update request creation and cleanup helpers to
initialize and use wb_nr_pinned for primary requests. Use the
nfs_page_array_len() helper to calculate the number of pages spanned
by a request's offset and length.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/pagelist.c | 9 +++++++--
include/linux/nfs_page.h | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 5c5601a27663..f59449918be7 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -454,6 +454,8 @@ struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
offset_in_page(offset), count);
if (!IS_ERR(ret)) {
nfs_page_assign_page(ret, page, pinned);
+ if (pinned)
+ ret->wb_nr_pinned = 1;
nfs_page_group_init(ret, NULL);
}
nfs_put_lock_context(l_ctx);
@@ -485,6 +487,9 @@ struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
ret = nfs_page_create(l_ctx, offset, folio->index, offset, count);
if (!IS_ERR(ret)) {
nfs_page_assign_folio(ret, folio, pinned);
+ if (pinned)
+ ret->wb_nr_pinned = nfs_page_array_len(offset_in_page(offset),
+ count);
nfs_page_group_init(ret, NULL);
}
nfs_put_lock_context(l_ctx);
@@ -563,14 +568,14 @@ static void nfs_clear_request(struct nfs_page *req)
if (folio != NULL) {
if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
- unpin_user_folio(folio, 1);
+ unpin_user_folio(folio, req->wb_nr_pinned);
else
folio_put(folio);
req->wb_folio = NULL;
clear_bit(PG_FOLIO, &req->wb_flags);
} else if (page != NULL) {
if (test_and_clear_bit(PG_PINNED, &req->wb_flags))
- unpin_user_page(page);
+ unpin_user_pages(&page, req->wb_nr_pinned);
else
put_page(page);
req->wb_page = NULL;
diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
index 9ece78f1b788..295280fe9571 100644
--- a/include/linux/nfs_page.h
+++ b/include/linux/nfs_page.h
@@ -58,6 +58,7 @@ struct nfs_page {
struct nfs_page *wb_this_page; /* list of reqs for this page */
struct nfs_page *wb_head; /* head pointer for req list */
unsigned short wb_nio; /* Number of I/O attempts */
+ unsigned int wb_nr_pinned; /* Number of pinned pages */
};
struct nfs_pgio_mirror;
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 3/7] nfs: Introduce nfs_release_request_list helper
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 1/7] nfs: make nfs_page pin-aware Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 2/7] nfs: Track number of pinned pages in nfs_page Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 4/7] nfs: migrate direct I/O to iov_iter_extract_pages Pranjal Shrivastava
` (4 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Introduce a centralized helper, nfs_release_request_list, to handle
the bulk release of nfs_page requests from a list.
This serves as a preparatory step for two upcoming improvements:
1. Pin-Aware Cleanup: As we migrate to iov_iter_extract_* API,
requests will hold pins (GUP) instead of standard references. The
helper ensures that the correct unpinning logic gets applied
consistently across all requests in a list.
2. Folio Support: In subsequent patches where nfs_page structures
will cover multi-page folios, this helper provides a clean
infrastructure to unlock these larger units of I/O in bulk during
completion, similat to the pattern in bio_release_pages.
Additionally, refactor nfs_read_sync_pgio_error() to utilize this new
helper.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/direct.c | 8 +-------
fs/nfs/pagelist.c | 18 ++++++++++++++++++
include/linux/nfs_page.h | 4 ++--
3 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 80319c5eeed4..2691eeaaeb8c 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -314,13 +314,7 @@ static void nfs_direct_read_completion(struct nfs_pgio_header *hdr)
static void nfs_read_sync_pgio_error(struct list_head *head, int error)
{
- struct nfs_page *req;
-
- while (!list_empty(head)) {
- req = nfs_list_entry(head->next);
- nfs_list_remove_request(req);
- nfs_release_request(req);
- }
+ nfs_release_request_list(head);
}
static void nfs_direct_pgio_init(struct nfs_pgio_header *hdr)
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index f59449918be7..74ae91151f83 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -620,6 +620,24 @@ void nfs_release_request(struct nfs_page *req)
}
EXPORT_SYMBOL_GPL(nfs_release_request);
+/*
+ * nfs_release_request_list - Release a list of NFS read/write requests
+ * @head: list of requests to release
+ *
+ * Removes each request from the list and drops it's refcount.
+ */
+void nfs_release_request_list(struct list_head *head)
+{
+ struct nfs_page *req;
+
+ while (!list_empty(head)) {
+ req = nfs_list_entry(head->next);
+ nfs_list_remove_request(req);
+ nfs_release_request(req);
+ }
+}
+EXPORT_SYMBOL_GPL(nfs_release_request_list);
+
/*
* nfs_generic_pg_test - determine if requests can be coalesced
* @desc: pointer to descriptor
diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
index 295280fe9571..14eb5de64d2f 100644
--- a/include/linux/nfs_page.h
+++ b/include/linux/nfs_page.h
@@ -135,8 +135,8 @@ extern struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
bool pinned,
unsigned int offset,
unsigned int count);
-extern void nfs_release_request(struct nfs_page *);
-
+extern void nfs_release_request(struct nfs_page *req);
+extern void nfs_release_request_list(struct list_head *head);
extern void nfs_pageio_init(struct nfs_pageio_descriptor *desc,
struct inode *inode,
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 4/7] nfs: migrate direct I/O to iov_iter_extract_pages
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
` (2 preceding siblings ...)
2026-06-03 5:30 ` [PATCH v1 3/7] nfs: Introduce nfs_release_request_list helper Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 5/7] nfs: introduce nfs_direct_extract_pages helper Pranjal Shrivastava
` (3 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Migrate the NFS Direct I/O path away from the legacy
iov_iter_get_pages_alloc2() API to the modern iov_iter_extract_pages API.
The transition aligns NFS with the modern VFS extraction model and serves
as a preparatory step for supporting requirements such as page pinning
via GUP for DMA.
The migration fixes a bug in the Direct I/O loop where pages were being
unpinned immediately after request creation. With the new extraction
model, pins are held until the I/O is complete. Manual release in the
loop is correspondingly updated to only clean up failed pages.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/direct.c | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 2691eeaaeb8c..b6aaa5f80241 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -354,16 +354,17 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
inode_dio_begin(inode);
while (iov_iter_count(iter)) {
- struct page **pagevec;
+ struct page **pagevec = NULL;
size_t bytes;
size_t pgbase;
unsigned npages, i;
+ bool pinned = iov_iter_extract_will_pin(iter);
- result = iov_iter_get_pages_alloc2(iter, &pagevec,
- rsize, &pgbase);
+ result = iov_iter_extract_pages(iter, &pagevec,
+ rsize, ~0U, 0, &pgbase);
if (result < 0)
break;
-
+
bytes = result;
npages = (result + pgbase + PAGE_SIZE - 1) / PAGE_SIZE;
for (i = 0; i < npages; i++) {
@@ -371,7 +372,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
/* XXX do we need to do the eof zeroing found in async_filler? */
req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- false, pgbase, pos,
+ pinned, pgbase, pos,
req_len);
if (IS_ERR(req)) {
result = PTR_ERR(req);
@@ -387,7 +388,8 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
requested_bytes += req_len;
pos += req_len;
}
- nfs_direct_release_pages(pagevec, npages, false);
+ if (i < npages)
+ nfs_direct_release_pages(pagevec + i, npages - i, pinned);
kvfree(pagevec);
if (result < 0)
break;
@@ -883,13 +885,14 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
NFS_I(inode)->write_io += iov_iter_count(iter);
while (iov_iter_count(iter)) {
- struct page **pagevec;
+ struct page **pagevec = NULL;
size_t bytes;
size_t pgbase;
unsigned npages, i;
+ bool pinned = iov_iter_extract_will_pin(iter);
- result = iov_iter_get_pages_alloc2(iter, &pagevec,
- wsize, &pgbase);
+ result = iov_iter_extract_pages(iter, &pagevec,
+ wsize, ~0U, 0, &pgbase);
if (result < 0)
break;
@@ -900,7 +903,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- false, pgbase, pos,
+ pinned, pgbase, pos,
req_len);
if (IS_ERR(req)) {
result = PTR_ERR(req);
@@ -944,7 +947,8 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
desc.pg_error = 0;
defer = true;
}
- nfs_direct_release_pages(pagevec, npages, false);
+ if (i < npages)
+ nfs_direct_release_pages(pagevec + i, npages - i, pinned);
kvfree(pagevec);
if (result < 0)
break;
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 5/7] nfs: introduce nfs_direct_extract_pages helper
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
` (3 preceding siblings ...)
2026-06-03 5:30 ` [PATCH v1 4/7] nfs: migrate direct I/O to iov_iter_extract_pages Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 5:30 ` [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests Pranjal Shrivastava
` (2 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Introduce nfs_direct_extract_pages() in direct.c to centralize page
extraction and request creation for the Direct I/O path. The helper
manages extraction from the iters and builds a list of nfs_page requests
Refactor nfs_direct_read_schedule_iovec() and
nfs_direct_write_schedule_iovec() to utilize the new helper, unifying
the extraction logic on both paths.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/direct.c | 122 +++++++++++++++++++++++-------------------------
1 file changed, 59 insertions(+), 63 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index b6aaa5f80241..59002c150f23 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -178,6 +178,50 @@ static void nfs_direct_release_pages(struct page **pages, unsigned int npages,
}
}
+static ssize_t nfs_direct_extract_pages(struct nfs_direct_req *dreq,
+ struct iov_iter *iter,
+ size_t size, loff_t *pos,
+ struct list_head *list)
+{
+ bool pinned = iov_iter_extract_will_pin(iter);
+ struct page **pagevec = NULL;
+ ssize_t result, bytes = 0;
+ unsigned int npages, i;
+ size_t pgbase;
+
+ result = iov_iter_extract_pages(iter, &pagevec, size, ~0U, 0, &pgbase);
+ if (result <= 0)
+ return result;
+
+ npages = (result + pgbase + PAGE_SIZE - 1) >> PAGE_SHIFT;
+ for (i = 0; i < npages; i++) {
+ struct nfs_page *req;
+ unsigned int req_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
+
+ req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
+ pinned, pgbase, *pos,
+ req_len);
+ if (IS_ERR(req)) {
+ if (!bytes)
+ bytes = PTR_ERR(req);
+ break;
+ }
+
+ list_add_tail(&req->wb_list, list);
+ pgbase = 0;
+ bytes += req_len;
+ *pos += req_len;
+ }
+
+ if (i < npages) {
+ iov_iter_revert(iter, result - bytes);
+ nfs_direct_release_pages(pagevec + i, npages - i, pinned);
+ }
+
+ kvfree(pagevec);
+ return bytes;
+}
+
void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
struct nfs_direct_req *dreq)
{
@@ -346,6 +390,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
ssize_t result = -EINVAL;
size_t requested_bytes = 0;
size_t rsize = max_t(size_t, NFS_SERVER(inode)->rsize, PAGE_SIZE);
+ LIST_HEAD(nfs_page_list);
nfs_pageio_init_read(&desc, dreq->inode, false,
&nfs_direct_read_completion_ops);
@@ -354,43 +399,22 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
inode_dio_begin(inode);
while (iov_iter_count(iter)) {
- struct page **pagevec = NULL;
- size_t bytes;
- size_t pgbase;
- unsigned npages, i;
- bool pinned = iov_iter_extract_will_pin(iter);
-
- result = iov_iter_extract_pages(iter, &pagevec,
- rsize, ~0U, 0, &pgbase);
+ result = nfs_direct_extract_pages(dreq, iter, rsize, &pos, &nfs_page_list);
if (result < 0)
break;
- bytes = result;
- npages = (result + pgbase + PAGE_SIZE - 1) / PAGE_SIZE;
- for (i = 0; i < npages; i++) {
- struct nfs_page *req;
- unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
- /* XXX do we need to do the eof zeroing found in async_filler? */
- req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- pinned, pgbase, pos,
- req_len);
- if (IS_ERR(req)) {
- result = PTR_ERR(req);
- break;
- }
+ requested_bytes += result;
+ while (!list_empty(&nfs_page_list)) {
+ struct nfs_page *req = nfs_list_entry(nfs_page_list.next);
+
+ nfs_list_remove_request(req);
if (!nfs_pageio_add_request(&desc, req)) {
result = desc.pg_error;
nfs_release_request(req);
+ nfs_release_request_list(&nfs_page_list);
break;
}
- pgbase = 0;
- bytes -= req_len;
- requested_bytes += req_len;
- pos += req_len;
}
- if (i < npages)
- nfs_direct_release_pages(pagevec + i, npages - i, pinned);
- kvfree(pagevec);
if (result < 0)
break;
}
@@ -873,6 +897,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
ssize_t result = 0;
size_t requested_bytes = 0;
size_t wsize = max_t(size_t, NFS_SERVER(inode)->wsize, PAGE_SIZE);
+ LIST_HEAD(nfs_page_list);
bool defer = false;
trace_nfs_direct_write_schedule_iovec(dreq);
@@ -885,42 +910,15 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
NFS_I(inode)->write_io += iov_iter_count(iter);
while (iov_iter_count(iter)) {
- struct page **pagevec = NULL;
- size_t bytes;
- size_t pgbase;
- unsigned npages, i;
- bool pinned = iov_iter_extract_will_pin(iter);
-
- result = iov_iter_extract_pages(iter, &pagevec,
- wsize, ~0U, 0, &pgbase);
+ result = nfs_direct_extract_pages(dreq, iter, wsize, &pos, &nfs_page_list);
if (result < 0)
break;
- bytes = result;
- npages = (result + pgbase + PAGE_SIZE - 1) / PAGE_SIZE;
- for (i = 0; i < npages; i++) {
- struct nfs_page *req;
- unsigned int req_len = min_t(size_t, bytes, PAGE_SIZE - pgbase);
-
- req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- pinned, pgbase, pos,
- req_len);
- if (IS_ERR(req)) {
- result = PTR_ERR(req);
- break;
- }
-
- if (desc.pg_error < 0) {
- nfs_free_request(req);
- result = desc.pg_error;
- break;
- }
-
- pgbase = 0;
- bytes -= req_len;
- requested_bytes += req_len;
- pos += req_len;
+ requested_bytes += result;
+ while (!list_empty(&nfs_page_list)) {
+ struct nfs_page *req = nfs_list_entry(nfs_page_list.next);
+ nfs_list_remove_request(req);
if (defer) {
nfs_mark_request_commit(req, NULL, &cinfo, 0);
continue;
@@ -934,6 +932,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
if (desc.pg_error < 0 && desc.pg_error != -EAGAIN) {
result = desc.pg_error;
nfs_unlock_and_release_request(req);
+ nfs_release_request_list(&nfs_page_list);
break;
}
@@ -947,9 +946,6 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
desc.pg_error = 0;
defer = true;
}
- if (i < npages)
- nfs_direct_release_pages(pagevec + i, npages - i, pinned);
- kvfree(pagevec);
if (result < 0)
break;
}
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
` (4 preceding siblings ...)
2026-06-03 5:30 ` [PATCH v1 5/7] nfs: introduce nfs_direct_extract_pages helper Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 19:14 ` Anna Schumaker
2026-06-03 5:30 ` [PATCH v1 7/7] nfs: Cleanup the nfs_page_create_from_page helper Pranjal Shrivastava
2026-06-03 5:33 ` [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
7 siblings, 1 reply; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Optimize nfs_direct_extract_pages() to group contiguous pages from the
same folio into single nfs_page structures. This effectively migrates
NFS Direct I/O from being page-based to being folio-based.
Reduce the number of nfs_page allocations and subsequent iterations
by utilizing nfs_page_create_from_folio() to create aggregated
requests.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/direct.c | 36 +++++++++++++++++++++++++++++-------
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 59002c150f23..93e1af9ec36b 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -194,23 +194,45 @@ static ssize_t nfs_direct_extract_pages(struct nfs_direct_req *dreq,
return result;
npages = (result + pgbase + PAGE_SIZE - 1) >> PAGE_SHIFT;
- for (i = 0; i < npages; i++) {
+ for (i = 0; i < npages; ) {
+ unsigned int chunk_len, folio_offset;
+ unsigned int nr_to_add = 1;
struct nfs_page *req;
- unsigned int req_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
+ struct folio *folio;
- req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
- pinned, pgbase, *pos,
- req_len);
+ folio = page_folio(pagevec[i]);
+ folio_offset = (folio_page_idx(folio, pagevec[i]) << PAGE_SHIFT) + pgbase;
+ chunk_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
+
+ while (i + nr_to_add < npages) {
+ struct page *next_page = pagevec[i + nr_to_add];
+ struct page *prev_page = pagevec[i + nr_to_add - 1];
+
+ if (page_folio(next_page) != folio ||
+ next_page != prev_page + 1)
+ break;
+
+ chunk_len += min_t(size_t, result - bytes - chunk_len, PAGE_SIZE);
+ nr_to_add++;
+ }
+
+ req = nfs_page_create_from_folio(dreq->ctx, folio,
+ pinned, folio_offset,
+ chunk_len);
if (IS_ERR(req)) {
if (!bytes)
bytes = PTR_ERR(req);
break;
}
+ req->wb_index = *pos >> PAGE_SHIFT;
+ req->wb_offset = *pos;
+
list_add_tail(&req->wb_list, list);
pgbase = 0;
- bytes += req_len;
- *pos += req_len;
+ bytes += chunk_len;
+ *pos += chunk_len;
+ i += nr_to_add;
}
if (i < npages) {
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests
2026-06-03 5:30 ` [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests Pranjal Shrivastava
@ 2026-06-03 19:14 ` Anna Schumaker
2026-06-04 7:59 ` Pranjal Shrivastava
0 siblings, 1 reply; 13+ messages in thread
From: Anna Schumaker @ 2026-06-03 19:14 UTC (permalink / raw)
To: Pranjal Shrivastava, linux-nfs, linux-kernel
Cc: Trond Myklebust, Christoph Hellwig, Christoph Hellwig,
Shivaji Kant
Hi Pranjal,
On Wed, Jun 3, 2026, at 1:30 AM, Pranjal Shrivastava wrote:
> Optimize nfs_direct_extract_pages() to group contiguous pages from the
> same folio into single nfs_page structures. This effectively migrates
> NFS Direct I/O from being page-based to being folio-based.
>
> Reduce the number of nfs_page allocations and subsequent iterations
> by utilizing nfs_page_create_from_folio() to create aggregated
> requests.
I am seeing a LOT of failing xfstests after applying this patch (testing
against various NFS versions over TCP with AUTH_SYS):
+-------------+-----------+-------------+-------------+-------------+
| testcase | tcp-sys-3 | tcp-sys-4.0 | tcp-sys-4.1 | tcp-sys-4.2 |
+-------------+-----------+-------------+-------------+-------------+
| generic/091 | failure | failure | failure | failure |
| generic/130 | failure | failure | failure | failure |
| generic/139 | skipped | skipped | skipped | failure |
| generic/143 | skipped | skipped | skipped | failure |
| generic/154 | skipped | skipped | skipped | failure |
| generic/155 | skipped | skipped | skipped | failure |
| generic/183 | skipped | skipped | skipped | failure |
| generic/188 | skipped | skipped | skipped | failure |
| generic/190 | skipped | skipped | skipped | failure |
| generic/196 | skipped | skipped | skipped | failure |
| generic/198 | failure | failure | failure | failure |
| generic/203 | skipped | skipped | skipped | failure |
| generic/214 | skipped | skipped | skipped | failure |
| generic/240 | failure | failure | failure | failure |
| generic/263 | failure | failure | failure | failure |
| generic/287 | skipped | skipped | skipped | failure |
| generic/290 | skipped | skipped | skipped | failure |
| generic/292 | skipped | skipped | skipped | failure |
| generic/330 | skipped | skipped | skipped | failure |
| generic/444 | failure | skipped | skipped | skipped |
| generic/450 | failure | failure | failure | failure |
| generic/451 | failure | failure | failure | failure |
| generic/586 | skipped | skipped | skipped | failure |
| generic/647 | failure | failure | failure | failure |
| generic/708 | failure | failure | failure | failure |
| generic/729 | failure | failure | failure | failure |
| generic/760 | failure | failure | failure | failure |
+-------------+-----------+-------------+-------------+-------------+
I'm curious if you've run xfstests against your changes, and if you
see the same failures?
Thanks,
Anna
>
> Signed-off-by: Pranjal Shrivastava <praan@google.com>
> ---
> fs/nfs/direct.c | 36 +++++++++++++++++++++++++++++-------
> 1 file changed, 29 insertions(+), 7 deletions(-)
>
> diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> index 59002c150f23..93e1af9ec36b 100644
> --- a/fs/nfs/direct.c
> +++ b/fs/nfs/direct.c
> @@ -194,23 +194,45 @@ static ssize_t nfs_direct_extract_pages(struct
> nfs_direct_req *dreq,
> return result;
>
> npages = (result + pgbase + PAGE_SIZE - 1) >> PAGE_SHIFT;
> - for (i = 0; i < npages; i++) {
> + for (i = 0; i < npages; ) {
> + unsigned int chunk_len, folio_offset;
> + unsigned int nr_to_add = 1;
> struct nfs_page *req;
> - unsigned int req_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
> + struct folio *folio;
>
> - req = nfs_page_create_from_page(dreq->ctx, pagevec[i],
> - pinned, pgbase, *pos,
> - req_len);
> + folio = page_folio(pagevec[i]);
> + folio_offset = (folio_page_idx(folio, pagevec[i]) << PAGE_SHIFT) + pgbase;
> + chunk_len = min_t(size_t, result - bytes, PAGE_SIZE - pgbase);
> +
> + while (i + nr_to_add < npages) {
> + struct page *next_page = pagevec[i + nr_to_add];
> + struct page *prev_page = pagevec[i + nr_to_add - 1];
> +
> + if (page_folio(next_page) != folio ||
> + next_page != prev_page + 1)
> + break;
> +
> + chunk_len += min_t(size_t, result - bytes - chunk_len, PAGE_SIZE);
> + nr_to_add++;
> + }
> +
> + req = nfs_page_create_from_folio(dreq->ctx, folio,
> + pinned, folio_offset,
> + chunk_len);
> if (IS_ERR(req)) {
> if (!bytes)
> bytes = PTR_ERR(req);
> break;
> }
>
> + req->wb_index = *pos >> PAGE_SHIFT;
> + req->wb_offset = *pos;
> +
> list_add_tail(&req->wb_list, list);
> pgbase = 0;
> - bytes += req_len;
> - *pos += req_len;
> + bytes += chunk_len;
> + *pos += chunk_len;
> + i += nr_to_add;
> }
>
> if (i < npages) {
> --
> 2.54.0.1013.g208068f2d8-goog
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests
2026-06-03 19:14 ` Anna Schumaker
@ 2026-06-04 7:59 ` Pranjal Shrivastava
0 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-04 7:59 UTC (permalink / raw)
To: Anna Schumaker
Cc: linux-nfs, linux-kernel, Trond Myklebust, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant
On Wed, Jun 03, 2026 at 03:14:35PM -0400, Anna Schumaker wrote:
> Hi Pranjal,
>
> On Wed, Jun 3, 2026, at 1:30 AM, Pranjal Shrivastava wrote:
> > Optimize nfs_direct_extract_pages() to group contiguous pages from the
> > same folio into single nfs_page structures. This effectively migrates
> > NFS Direct I/O from being page-based to being folio-based.
> >
> > Reduce the number of nfs_page allocations and subsequent iterations
> > by utilizing nfs_page_create_from_folio() to create aggregated
> > requests.
>
> I am seeing a LOT of failing xfstests after applying this patch (testing
> against various NFS versions over TCP with AUTH_SYS):
>
> +-------------+-----------+-------------+-------------+-------------+
> | testcase | tcp-sys-3 | tcp-sys-4.0 | tcp-sys-4.1 | tcp-sys-4.2 |
> +-------------+-----------+-------------+-------------+-------------+
> | generic/091 | failure | failure | failure | failure |
> | generic/130 | failure | failure | failure | failure |
> | generic/139 | skipped | skipped | skipped | failure |
> | generic/143 | skipped | skipped | skipped | failure |
> | generic/154 | skipped | skipped | skipped | failure |
> | generic/155 | skipped | skipped | skipped | failure |
> | generic/183 | skipped | skipped | skipped | failure |
> | generic/188 | skipped | skipped | skipped | failure |
> | generic/190 | skipped | skipped | skipped | failure |
> | generic/196 | skipped | skipped | skipped | failure |
> | generic/198 | failure | failure | failure | failure |
> | generic/203 | skipped | skipped | skipped | failure |
> | generic/214 | skipped | skipped | skipped | failure |
> | generic/240 | failure | failure | failure | failure |
> | generic/263 | failure | failure | failure | failure |
> | generic/287 | skipped | skipped | skipped | failure |
> | generic/290 | skipped | skipped | skipped | failure |
> | generic/292 | skipped | skipped | skipped | failure |
> | generic/330 | skipped | skipped | skipped | failure |
> | generic/444 | failure | skipped | skipped | skipped |
> | generic/450 | failure | failure | failure | failure |
> | generic/451 | failure | failure | failure | failure |
> | generic/586 | skipped | skipped | skipped | failure |
> | generic/647 | failure | failure | failure | failure |
> | generic/708 | failure | failure | failure | failure |
> | generic/729 | failure | failure | failure | failure |
> | generic/760 | failure | failure | failure | failure |
> +-------------+-----------+-------------+-------------+-------------+
>
> I'm curious if you've run xfstests against your changes, and if you
> see the same failures?
>
Hi Anna,
I've just run fio and haven't run xfstests (sorry wasn't aware of them)
I suppose it's this one [1] ? I will set up the environment.
Given that generic/091 (fsx) is failing across the board, I suspect there
is an error in the contiguous grouping logic in Patch 6, likely the
offset calculation or handles partial page boundaries.
I'll run xfstest with this patch and confirm.
Would you suggest breaking out the move to folio in a separate series if
patches 1-5 work fine?
> Thanks,
> Anna
>
[...]
Thanks,
Praan
[1] https://wiki.linux-nfs.org/wiki/index.php/Xfstests
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 7/7] nfs: Cleanup the nfs_page_create_from_page helper
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
` (5 preceding siblings ...)
2026-06-03 5:30 ` [PATCH v1 6/7] nfs: Optimize direct I/O to use folios for requests Pranjal Shrivastava
@ 2026-06-03 5:30 ` Pranjal Shrivastava
2026-06-03 5:33 ` [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:30 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant, Pranjal Shrivastava
Remove the nfs_page_create_from_page() helper and its public export.
Following the migration of the Direct I/O path to folios, this
function no longer has any callers in the NFS client.
Signed-off-by: Pranjal Shrivastava <praan@google.com>
---
fs/nfs/pagelist.c | 35 -----------------------------------
include/linux/nfs_page.h | 6 ------
2 files changed, 41 deletions(-)
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 74ae91151f83..be8e4ef998ac 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -427,41 +427,6 @@ static void nfs_page_assign_page(struct nfs_page *req, struct page *page, bool p
}
}
-/**
- * nfs_page_create_from_page - Create an NFS read/write request.
- * @ctx: open context to use
- * @page: page to write
- * @pgbase: starting offset within the page for the write
- * @offset: file offset for the write
- * @count: number of bytes to read/write
- *
- * The page must be locked by the caller. This makes sure we never
- * create two different requests for the same page.
- * User should ensure it is safe to sleep in this function.
- */
-struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
- struct page *page,
- bool pinned,
- unsigned int pgbase, loff_t offset,
- unsigned int count)
-{
- struct nfs_lock_context *l_ctx = nfs_get_lock_context(ctx);
- struct nfs_page *ret;
-
- if (IS_ERR(l_ctx))
- return ERR_CAST(l_ctx);
- ret = nfs_page_create(l_ctx, pgbase, offset >> PAGE_SHIFT,
- offset_in_page(offset), count);
- if (!IS_ERR(ret)) {
- nfs_page_assign_page(ret, page, pinned);
- if (pinned)
- ret->wb_nr_pinned = 1;
- nfs_page_group_init(ret, NULL);
- }
- nfs_put_lock_context(l_ctx);
- return ret;
-}
-
/**
* nfs_page_create_from_folio - Create an NFS read/write request.
* @ctx: open context to use
diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
index 14eb5de64d2f..2a3e066cbeb9 100644
--- a/include/linux/nfs_page.h
+++ b/include/linux/nfs_page.h
@@ -124,12 +124,6 @@ struct nfs_pageio_descriptor {
/* arbitrarily selected limit to number of mirrors */
#define NFS_PAGEIO_DESCRIPTOR_MIRROR_MAX 16
-extern struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
- struct page *page,
- bool pinned,
- unsigned int pgbase,
- loff_t offset,
- unsigned int count);
extern struct nfs_page *nfs_page_create_from_folio(struct nfs_open_context *ctx,
struct folio *folio,
bool pinned,
--
2.54.0.1013.g208068f2d8-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 0/7] nfs: Modernize Direct I/O path
2026-06-03 5:30 [PATCH v1 0/7] nfs: Modernize Direct I/O path Pranjal Shrivastava
` (6 preceding siblings ...)
2026-06-03 5:30 ` [PATCH v1 7/7] nfs: Cleanup the nfs_page_create_from_page helper Pranjal Shrivastava
@ 2026-06-03 5:33 ` Pranjal Shrivastava
7 siblings, 0 replies; 13+ messages in thread
From: Pranjal Shrivastava @ 2026-06-03 5:33 UTC (permalink / raw)
To: linux-nfs, linux-kernel
Cc: Trond Myklebust, Anna Schumaker, Christoph Hellwig,
Christoph Hellwig, Shivaji Kant
On Wed, Jun 03, 2026 at 05:30:26AM +0000, Pranjal Shrivastava wrote:
> Modernize the NFS Direct I/O path as a preparatory step to enable PCI
> Peer-to-Peer DMA (P2PDMA) support. Following feedback on the initial
> RFC [1], the modernization and architectural changes are split into
> this standalone series.
>
My bad, I missed appending the link for the RFC. Here's the link:
[1] https://lore.kernel.org/all/20260401194501.2269200-1-praan@google.com/
Thanks,
Praan
^ permalink raw reply [flat|nested] 13+ messages in thread