Linux NFS development
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: andros@netapp.com
Cc: anna.schumaker@netapp.com, bfieldses.org@netapp.com,
	linux-nfs@vger.kernel.org, kbuild-all@01.org
Subject: [PATCH] fix odd_ptr_err.cocci warnings (fwd)
Date: Fri, 23 Dec 2016 20:27:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1612232025300.2012@hadrien> (raw)

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Andy Adamson <andros@netapp.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

I haven't looked at the context in detail, but the change looks plausible.

url:
https://github.com/0day-ci/linux/commits/andros-netapp-com/RFC-RPCSEC_GSS-Version-3-prototype-Full-Mode-MAC/20161224-014029
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

 auth_gss.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -1939,7 +1939,7 @@ gss3_create_label(struct rpc_cred *cred)

 	g3a = gss3_alloc_init_assertion(&cres);
 	if (IS_ERR(g3a)) {
-		ret = PTR_ERR(task);
+		ret = PTR_ERR(g3a);
 		goto out_free_assert;
 	}
 	gss3_insert_assertion(&ctx->gc_alist, g3a);

                 reply	other threads:[~2016-12-23 19:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1612232025300.2012@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=andros@netapp.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfieldses.org@netapp.com \
    --cc=kbuild-all@01.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox