Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] fix odd_ptr_err.cocci warnings (fwd)
@ 2016-12-23 19:27 Julia Lawall
  0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2016-12-23 19:27 UTC (permalink / raw)
  To: andros; +Cc: anna.schumaker, bfieldses.org, linux-nfs, kbuild-all

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Andy Adamson <andros@netapp.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

I haven't looked at the context in detail, but the change looks plausible.

url:
https://github.com/0day-ci/linux/commits/andros-netapp-com/RFC-RPCSEC_GSS-Version-3-prototype-Full-Mode-MAC/20161224-014029
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

 auth_gss.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sunrpc/auth_gss/auth_gss.c
+++ b/net/sunrpc/auth_gss/auth_gss.c
@@ -1939,7 +1939,7 @@ gss3_create_label(struct rpc_cred *cred)

 	g3a = gss3_alloc_init_assertion(&cres);
 	if (IS_ERR(g3a)) {
-		ret = PTR_ERR(task);
+		ret = PTR_ERR(g3a);
 		goto out_free_assert;
 	}
 	gss3_insert_assertion(&ctx->gc_alist, g3a);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-12-23 19:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-23 19:27 [PATCH] fix odd_ptr_err.cocci warnings (fwd) Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox