From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1 1/5] NFSD: Remove definition for trace_nfsd_file_unhash_and_queue
Date: Fri, 13 Jun 2025 16:59:27 -0400 [thread overview]
Message-ID: <b8d0351930b9327cb8240f269e4b1272c07816b4.camel@kernel.org> (raw)
In-Reply-To: <20250613200747.7110-1-cel@kernel.org>
On Fri, 2025-06-13 at 16:07 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> trace_nfsd_file_unhash_and_queue() was removed by commit ac3a2585f01
> ("nfsd: rework refcounting in filecache").
>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/trace.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index b244c6b3e905..93875c7ba358 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -1108,7 +1108,6 @@ DEFINE_NFSD_FILE_EVENT(nfsd_file_free);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_unhash);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_put);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_closing);
> -DEFINE_NFSD_FILE_EVENT(nfsd_file_unhash_and_queue);
>
> TRACE_EVENT(nfsd_file_alloc,
> TP_PROTO(
You can add this to all 5:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2025-06-13 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 20:07 [PATCH v1 1/5] NFSD: Remove definition for trace_nfsd_file_unhash_and_queue Chuck Lever
2025-06-13 20:07 ` [PATCH v1 2/5] NFSD: Remove definitions for unused trace_nfsd_file_lru trace points Chuck Lever
2025-06-13 20:07 ` [PATCH v1 3/5] NFSD: Remove definition for trace_nfsd_file_gc_recent Chuck Lever
2025-06-13 20:07 ` [PATCH v1 4/5] NFSD: Remove definition for trace_nfsd_ctl_maxconn Chuck Lever
2025-06-13 20:07 ` [PATCH v1 5/5] NFSD: Clean up kdoc for nfsd_file_put_local() Chuck Lever
2025-06-13 20:59 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d0351930b9327cb8240f269e4b1272c07816b4.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox