Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Fixed a regression in the junction code
Date: Thu, 10 Aug 2023 12:02:41 -0400	[thread overview]
Message-ID: <c1cc7fc4-1375-d6f1-997f-386580756cd5@redhat.com> (raw)
In-Reply-To: <20230809130018.184633-1-steved@redhat.com>



On 8/9/23 9:00 AM, Steve Dickson wrote:
> commit cdbef4e9 created a regression in the
> in the junction code by adding a O_PATH flag
> to the open() in junction_open_path()
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.
> ---
>   support/junction/junction.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/junction/junction.c b/support/junction/junction.c
> index 0628bb0f..c1ec8ff8 100644
> --- a/support/junction/junction.c
> +++ b/support/junction/junction.c
> @@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
>   	if (pathname == NULL || fd == NULL)
>   		return FEDFS_ERR_INVAL;
>   
> -	tmp = open(pathname, O_PATH|O_DIRECTORY);
> +	tmp = open(pathname, O_DIRECTORY);
>   	if (tmp == -1) {
>   		switch (errno) {
>   		case EPERM:


      reply	other threads:[~2023-08-10 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 13:00 [PATCH] Fixed a regression in the junction code Steve Dickson
2023-08-10 16:02 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1cc7fc4-1375-d6f1-997f-386580756cd5@redhat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox