Linux NFS development
 help / color / mirror / Atom feed
* [PATCH] Fixed a regression in the junction code
@ 2023-08-09 13:00 Steve Dickson
  2023-08-10 16:02 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Dickson @ 2023-08-09 13:00 UTC (permalink / raw)
  To: Linux NFS Mailing list

commit cdbef4e9 created a regression in the
in the junction code by adding a O_PATH flag
to the open() in junction_open_path()

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
Signed-off-by: Steve Dickson <steved@redhat.com>
---
 support/junction/junction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/junction/junction.c b/support/junction/junction.c
index 0628bb0f..c1ec8ff8 100644
--- a/support/junction/junction.c
+++ b/support/junction/junction.c
@@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
 	if (pathname == NULL || fd == NULL)
 		return FEDFS_ERR_INVAL;
 
-	tmp = open(pathname, O_PATH|O_DIRECTORY);
+	tmp = open(pathname, O_DIRECTORY);
 	if (tmp == -1) {
 		switch (errno) {
 		case EPERM:
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fixed a regression in the junction code
  2023-08-09 13:00 [PATCH] Fixed a regression in the junction code Steve Dickson
@ 2023-08-10 16:02 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2023-08-10 16:02 UTC (permalink / raw)
  To: Linux NFS Mailing list



On 8/9/23 9:00 AM, Steve Dickson wrote:
> commit cdbef4e9 created a regression in the
> in the junction code by adding a O_PATH flag
> to the open() in junction_open_path()
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.
> ---
>   support/junction/junction.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/junction/junction.c b/support/junction/junction.c
> index 0628bb0f..c1ec8ff8 100644
> --- a/support/junction/junction.c
> +++ b/support/junction/junction.c
> @@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
>   	if (pathname == NULL || fd == NULL)
>   		return FEDFS_ERR_INVAL;
>   
> -	tmp = open(pathname, O_PATH|O_DIRECTORY);
> +	tmp = open(pathname, O_DIRECTORY);
>   	if (tmp == -1) {
>   		switch (errno) {
>   		case EPERM:


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-10 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09 13:00 [PATCH] Fixed a regression in the junction code Steve Dickson
2023-08-10 16:02 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox