* [PATCH 0/2] Two nfsd referral xdr encoding bugs
@ 2014-12-07 21:05 Benjamin Coddington
2014-12-07 21:05 ` [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char Benjamin Coddington
2014-12-07 21:05 ` [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4 Benjamin Coddington
0 siblings, 2 replies; 6+ messages in thread
From: Benjamin Coddington @ 2014-12-07 21:05 UTC (permalink / raw)
To: linux-nfs
Found a couple of xdr encoding problems in fs_location for referrals. These
should fix up:
https://bugzilla.redhat.com/show_bug.cgi?id=1164055
nfs referral mount fail with "mount(2): Input/output error"
Benjamin Coddington (2):
nfsd4: fix xdr4 inclusion of escaped char
nfsd4: fix xdr4 count of server in fs_location4
fs/nfsd/nfs4xdr.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char
2014-12-07 21:05 [PATCH 0/2] Two nfsd referral xdr encoding bugs Benjamin Coddington
@ 2014-12-07 21:05 ` Benjamin Coddington
2014-12-09 19:24 ` J. Bruce Fields
2014-12-07 21:05 ` [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4 Benjamin Coddington
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Coddington @ 2014-12-07 21:05 UTC (permalink / raw)
To: linux-nfs
Fix a bug where nfsd4_encode_components_esc() includes the esc_end char as
an additional string encoding.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
fs/nfsd/nfs4xdr.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index eeea7a9..6c92a53 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1795,6 +1795,9 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
}
else
end++;
+ if (found_esc)
+ end = next;
+
str = end;
}
pathlen = htonl(xdr->buf->len - pathlen_offset);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4
2014-12-07 21:05 [PATCH 0/2] Two nfsd referral xdr encoding bugs Benjamin Coddington
2014-12-07 21:05 ` [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char Benjamin Coddington
@ 2014-12-07 21:05 ` Benjamin Coddington
2014-12-09 17:37 ` J. Bruce Fields
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Coddington @ 2014-12-07 21:05 UTC (permalink / raw)
To: linux-nfs
Fix a bug where nfsd4_encode_components_esc() incorrectly calculates the
length of server array in fs_location4.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 6c92a53..2a77603 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1800,7 +1800,7 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
str = end;
}
- pathlen = htonl(xdr->buf->len - pathlen_offset);
+ pathlen = htonl(count);
write_bytes_to_xdr_buf(xdr->buf, pathlen_offset, &pathlen, 4);
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4
2014-12-07 21:05 ` [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4 Benjamin Coddington
@ 2014-12-09 17:37 ` J. Bruce Fields
0 siblings, 0 replies; 6+ messages in thread
From: J. Bruce Fields @ 2014-12-09 17:37 UTC (permalink / raw)
To: Benjamin Coddington; +Cc: linux-nfs
On Sun, Dec 07, 2014 at 04:05:48PM -0500, Benjamin Coddington wrote:
> Fix a bug where nfsd4_encode_components_esc() incorrectly calculates the
> length of server array in fs_location4.
Thanks, applying as follows.
This is something I don't test regularly but should.
--b.
commit 3e376626896b
Author: Benjamin Coddington <bcodding@redhat.com>
Date: Sun Dec 7 16:05:48 2014 -0500
nfsd4: fix xdr4 count of server in fs_location4
Fix a bug where nfsd4_encode_components_esc() incorrectly calculates the
length of server array in fs_location4--note that it is a count of the
number of array elements, not a length in bytes.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: 082d4bd72a45 (nfsd4: "backfill" using write_bytes_to_xdr_buf)
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index a8549f8fef57..e578c87d5527 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1817,7 +1817,7 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
str = end;
}
- pathlen = htonl(xdr->buf->len - pathlen_offset);
+ pathlen = htonl(count);
write_bytes_to_xdr_buf(xdr->buf, pathlen_offset, &pathlen, 4);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char
2014-12-07 21:05 ` [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char Benjamin Coddington
@ 2014-12-09 19:24 ` J. Bruce Fields
2014-12-09 19:57 ` Benjamin Coddington
0 siblings, 1 reply; 6+ messages in thread
From: J. Bruce Fields @ 2014-12-09 19:24 UTC (permalink / raw)
To: Benjamin Coddington; +Cc: linux-nfs, dros
On Sun, Dec 07, 2014 at 04:05:47PM -0500, Benjamin Coddington wrote:
> Fix a bug where nfsd4_encode_components_esc() includes the esc_end char as
> an additional string encoding.
Has it had this problem since the escaping was added by e7a0444aef4a
"mfsd" add addr escaping to fs_location hosts"? I wonder why it wasn't
noticed then. Maybe the client always just chooses the first entry and
doesn't care if there's a second entry for a host named "]".
--b.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> fs/nfsd/nfs4xdr.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index eeea7a9..6c92a53 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1795,6 +1795,9 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
> }
> else
> end++;
> + if (found_esc)
> + end = next;
> +
> str = end;
> }
> pathlen = htonl(xdr->buf->len - pathlen_offset);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char
2014-12-09 19:24 ` J. Bruce Fields
@ 2014-12-09 19:57 ` Benjamin Coddington
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Coddington @ 2014-12-09 19:57 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-nfs, dros
On Tue, 9 Dec 2014, J. Bruce Fields wrote:
> On Sun, Dec 07, 2014 at 04:05:47PM -0500, Benjamin Coddington wrote:
> > Fix a bug where nfsd4_encode_components_esc() includes the esc_end char as
> > an additional string encoding.
>
> Has it had this problem since the escaping was added by e7a0444aef4a
> "mfsd" add addr escaping to fs_location hosts"? I wonder why it wasn't
> noticed then. Maybe the client always just chooses the first entry and
> doesn't care if there's a second entry for a host named "]".
>
> --b.
I think it has been there all along. The linux client doesn't appear to
care about the second entry.
Ben
> >
> > Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> > ---
> > fs/nfsd/nfs4xdr.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index eeea7a9..6c92a53 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> > @@ -1795,6 +1795,9 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
> > }
> > else
> > end++;
> > + if (found_esc)
> > + end = next;
> > +
> > str = end;
> > }
> > pathlen = htonl(xdr->buf->len - pathlen_offset);
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-09 19:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 21:05 [PATCH 0/2] Two nfsd referral xdr encoding bugs Benjamin Coddington
2014-12-07 21:05 ` [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char Benjamin Coddington
2014-12-09 19:24 ` J. Bruce Fields
2014-12-09 19:57 ` Benjamin Coddington
2014-12-07 21:05 ` [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4 Benjamin Coddington
2014-12-09 17:37 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox