From: Jeff Layton <jlayton@kernel.org>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>,
Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e
Date: Thu, 18 Jul 2024 09:13:23 -0400 [thread overview]
Message-ID: <eedd6203b6869d423f5d680eb52b8a3ce56e90ce.camel@kernel.org> (raw)
In-Reply-To: <20240718070640.1913-1-chenhx.fnst@fujitsu.com>
On Thu, 2024-07-18 at 15:06 +0800, Chen Hanxiao wrote:
> __nfs_revalidate_inode may return ETIMEDOUT.
>
> print symbol of ETIMEDOUT in nfs trace:
>
> before:
> cat-5191 [005] 119.331127: nfs_revalidate_inode_exit: error=-110
> (0x6e)
>
> after:
> cat-1738 [004] 44.365509: nfs_revalidate_inode_exit: error=-110
> (TIMEDOUT)
>
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
> include/trace/misc/nfs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/misc/nfs.h b/include/trace/misc/nfs.h
> index 7b221d51133a..c82233e950ac 100644
> --- a/include/trace/misc/nfs.h
> +++ b/include/trace/misc/nfs.h
> @@ -51,6 +51,7 @@ TRACE_DEFINE_ENUM(NFSERR_JUKEBOX);
> { NFSERR_IO, "IO" }, \
> { NFSERR_NXIO, "NXIO" }, \
> { ECHILD, "CHILD" }, \
> + { ETIMEDOUT, "TIMEDOUT" }, \
> { NFSERR_EAGAIN, "AGAIN" }, \
> { NFSERR_ACCES, "ACCES" }, \
> { NFSERR_EXIST, "EXIST" }, \
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-07-18 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 7:06 [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e Chen Hanxiao
2024-07-18 13:13 ` Jeff Layton [this message]
2024-07-19 14:00 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eedd6203b6869d423f5d680eb52b8a3ce56e90ce.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chenhx.fnst@fujitsu.com \
--cc=chuck.lever@oracle.com \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox