* [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e
@ 2024-07-18 7:06 Chen Hanxiao
2024-07-18 13:13 ` Jeff Layton
2024-07-19 14:00 ` Chuck Lever
0 siblings, 2 replies; 3+ messages in thread
From: Chen Hanxiao @ 2024-07-18 7:06 UTC (permalink / raw)
To: Chuck Lever, Jeff Layton, Neil Brown, Olga Kornievskaia, Dai Ngo,
Tom Talpey, Trond Myklebust, Anna Schumaker
Cc: linux-nfs
__nfs_revalidate_inode may return ETIMEDOUT.
print symbol of ETIMEDOUT in nfs trace:
before:
cat-5191 [005] 119.331127: nfs_revalidate_inode_exit: error=-110 (0x6e)
after:
cat-1738 [004] 44.365509: nfs_revalidate_inode_exit: error=-110 (TIMEDOUT)
Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
---
include/trace/misc/nfs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace/misc/nfs.h b/include/trace/misc/nfs.h
index 7b221d51133a..c82233e950ac 100644
--- a/include/trace/misc/nfs.h
+++ b/include/trace/misc/nfs.h
@@ -51,6 +51,7 @@ TRACE_DEFINE_ENUM(NFSERR_JUKEBOX);
{ NFSERR_IO, "IO" }, \
{ NFSERR_NXIO, "NXIO" }, \
{ ECHILD, "CHILD" }, \
+ { ETIMEDOUT, "TIMEDOUT" }, \
{ NFSERR_EAGAIN, "AGAIN" }, \
{ NFSERR_ACCES, "ACCES" }, \
{ NFSERR_EXIST, "EXIST" }, \
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e
2024-07-18 7:06 [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e Chen Hanxiao
@ 2024-07-18 13:13 ` Jeff Layton
2024-07-19 14:00 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2024-07-18 13:13 UTC (permalink / raw)
To: Chen Hanxiao, Chuck Lever, Neil Brown, Olga Kornievskaia, Dai Ngo,
Tom Talpey, Trond Myklebust, Anna Schumaker
Cc: linux-nfs
On Thu, 2024-07-18 at 15:06 +0800, Chen Hanxiao wrote:
> __nfs_revalidate_inode may return ETIMEDOUT.
>
> print symbol of ETIMEDOUT in nfs trace:
>
> before:
> cat-5191 [005] 119.331127: nfs_revalidate_inode_exit: error=-110
> (0x6e)
>
> after:
> cat-1738 [004] 44.365509: nfs_revalidate_inode_exit: error=-110
> (TIMEDOUT)
>
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
> include/trace/misc/nfs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/misc/nfs.h b/include/trace/misc/nfs.h
> index 7b221d51133a..c82233e950ac 100644
> --- a/include/trace/misc/nfs.h
> +++ b/include/trace/misc/nfs.h
> @@ -51,6 +51,7 @@ TRACE_DEFINE_ENUM(NFSERR_JUKEBOX);
> { NFSERR_IO, "IO" }, \
> { NFSERR_NXIO, "NXIO" }, \
> { ECHILD, "CHILD" }, \
> + { ETIMEDOUT, "TIMEDOUT" }, \
> { NFSERR_EAGAIN, "AGAIN" }, \
> { NFSERR_ACCES, "ACCES" }, \
> { NFSERR_EXIST, "EXIST" }, \
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e
2024-07-18 7:06 [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e Chen Hanxiao
2024-07-18 13:13 ` Jeff Layton
@ 2024-07-19 14:00 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2024-07-19 14:00 UTC (permalink / raw)
To: Chen Hanxiao
Cc: Jeff Layton, Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Trond Myklebust, Anna Schumaker, linux-nfs
On Thu, Jul 18, 2024 at 03:06:16PM +0800, Chen Hanxiao wrote:
> __nfs_revalidate_inode may return ETIMEDOUT.
>
> print symbol of ETIMEDOUT in nfs trace:
>
> before:
> cat-5191 [005] 119.331127: nfs_revalidate_inode_exit: error=-110 (0x6e)
>
> after:
> cat-1738 [004] 44.365509: nfs_revalidate_inode_exit: error=-110 (TIMEDOUT)
>
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
> include/trace/misc/nfs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/misc/nfs.h b/include/trace/misc/nfs.h
> index 7b221d51133a..c82233e950ac 100644
> --- a/include/trace/misc/nfs.h
> +++ b/include/trace/misc/nfs.h
> @@ -51,6 +51,7 @@ TRACE_DEFINE_ENUM(NFSERR_JUKEBOX);
> { NFSERR_IO, "IO" }, \
> { NFSERR_NXIO, "NXIO" }, \
> { ECHILD, "CHILD" }, \
> + { ETIMEDOUT, "TIMEDOUT" }, \
> { NFSERR_EAGAIN, "AGAIN" }, \
> { NFSERR_ACCES, "ACCES" }, \
> { NFSERR_EXIST, "EXIST" }, \
> --
> 2.39.1
>
Applied to nfsd-next (for v6.12). Thanks!
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-19 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18 7:06 [PATCH] NFS: trace: show TIMEDOUT instead of 0x6e Chen Hanxiao
2024-07-18 13:13 ` Jeff Layton
2024-07-19 14:00 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox