* [PATCH next] nfsd: Fix a WARN_ONCE() message
@ 2025-02-17 7:33 Dan Carpenter
2025-02-17 13:47 ` Jeff Layton
2025-02-17 14:34 ` cel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-02-17 7:33 UTC (permalink / raw)
To: Olga Kornievskaia
Cc: Chuck Lever, Jeff Layton, Neil Brown, Dai Ngo, Tom Talpey,
linux-nfs, linux-kernel, kernel-janitors
The first parameter of WARN_ONCE() is supposed to be the condition but
it's missing here. This WARN_ONCE() will only print the "xcl_name".
Fixes: 61b490d48618 ("nfsd: fix management of listener transports")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/nfsd/nfsctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 2cd540b26965..ac265d6fde35 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -2027,7 +2027,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
xprt = svc_find_listener(serv, xcl_name, net, sa);
if (xprt) {
if (delete)
- WARN_ONCE("Transport type=%s already exists\n",
+ WARN_ONCE(1, "Transport type=%s already exists\n",
xcl_name);
svc_xprt_put(xprt);
continue;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] nfsd: Fix a WARN_ONCE() message
2025-02-17 7:33 [PATCH next] nfsd: Fix a WARN_ONCE() message Dan Carpenter
@ 2025-02-17 13:47 ` Jeff Layton
2025-02-17 14:34 ` cel
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2025-02-17 13:47 UTC (permalink / raw)
To: Dan Carpenter, Olga Kornievskaia
Cc: Chuck Lever, Neil Brown, Dai Ngo, Tom Talpey, linux-nfs,
linux-kernel, kernel-janitors
On Mon, 2025-02-17 at 10:33 +0300, Dan Carpenter wrote:
> The first parameter of WARN_ONCE() is supposed to be the condition but
> it's missing here. This WARN_ONCE() will only print the "xcl_name".
>
> Fixes: 61b490d48618 ("nfsd: fix management of listener transports")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 2cd540b26965..ac265d6fde35 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -2027,7 +2027,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
> xprt = svc_find_listener(serv, xcl_name, net, sa);
> if (xprt) {
> if (delete)
> - WARN_ONCE("Transport type=%s already exists\n",
> + WARN_ONCE(1, "Transport type=%s already exists\n",
> xcl_name);
> svc_xprt_put(xprt);
> continue;
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] nfsd: Fix a WARN_ONCE() message
2025-02-17 7:33 [PATCH next] nfsd: Fix a WARN_ONCE() message Dan Carpenter
2025-02-17 13:47 ` Jeff Layton
@ 2025-02-17 14:34 ` cel
1 sibling, 0 replies; 3+ messages in thread
From: cel @ 2025-02-17 14:34 UTC (permalink / raw)
To: Olga Kornievskaia, Dan Carpenter
Cc: Chuck Lever, Jeff Layton, Neil Brown, Dai Ngo, Tom Talpey,
linux-nfs, linux-kernel, kernel-janitors
From: Chuck Lever <chuck.lever@oracle.com>
On Mon, 17 Feb 2025 10:33:31 +0300, Dan Carpenter wrote:
> The first parameter of WARN_ONCE() is supposed to be the condition but
> it's missing here. This WARN_ONCE() will only print the "xcl_name".
>
>
Squashed into nfsd-next, thanks!
[1/1] nfsd: Fix a WARN_ONCE() message
(no commit info)
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-17 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 7:33 [PATCH next] nfsd: Fix a WARN_ONCE() message Dan Carpenter
2025-02-17 13:47 ` Jeff Layton
2025-02-17 14:34 ` cel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox