Linux NILFS development
 help / color / mirror / Atom feed
* NILFS errors.
@ 2009-10-02 10:46 Yuri Chislov
       [not found] ` <200910021246.19909.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Yuri Chislov @ 2009-10-02 10:46 UTC (permalink / raw)
  To: NILFS Users mailing list

Hi,

  It's look, like corrupted file system.

 Used kernel:
 2.6.31.1 + 
"fix missing zero-fill initialization of btree node cache" patch +
"fix missing initialization of i_dir_start_lookup member" patch

Errors in dmesg:
NILFS error (device md4): nilfs_check_page: bad entry in directory #53267: 
unaligned directory entry - offset=0, inode=1970562386, rec_len=29793, 
name_len=104
NILFS error (device md4): nilfs_readdir: bad page in #53267
NILFS error (device md4): nilfs_readdir: bad page in #53267
NILFS error (device md4): nilfs_readdir: bad page in #53267
NILFS error (device md4): nilfs_readdir: bad page in #53267
NILFS error (device md4): nilfs_readdir: bad page in #53267
init_special_inode: bogus i_mode (53563)
init_special_inode: bogus i_mode (52465)
init_special_inode: bogus i_mode (31155)
NILFS error (device md4): nilfs_readdir: bad page in #53267

Commands output:
 ls -la
total 164
drwx------ 12 mik users  4096 2009-10-02 12:27 .
drwx------  3 mik users  4096 2004-11-04 12:05 ..
drwx------  6 mik users  4096 2009-09-27 03:11 .aaa Inbox Archive
drwx------  2 mik users  4096 2004-07-25 09:06 courierimapkeywords
drwx------  6 mik users  4096 2009-10-02 12:36 .Sent Archive

ls -la .aaa\ Inbox\ Archive/
ls: reading directory .aaa Inbox Archive/: Input/output error

ls -la .Sent\ Archive/
total 5932871552481704068
drwx------     6 mik        users                     4096 2009-10-02 12:36 .
drwx------    12 mik        users                     4096 2009-10-02 12:27 ..
cr-SrwSrwT 30768 1801873002 1496920692        1613, 231244 2027-01-27 06:53 
courierimapkeywords
dr-xrwSr-t 30062 1165184817  873096304 8671482274525501817 2026-01-19 19:18 
courierimapuiddb
drwx------     2 mik        users                     4096 2009-07-31 15:21 
cur
-rw-------     1 mik        users                    22528 2009-09-29 10:05 
dovecot.index.cache
-rw-------     1 mik        users                      896 2009-09-27 22:50 
dovecot.index.log
-rw-------     1 mik        users                     1126 2009-09-25 14:26 
dovecot-uidlist
?--x-w-r-t 29739 1110729523  826363463 7235987552073157170 2033-05-31 16:29 
maildirfolder
?r-xr---wt 22328  929450849 1399928645 4121162288830115449 1975-07-20 07:56 
new
drwx------     2 mik        users                     4096 2009-10-02 12:20 
tmp

ls -la .Sent\ Archive/new
?r-xr---wt 22328 929450849 1399928645 4121162288830115449 1975-07-20 07:56 
.Sent Archive/new

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found] ` <200910021246.19909.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
@ 2009-10-02 11:55   ` Ryusuke Konishi
       [not found]     ` <20091002.205508.118939509.ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Ryusuke Konishi @ 2009-10-02 11:55 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg, yuri-EJC0RcYdacHR7s880joybQ

On Fri, 2 Oct 2009 12:46:19 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> Hi,
> 
>   It's look, like corrupted file system.
> 
>  Used kernel:
>  2.6.31.1 + 
> "fix missing zero-fill initialization of btree node cache" patch +
> "fix missing initialization of i_dir_start_lookup member" patch
> 
> Errors in dmesg:
> NILFS error (device md4): nilfs_check_page: bad entry in directory #53267: 
> unaligned directory entry - offset=0, inode=1970562386, rec_len=29793, 
> name_len=104
> NILFS error (device md4): nilfs_readdir: bad page in #53267
> NILFS error (device md4): nilfs_readdir: bad page in #53267
> NILFS error (device md4): nilfs_readdir: bad page in #53267
> NILFS error (device md4): nilfs_readdir: bad page in #53267
> NILFS error (device md4): nilfs_readdir: bad page in #53267
> init_special_inode: bogus i_mode (53563)
> init_special_inode: bogus i_mode (52465)
> init_special_inode: bogus i_mode (31155)
> NILFS error (device md4): nilfs_readdir: bad page in #53267
>
> Commands output:
>  ls -la
> total 164
> drwx------ 12 mik users  4096 2009-10-02 12:27 .
> drwx------  3 mik users  4096 2004-11-04 12:05 ..
> drwx------  6 mik users  4096 2009-09-27 03:11 .aaa Inbox Archive
> drwx------  2 mik users  4096 2004-07-25 09:06 courierimapkeywords
> drwx------  6 mik users  4096 2009-10-02 12:36 .Sent Archive
> 
> ls -la .aaa\ Inbox\ Archive/
> ls: reading directory .aaa Inbox Archive/: Input/output error
> 
> ls -la .Sent\ Archive/
> total 5932871552481704068
> drwx------     6 mik        users                     4096 2009-10-02 12:36 .
> drwx------    12 mik        users                     4096 2009-10-02 12:27 ..
> cr-SrwSrwT 30768 1801873002 1496920692        1613, 231244 2027-01-27 06:53 
> courierimapkeywords
> dr-xrwSr-t 30062 1165184817  873096304 8671482274525501817 2026-01-19 19:18 
> courierimapuiddb
> drwx------     2 mik        users                     4096 2009-07-31 15:21 
> cur
> -rw-------     1 mik        users                    22528 2009-09-29 10:05 
> dovecot.index.cache
> -rw-------     1 mik        users                      896 2009-09-27 22:50 
> dovecot.index.log
> -rw-------     1 mik        users                     1126 2009-09-25 14:26 
> dovecot-uidlist
> ?--x-w-r-t 29739 1110729523  826363463 7235987552073157170 2033-05-31 16:29 
> maildirfolder
> ?r-xr---wt 22328  929450849 1399928645 4121162288830115449 1975-07-20 07:56 
> new
> drwx------     2 mik        users                     4096 2009-10-02 12:20 
> tmp
> 
> ls -la .Sent\ Archive/new
> ?r-xr---wt 22328 929450849 1399928645 4121162288830115449 1975-07-20 07:56 
> .Sent Archive/new

Grrr, my patch missed your problem? Sigh.

Didn't you see any write I/O errors before these messages?

Regards,
Ryusuke Konishi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found]     ` <20091002.205508.118939509.ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2009-10-02 16:57       ` Yuri Chislov
       [not found]         ` <200910021857.28569.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Yuri Chislov @ 2009-10-02 16:57 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg

On Friday 02 October 2009 13:55:08 Ryusuke Konishi wrote:
> On Fri, 2 Oct 2009 12:46:19 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> > Hi,
> >
> >   It's look, like corrupted file system.
> >
> >  Used kernel:
> >  2.6.31.1 +
> > "fix missing zero-fill initialization of btree node cache" patch +
> > "fix missing initialization of i_dir_start_lookup member" patch
> >
> > Errors in dmesg:
> > NILFS error (device md4): nilfs_check_page: bad entry in directory
> > #53267: unaligned directory entry - offset=0, inode=1970562386,
> > rec_len=29793, name_len=104
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > init_special_inode: bogus i_mode (53563)
> > init_special_inode: bogus i_mode (52465)
> > init_special_inode: bogus i_mode (31155)
> > NILFS error (device md4): nilfs_readdir: bad page in #53267
> >
> > Commands output:
> >  ls -la
> > total 164
> > drwx------ 12 mik users  4096 2009-10-02 12:27 .
> > drwx------  3 mik users  4096 2004-11-04 12:05 ..
> > drwx------  6 mik users  4096 2009-09-27 03:11 .aaa Inbox Archive
> > drwx------  2 mik users  4096 2004-07-25 09:06 courierimapkeywords
> > drwx------  6 mik users  4096 2009-10-02 12:36 .Sent Archive
> >
> > ls -la .aaa\ Inbox\ Archive/
> > ls: reading directory .aaa Inbox Archive/: Input/output error
> >
> > ls -la .Sent\ Archive/
> > total 5932871552481704068
> > drwx------     6 mik        users                     4096 2009-10-02
> > 12:36 . drwx------    12 mik        users                     4096
> > 2009-10-02 12:27 .. cr-SrwSrwT 30768 1801873002 1496920692        1613,
> > 231244 2027-01-27 06:53 courierimapkeywords
> > dr-xrwSr-t 30062 1165184817  873096304 8671482274525501817 2026-01-19
> > 19:18 courierimapuiddb
> > drwx------     2 mik        users                     4096 2009-07-31
> > 15:21 cur
> > -rw-------     1 mik        users                    22528 2009-09-29
> > 10:05 dovecot.index.cache
> > -rw-------     1 mik        users                      896 2009-09-27
> > 22:50 dovecot.index.log
> > -rw-------     1 mik        users                     1126 2009-09-25
> > 14:26 dovecot-uidlist
> > ?--x-w-r-t 29739 1110729523  826363463 7235987552073157170 2033-05-31
> > 16:29 maildirfolder
> > ?r-xr---wt 22328  929450849 1399928645 4121162288830115449 1975-07-20
> > 07:56 new
> > drwx------     2 mik        users                     4096 2009-10-02
> > 12:20 tmp
> >
> > ls -la .Sent\ Archive/new
> > ?r-xr---wt 22328 929450849 1399928645 4121162288830115449 1975-07-20
> > 07:56 .Sent Archive/new
> 
> Grrr, my patch missed your problem? Sigh.
> 
> Didn't you see any write I/O errors before these messages?
> 
> Regards,
> Ryusuke Konishi
> _______________________________________________
> users mailing list
> users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org
> https://www.nilfs.org/mailman/listinfo/users
> 
Hi,

This is all, that I can find in logs:
The kernel was updated Oct 1.

Sep 27 02:17:28 gw-0 kernel: NILFS warning: mounting unchecked fs
Sep 27 02:17:28 gw-0 kernel: NILFS: recovery complete.
Sep 27 03:05:52 gw-0 kernel: NILFS warning: mounting unchecked fs
Sep 27 03:05:52 gw-0 kernel: NILFS: recovery complete.
Sep 27 19:09:04 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
entry in directory #22314: unaligned directory entry - offset=0, 
inode=1668369006, rec_len=19054, name_len=54
Sep 27 19:09:04 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #22314
Sep 28 03:09:22 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #22314
Sep 28 09:52:51 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
entry in directory #22310: unaligned directory entry - offset=0, 
inode=1047084094, rec_len=28787, name_len=97
Sep 28 11:17:42 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #22310
Sep 28 11:18:25 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #22310
Sep 28 14:16:36 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #22310
Oct  1 17:06:03 gw-0 kernel: NILFS warning: mounting fs with errors
Oct  2 08:25:17 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
entry in directory #53267: unaligned directory entry - offset=0, 
inode=1970562386, rec_len=29793, name_len=104
Oct  2 12:27:06 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:27:07 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:27:08 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:27:09 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:27:09 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:31:44 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267
Oct  2 12:38:37 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
in #53267

Is it possible that the issue related to software raid(used RAID1)? 

Thank you.
Yuri. 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found]         ` <200910021857.28569.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
@ 2009-10-03  4:11           ` Ryusuke Konishi
       [not found]             ` <20091003.131155.120264262.ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Ryusuke Konishi @ 2009-10-03  4:11 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg, yuri-EJC0RcYdacHR7s880joybQ

Hi Yuri,
On Fri, 2 Oct 2009 18:57:28 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> On Friday 02 October 2009 13:55:08 Ryusuke Konishi wrote:
> > On Fri, 2 Oct 2009 12:46:19 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> > > Hi,
> > >
> > >   It's look, like corrupted file system.
> > >
> > >  Used kernel:
> > >  2.6.31.1 +
> > > "fix missing zero-fill initialization of btree node cache" patch +
> > > "fix missing initialization of i_dir_start_lookup member" patch
> > >
> > > Errors in dmesg:
> > > NILFS error (device md4): nilfs_check_page: bad entry in directory
> > > #53267: unaligned directory entry - offset=0, inode=1970562386,
> > > rec_len=29793, name_len=104
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > > init_special_inode: bogus i_mode (53563)
> > > init_special_inode: bogus i_mode (52465)
> > > init_special_inode: bogus i_mode (31155)
> > > NILFS error (device md4): nilfs_readdir: bad page in #53267
> > >
> > > Commands output:
> > >  ls -la
> > > total 164
> > > drwx------ 12 mik users  4096 2009-10-02 12:27 .
> > > drwx------  3 mik users  4096 2004-11-04 12:05 ..
> > > drwx------  6 mik users  4096 2009-09-27 03:11 .aaa Inbox Archive
> > > drwx------  2 mik users  4096 2004-07-25 09:06 courierimapkeywords
> > > drwx------  6 mik users  4096 2009-10-02 12:36 .Sent Archive
> > >
> > > ls -la .aaa\ Inbox\ Archive/
> > > ls: reading directory .aaa Inbox Archive/: Input/output error
> > >
> > > ls -la .Sent\ Archive/
> > > total 5932871552481704068
> > > drwx------     6 mik        users                     4096 2009-10-02
> > > 12:36 . drwx------    12 mik        users                     4096
> > > 2009-10-02 12:27 .. cr-SrwSrwT 30768 1801873002 1496920692        1613,
> > > 231244 2027-01-27 06:53 courierimapkeywords
> > > dr-xrwSr-t 30062 1165184817  873096304 8671482274525501817 2026-01-19
> > > 19:18 courierimapuiddb
> > > drwx------     2 mik        users                     4096 2009-07-31
> > > 15:21 cur
> > > -rw-------     1 mik        users                    22528 2009-09-29
> > > 10:05 dovecot.index.cache
> > > -rw-------     1 mik        users                      896 2009-09-27
> > > 22:50 dovecot.index.log
> > > -rw-------     1 mik        users                     1126 2009-09-25
> > > 14:26 dovecot-uidlist
> > > ?--x-w-r-t 29739 1110729523  826363463 7235987552073157170 2033-05-31
> > > 16:29 maildirfolder
> > > ?r-xr---wt 22328  929450849 1399928645 4121162288830115449 1975-07-20
> > > 07:56 new
> > > drwx------     2 mik        users                     4096 2009-10-02
> > > 12:20 tmp
> > >
> > > ls -la .Sent\ Archive/new
> > > ?r-xr---wt 22328 929450849 1399928645 4121162288830115449 1975-07-20
> > > 07:56 .Sent Archive/new
> > 
> > Grrr, my patch missed your problem? Sigh.
> > 
> > Didn't you see any write I/O errors before these messages?
> > 
> > Regards,
> > Ryusuke Konishi
> > _______________________________________________
> > users mailing list
> > users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org
> > https://www.nilfs.org/mailman/listinfo/users
> > 
> Hi,
> 
> This is all, that I can find in logs:
> The kernel was updated Oct 1.
> 
> Sep 27 02:17:28 gw-0 kernel: NILFS warning: mounting unchecked fs
> Sep 27 02:17:28 gw-0 kernel: NILFS: recovery complete.
> Sep 27 03:05:52 gw-0 kernel: NILFS warning: mounting unchecked fs
> Sep 27 03:05:52 gw-0 kernel: NILFS: recovery complete.
> Sep 27 19:09:04 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
> entry in directory #22314: unaligned directory entry - offset=0, 
> inode=1668369006, rec_len=19054, name_len=54
> Sep 27 19:09:04 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #22314
> Sep 28 03:09:22 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #22314
> Sep 28 09:52:51 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
> entry in directory #22310: unaligned directory entry - offset=0, 
> inode=1047084094, rec_len=28787, name_len=97
> Sep 28 11:17:42 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #22310
> Sep 28 11:18:25 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #22310
> Sep 28 14:16:36 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #22310
> Oct  1 17:06:03 gw-0 kernel: NILFS warning: mounting fs with errors
> Oct  2 08:25:17 gw-0 kernel: NILFS error (device md4): nilfs_check_page: bad 
> entry in directory #53267: unaligned directory entry - offset=0, 
> inode=1970562386, rec_len=29793, name_len=104
> Oct  2 12:27:06 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:27:07 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:27:08 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:27:09 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:27:09 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:31:44 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
> Oct  2 12:38:37 gw-0 kernel: NILFS error (device md4): nilfs_readdir: bad page 
> in #53267
 
> Sep 27 02:17:28 gw-0 kernel: NILFS warning: mounting unchecked fs
> Sep 27 02:17:28 gw-0 kernel: NILFS: recovery complete.
> Sep 27 03:05:52 gw-0 kernel: NILFS warning: mounting unchecked fs
> Sep 27 03:05:52 gw-0 kernel: NILFS: recovery complete.

Looks there were unclean shutdowns before the read errors.

If the corruption happened before you applied the "fix missing
zero-fill initialization of btree node cache" patch, it doesn't help
because the patch only prevents new corruption and does not correct
corrupted data on disk.


> Is it possible that the issue related to software raid(used RAID1)? 

Well, I guess the corruption didn't come from data loss on the md
layer.  OTOH, there is a possibility that md behavior has affected
nilfs.

Could you confirm if the following patch makes a difference?

This patch doesn't recover corrupted file system, so you need a new
file system.  But, this can prevent the directory corruption if it
came from bio allocation errors on write path.

The patch was already merged at 2.6.32-rc1 but not yet backported
to 2.6.31.y and 2.6.30.y.

If the patch is confirmed to have effect on your problem, I will send
it to -stable trees.

Thanks,
Ryusuke Konishi

diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index 9e3fe17..e6d9e37 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
@@ -316,10 +316,10 @@ static struct bio *nilfs_alloc_seg_bio(struct super_block *sb, sector_t start,
 {
 	struct bio *bio;
 
-	bio = bio_alloc(GFP_NOWAIT, nr_vecs);
+	bio = bio_alloc(GFP_NOIO, nr_vecs);
 	if (bio == NULL) {
 		while (!bio && (nr_vecs >>= 1))
-			bio = bio_alloc(GFP_NOWAIT, nr_vecs);
+			bio = bio_alloc(GFP_NOIO, nr_vecs);
 	}
 	if (likely(bio)) {
 		bio->bi_bdev = sb->s_bdev;

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found]             ` <20091003.131155.120264262.ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2009-10-03 10:21               ` Yuri Chislov
       [not found]                 ` <200910031221.34016.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Yuri Chislov @ 2009-10-03 10:21 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg

On Saturday 03 October 2009 06:11:55 Ryusuke Konishi wrote:
> Well, I guess the corruption didn't come from data loss on the md
> layer.  OTOH, there is a possibility that md behavior has affected
> nilfs.
> 
> Could you confirm if the following patch makes a difference?
> 
> This patch doesn't recover corrupted file system, so you need a new
> file system.  But, this can prevent the directory corruption if it
> came from bio allocation errors on write path.
> 
> The patch was already merged at 2.6.32-rc1 but not yet backported
> to 2.6.31.y and 2.6.30.y.
> 
> If the patch is confirmed to have effect on your problem, I will send
> it to -stable trees.
> 
> Thanks,
> Ryusuke Konishi
> 
> diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
> index 9e3fe17..e6d9e37 100644
> --- a/fs/nilfs2/segbuf.c
> +++ b/fs/nilfs2/segbuf.c
> @@ -316,10 +316,10 @@ static struct bio *nilfs_alloc_seg_bio(struct
>  super_block *sb, sector_t start, {
>         struct bio *bio;
>  
> -       bio = bio_alloc(GFP_NOWAIT, nr_vecs);
> +       bio = bio_alloc(GFP_NOIO, nr_vecs);
>         if (bio == NULL) {
>                 while (!bio && (nr_vecs >>= 1))
> -                       bio = bio_alloc(GFP_NOWAIT, nr_vecs);
> +                       bio = bio_alloc(GFP_NOIO, nr_vecs);
>         }
>         if (likely(bio)) {
>                 bio->bi_bdev = sb->s_bdev;
> 

Thank you for patch. I have install it just now and reformat /dev/md4.
Is it planned some fsck tool? I can help with tests if necessary.

Yuri. 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found]                 ` <200910031221.34016.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
@ 2009-10-03 11:13                   ` Ryusuke Konishi
       [not found]                     ` <20091003.201330.10734740.ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Ryusuke Konishi @ 2009-10-03 11:13 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg, yuri-EJC0RcYdacHR7s880joybQ

On Sat, 3 Oct 2009 12:21:33 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> Thank you for patch. I have install it just now and reformat /dev/md4.
> Is it planned some fsck tool?

Unfortunately No (at least for the time being).

> I can help with tests if necessary.
> Yuri. 

Yes, I would appreciate if you could help testing.

Before that, please let me know whether the corruption is reproducible
on a new file system after applying the "fix missing zero-fill
initialization of btree node cache" patch.

It is necessary to narrow down the cause of your problem.
 
Thank you,
Ryusuke Konishi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NILFS errors.
       [not found]                     ` <20091003.201330.10734740.ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2009-10-03 11:48                       ` Yuri Chislov
  0 siblings, 0 replies; 7+ messages in thread
From: Yuri Chislov @ 2009-10-03 11:48 UTC (permalink / raw)
  To: users-JrjvKiOkagjYtjvyW6yDsg

On Saturday 03 October 2009 13:13:30 Ryusuke Konishi wrote:
> On Sat, 3 Oct 2009 12:21:33 +0200, Yuri Chislov <yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org> wrote:
> > Thank you for patch. I have install it just now and reformat /dev/md4.
> > Is it planned some fsck tool?
> 
> Unfortunately No (at least for the time being).
> 
> > I can help with tests if necessary.
> > Yuri.
> 
> Yes, I would appreciate if you could help testing.
> 
> Before that, please let me know whether the corruption is reproducible
> on a new file system after applying the "fix missing zero-fill
> initialization of btree node cache" patch.
> 
> It is necessary to narrow down the cause of your problem.
> 
> Thank you,
> Ryusuke Konishi
> _______________________________________________
> users mailing list
> users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org
> https://www.nilfs.org/mailman/listinfo/users
> 
All work well, right for now. I will send mail to list if some errors appear.

Yuri.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-10-03 11:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-02 10:46 NILFS errors Yuri Chislov
     [not found] ` <200910021246.19909.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
2009-10-02 11:55   ` Ryusuke Konishi
     [not found]     ` <20091002.205508.118939509.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-10-02 16:57       ` Yuri Chislov
     [not found]         ` <200910021857.28569.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
2009-10-03  4:11           ` Ryusuke Konishi
     [not found]             ` <20091003.131155.120264262.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-10-03 10:21               ` Yuri Chislov
     [not found]                 ` <200910031221.34016.yuri-EJC0RcYdacHR7s880joybQ@public.gmane.org>
2009-10-03 11:13                   ` Ryusuke Konishi
     [not found]                     ` <20091003.201330.10734740.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-10-03 11:48                       ` Yuri Chislov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox