* [PATCH v6 02/11] nilfs2: drop usage of page_index
[not found] <20240521175854.96038-1-ryncsn@gmail.com>
@ 2024-05-21 17:58 ` Kairui Song
0 siblings, 0 replies; only message in thread
From: Kairui Song @ 2024-05-21 17:58 UTC (permalink / raw)
To: linux-mm
Cc: Andrew Morton, Huang, Ying, Matthew Wilcox, Chris Li, Barry Song,
Ryan Roberts, Neil Brown, Minchan Kim, David Hildenbrand,
Hugh Dickins, Yosry Ahmed, linux-fsdevel, linux-kernel,
Kairui Song, Ryusuke Konishi, linux-nilfs
From: Kairui Song <kasong@tencent.com>
page_index is only for mixed usage of page cache and swap cache, for
pure page cache usage, the caller can just use page->index instead.
It can't be a swap cache page here (being part of buffer head),
so just drop it. And while we are at it, optimize the code by retrieving
the offset of the buffer head within the folio directly using bh_offset,
and get rid of the loop and usage of page helpers.
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Kairui Song <kasong@tencent.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: linux-nilfs@vger.kernel.org
---
fs/nilfs2/bmap.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c
index 383f0afa2cea..cd14ea25968c 100644
--- a/fs/nilfs2/bmap.c
+++ b/fs/nilfs2/bmap.c
@@ -450,15 +450,9 @@ int nilfs_bmap_test_and_clear_dirty(struct nilfs_bmap *bmap)
__u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap,
const struct buffer_head *bh)
{
- struct buffer_head *pbh;
- __u64 key;
+ loff_t pos = folio_pos(bh->b_folio) + bh_offset(bh);
- key = page_index(bh->b_page) << (PAGE_SHIFT -
- bmap->b_inode->i_blkbits);
- for (pbh = page_buffers(bh->b_page); pbh != bh; pbh = pbh->b_this_page)
- key++;
-
- return key;
+ return pos >> bmap->b_inode->i_blkbits;
}
__u64 nilfs_bmap_find_target_seq(const struct nilfs_bmap *bmap, __u64 key)
--
2.45.0
^ permalink raw reply related [flat|nested] only message in thread