From: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
To: NILFS Users mailing list <users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH 2/3] nilfs2: clean up nilfs_write_super
Date: Sat, 18 Jul 2009 16:00:33 +0900 [thread overview]
Message-ID: <87k526qxv2.wl%jir@sekiba.com> (raw)
In-Reply-To: <20090718.012414.19435380.ryusuke-sG5X7nlA6pw@public.gmane.org>
Hi,
Thank you for the comments!
At Sat, 18 Jul 2009 01:24:14 +0900 (JST),
Ryusuke Konishi wrote:
> The nilfs_update_super() sounds like a function to do update operation
> on the super block.
>
> How about nilfs_sb_need_update() or so?
ok, looks better.
> And then, this patch has some style problems. Applying checkpatch.pl
> can save a bit of time.
Grr. I might send the wrong one.
I'll revise the patch and resend it again.
regards,
--
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
next prev parent reply other threads:[~2009-07-18 7:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 9:12 [PATCH 0/3] write_super clean up Jiro SEKIBA
[not found] ` <1247821968-31232-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-17 9:12 ` [PATCH 1/3] nilfs2: fix disorder of nilfs_write_super in nilfs_sync_fs Jiro SEKIBA
[not found] ` <1247821968-31232-2-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-17 15:34 ` Ryusuke Konishi
2009-07-17 9:12 ` [PATCH 2/3] nilfs2: clean up nilfs_write_super Jiro SEKIBA
[not found] ` <1247821968-31232-3-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-17 16:24 ` Ryusuke Konishi
[not found] ` <20090718.012414.19435380.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-07-18 7:00 ` Jiro SEKIBA [this message]
2009-07-17 9:12 ` [PATCH 3/3] nilfs2: stop using periodic write_super callback Jiro SEKIBA
[not found] ` <1247821968-31232-4-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-17 18:04 ` Ryusuke Konishi
[not found] ` <20090718.030421.01787640.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-07-18 7:24 ` Jiro SEKIBA
[not found] ` <87iqhqqwrq.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2009-07-18 9:25 ` Ryusuke Konishi
[not found] ` <20090718.182532.52205748.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-07-19 5:25 ` Jiro SEKIBA
2009-07-17 13:23 ` [PATCH 0/3] write_super clean up Ryusuke Konishi
-- strict thread matches above, loose matches on Subject: below --
2009-07-19 5:26 [PATCH 0/3] v2: " Jiro SEKIBA
[not found] ` <1247981182-14831-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-19 5:26 ` [PATCH 2/3] nilfs2: clean up nilfs_write_super Jiro SEKIBA
2009-07-22 8:45 [PATCH 0/3] v3: write_super clean up Jiro SEKIBA
[not found] ` <1248252323-22959-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-07-22 8:45 ` [PATCH 2/3] nilfs2: clean up nilfs_write_super Jiro SEKIBA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k526qxv2.wl%jir@sekiba.com \
--to=jir-hfpbi5wx9j54eiagz67ipq@public.gmane.org \
--cc=users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox