From: Lee Schermerhorn <lee.schermerhorn@hp.com>
To: Cliff Wickman <cpi@sgi.com>
Cc: Kornilios Kourtis <kkourt@cslab.ece.ntua.gr>,
Brice Goglin <Brice.Goglin@inria.fr>,
linux-numa@vger.kernel.org, eric.whitney@hp.com
Subject: [PATCH 8/8] numactl/test - Make checkaffinity more robust
Date: Tue, 28 Apr 2009 12:37:08 -0400 [thread overview]
Message-ID: <20090428163708.24945.56292.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090428163621.24945.95516.sendpatchset@localhost.localdomain>
[PATCH 08/08] Make 'checkaffinity' test script more robust
Against: numactl-2.0.3-rc2
Add quotes around operands in test expressions, lest empty strings
in the case of numactl failure result in shell errors, obscuring the
test error message.
test/checkaffinity | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: numactl-2.0.3-rc2/test/checkaffinity
===================================================================
--- numactl-2.0.3-rc2.orig/test/checkaffinity 2009-02-13 11:17:57.000000000 -0500
+++ numactl-2.0.3-rc2/test/checkaffinity 2009-02-13 11:35:27.000000000 -0500
@@ -9,11 +9,11 @@ numcpus=$(grep -c processor /proc/cpuinf
numnodes=$(ls -1d /sys/devices/system/node/node[0-9]* | wc -l )
for i in $(seq 0 $[$numcpus - 1]) ; do
- if [ $(numactl --physcpubind=$i ./printcpu) != $i ] ; then
+ if [ "$(numactl --physcpubind=$i ./printcpu)" != "$i" ] ; then
echo "--physcpubind for $i doesn't work"
exit 1
fi
- if [ $(numactl --physcpubind=$i numactl --show | awk '/^physcpubind/ { print $2 }' ) != $i ] ; then
+ if [ "$(numactl --physcpubind=$i numactl --show | awk '/^physcpubind/ { print $2 }' )" != "$i" ] ; then
echo "--show doesn't agree with physcpubind for cpu $i"
exit 1
fi
next prev parent reply other threads:[~2009-04-28 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 16:36 [PATCH 0/8] numactl/libnuma - Fixes and Cleanup Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 1/8] numactl/libnuma - Possibly already fixed leaks and cleanup Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 2/8] numactl/libnuma - Simple bitmask leak fixes Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 3/8] numactl/libnuma - more " Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 4/8] numactl/libnuma - return freeable bitmasks Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 5/8] numactl/libnuma - fix parsing of cpu, node mask Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 6/8] numactl/numademo - eliminate page allocation overhead from memtest measurements Lee Schermerhorn
2009-04-28 16:37 ` [PATCH 7/8] numactl/Makefile - Generalize Makefile .so Version Lee Schermerhorn
2009-04-28 16:46 ` Andi Kleen
2009-04-28 17:01 ` Lee Schermerhorn
2009-04-28 17:10 ` Andi Kleen
2009-04-28 16:37 ` Lee Schermerhorn [this message]
2009-04-28 19:38 ` [PATCH 0/8] numactl/libnuma - Fixes and Cleanup Cliff Wickman
2009-04-28 20:08 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428163708.24945.56292.sendpatchset@localhost.localdomain \
--to=lee.schermerhorn@hp.com \
--cc=Brice.Goglin@inria.fr \
--cc=cpi@sgi.com \
--cc=eric.whitney@hp.com \
--cc=kkourt@cslab.ece.ntua.gr \
--cc=linux-numa@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox