From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] libnvdimm: allow legacy (e820) pmem region to clear bad blocks
Date: Fri, 9 Sep 2016 00:28:59 +0000 [thread overview]
Message-ID: <1473380906.3095.9.camel@intel.com> (raw)
In-Reply-To: <147337760801.38083.16900960834862325097.stgit@djiang5-desk3.ch.intel.com>
On Thu, 2016-09-08 at 16:33 -0700, Dave Jiang wrote:
> Bad blocks can be injected via /sys/block/pmemN/badblocks. In a
> situation
> where legacy pmem is being used or a pmem region created by using
> memmap
> kernel parameter, the injected bad blocks are not cleared due to
> nvdimm_clear_poison() failing from lack of ndctl function pointer. In
> this case we need to just return as handled and allow the bad blocks
> to
> be cleared rather than fail.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/bus.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Looks good to me!
Reveiewed-by: Vishal Verma <Vishal.l.verma@intel.com>
>
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 458daf9..935866f 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -185,8 +185,12 @@ long nvdimm_clear_poison(struct device *dev,
> phys_addr_t phys,
> return -ENXIO;
>
> nd_desc = nvdimm_bus->nd_desc;
> + /*
> + * if ndctl does not exist, it's PMEM_LEGACY and
> + * we want to just pretend everything is handled.
> + */
> if (!nd_desc->ndctl)
> - return -ENXIO;
> + return len;
>
> memset(&ars_cap, 0, sizeof(ars_cap));
> ars_cap.address = phys;
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-09-09 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 23:33 [PATCH] libnvdimm: allow legacy (e820) pmem region to clear bad blocks Dave Jiang
2016-09-09 0:28 ` Verma, Vishal L [this message]
2016-09-09 3:57 ` Dan Williams
2016-09-09 17:45 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473380906.3095.9.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox